diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/Documentation/Changes linux-2.4.30-pre2/Documentation/Changes --- linux-2.4.29/Documentation/Changes 2005-01-19 14:09:22.000000000 +0000 +++ linux-2.4.30-pre2/Documentation/Changes 2005-02-23 07:46:31.000000000 +0000 @@ -341,7 +341,7 @@ o +o Reiserfsprogs ------------- diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/Documentation/filesystems/jfs.txt linux-2.4.30-pre2/Documentation/filesystems/jfs.txt --- linux-2.4.29/Documentation/filesystems/jfs.txt 2003-11-28 18:26:19.000000000 +0000 +++ linux-2.4.30-pre2/Documentation/filesystems/jfs.txt 2005-02-23 07:45:50.000000000 +0000 @@ -1,13 +1,6 @@ IBM's Journaled File System (JFS) for Linux -JFS Homepage: http://oss.software.ibm.com/jfs/ - -Team members ------------- -Dave Kleikamp shaggy@austin.ibm.com -Dave Blaschke blaschke@us.ibm.com -Steve Best sbest@us.ibm.com -Barry Arndt barndt@us.ibm.com +JFS Homepage: http://jfs.sourceforge.net/ The following mount options are supported: @@ -15,7 +8,8 @@ iocharset=name Character set to use for ASCII. The default is compiled into the kernel as CONFIG_NLS_DEFAULT. Use iocharset=utf8 for UTF8 translations. This requires CONFIG_NLS_UTF8 to be set - in the kernel .config file. + in the kernel .config file. Specify iocharset=none for + no conversion (default linux-2.6 behavior). resize=value Resize the volume to blocks. JFS only supports growing a volume, not shrinking it. This option is only @@ -51,4 +45,4 @@ Longer term work items Please send bugs, comments, cards and letters to shaggy@austin.ibm.com. The JFS mailing list can be subscribed to by using the link labeled -"Mail list Subscribe" at our web page http://oss.software.ibm.com/jfs/. +"Mail list Subscribe" at our web page http://jfs.sourceforge.net/. diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/Documentation/i2c/writing-clients linux-2.4.30-pre2/Documentation/i2c/writing-clients --- linux-2.4.29/Documentation/i2c/writing-clients 2004-11-17 11:54:20.000000000 +0000 +++ linux-2.4.30-pre2/Documentation/i2c/writing-clients 2005-02-23 07:45:00.000000000 +0000 @@ -380,9 +380,6 @@ detection just fails for this address, r For now, you can ignore the `flags' parameter. It is there for future use. - /* Unique ID allocation */ - static int foo_id = 0; - int foo_detect_client(struct i2c_adapter *adapter, int address, unsigned short flags, int kind) { @@ -518,7 +515,6 @@ For now, you can ignore the `flags' para data->type = kind; /* SENSORS ONLY END */ - new_client->id = foo_id++; /* Automatically unique */ data->valid = 0; /* Only if you use this field */ init_MUTEX(&data->update_lock); /* Only if you use this field */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/MAINTAINERS linux-2.4.30-pre2/MAINTAINERS --- linux-2.4.29/MAINTAINERS 2005-01-19 14:09:24.000000000 +0000 +++ linux-2.4.30-pre2/MAINTAINERS 2005-02-23 07:45:54.000000000 +0000 @@ -1058,8 +1058,8 @@ S: Maintained JFS FILESYSTEM P: Dave Kleikamp M: shaggy@austin.ibm.com -L: jfs-discussion@oss.software.ibm.com -W: http://oss.software.ibm.com/developerworks/opensource/jfs/ +L: jfs-discussion@lists.sourceforge.net +W: http://jfs.sourceforge.net/ S: Supported JOYSTICK DRIVER @@ -1532,7 +1532,7 @@ S: Maintained PPP OVER ETHERNET P: Michal Ostrowski -M: mostrows@styx.uwaterloo.ca +M: mostrows@speakeasy.net S: Maintained PRISM54 WIRELESS DRIVER diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/Makefile linux-2.4.30-pre2/Makefile --- linux-2.4.29/Makefile 2005-01-19 14:10:14.000000000 +0000 +++ linux-2.4.30-pre2/Makefile 2005-02-23 07:46:02.000000000 +0000 @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 4 -SUBLEVEL = 29 -EXTRAVERSION = +SUBLEVEL = 30 +EXTRAVERSION = -pre2 KERNELRELEASE=$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/i386/kernel/pci-irq.c linux-2.4.30-pre2/arch/i386/kernel/pci-irq.c --- linux-2.4.29/arch/i386/kernel/pci-irq.c 2005-01-19 14:09:25.000000000 +0000 +++ linux-2.4.30-pre2/arch/i386/kernel/pci-irq.c 2005-02-23 07:46:44.000000000 +0000 @@ -1120,13 +1120,15 @@ void pcibios_penalize_isa_irq(int irq) void pcibios_enable_irq(struct pci_dev *dev) { u8 pin; - extern int interrupt_line_quirk; + extern int via_interrupt_line_quirk; struct pci_dev *temp_dev; pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin); if (pin && !pcibios_lookup_irq(dev, 1) && !dev->irq) { char *msg; + pin--; /* interrupt pins are numbered starting from 1 */ + /* With IDE legacy devices the IRQ lookup failure is not a problem.. */ if (dev->class >> 8 == PCI_CLASS_STORAGE_IDE && !(dev->class & 0x5)) return; @@ -1134,46 +1136,43 @@ void pcibios_enable_irq(struct pci_dev * if (io_apic_assign_pci_irqs) { int irq; - if (pin) { - pin--; /* interrupt pins are numbered starting from 1 */ - irq = IO_APIC_get_PCI_irq_vector(dev->bus->number, PCI_SLOT(dev->devfn), pin); - /* - * Busses behind bridges are typically not listed in the MP-table. - * In this case we have to look up the IRQ based on the parent bus, - * parent slot, and pin number. The SMP code detects such bridged - * busses itself so we should get into this branch reliably. - */ - temp_dev = dev; - while (irq < 0 && dev->bus->parent) { /* go back to the bridge */ - struct pci_dev * bridge = dev->bus->self; + irq = IO_APIC_get_PCI_irq_vector(dev->bus->number, PCI_SLOT(dev->devfn), pin); + /* + * Busses behind bridges are typically not listed in the MP-table. + * In this case we have to look up the IRQ based on the parent bus, + * parent slot, and pin number. The SMP code detects such bridged + * busses itself so we should get into this branch reliably. + */ + temp_dev = dev; + while (irq < 0 && dev->bus->parent) { /* go back to the bridge */ + struct pci_dev * bridge = dev->bus->self; - pin = (pin + PCI_SLOT(dev->devfn)) % 4; - irq = IO_APIC_get_PCI_irq_vector(bridge->bus->number, - PCI_SLOT(bridge->devfn), pin); - if (irq >= 0) - printk(KERN_WARNING "PCI: using PPB(B%d,I%d,P%d) to get irq %d\n", - bridge->bus->number, PCI_SLOT(bridge->devfn), pin, irq); - dev = bridge; - } - dev = temp_dev; - if (irq >= 0) { - printk(KERN_INFO "PCI->APIC IRQ transform: (B%d,I%d,P%d) -> %d\n", - dev->bus->number, PCI_SLOT(dev->devfn), pin, irq); - dev->irq = irq; - return; - } else - msg = " Probably buggy MP table."; + pin = (pin + PCI_SLOT(dev->devfn)) % 4; + irq = IO_APIC_get_PCI_irq_vector(bridge->bus->number, + PCI_SLOT(bridge->devfn), pin); + if (irq >= 0) + printk(KERN_WARNING "PCI: using PPB(B%d,I%d,P%d) to get irq %d\n", + bridge->bus->number, PCI_SLOT(bridge->devfn), pin, irq); + dev = bridge; } + dev = temp_dev; + if (irq >= 0) { + printk(KERN_INFO "PCI->APIC IRQ transform: (B%d,I%d,P%d) -> %d\n", + dev->bus->number, PCI_SLOT(dev->devfn), pin, irq); + dev->irq = irq; + return; + } else + msg = " Probably buggy MP table."; } else if (pci_probe & PCI_BIOS_IRQ_SCAN) msg = ""; else msg = " Please try using pci=biosirq."; printk(KERN_WARNING "PCI: No IRQ known for interrupt pin %c of device %s.%s\n", - 'A' + pin - 1, dev->slot_name, msg); + 'A' + pin, dev->slot_name, msg); } /* VIA bridges use interrupt line for apic/pci steering across the V-Link */ - else if (interrupt_line_quirk) + else if (via_interrupt_line_quirk) pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq & 15); } diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/i386/kernel/setup.c linux-2.4.30-pre2/arch/i386/kernel/setup.c --- linux-2.4.29/arch/i386/kernel/setup.c 2004-08-07 23:26:04.000000000 +0000 +++ linux-2.4.30-pre2/arch/i386/kernel/setup.c 2005-02-23 07:45:35.000000000 +0000 @@ -354,7 +354,8 @@ static char command_line[COMMAND_LINE_SI struct resource standard_io_resources[] = { { "dma1", 0x00, 0x1f, IORESOURCE_BUSY }, { "pic1", 0x20, 0x3f, IORESOURCE_BUSY }, - { "timer", 0x40, 0x5f, IORESOURCE_BUSY }, + { "timer0", 0x40, 0x43, IORESOURCE_BUSY }, + { "timer1", 0x50, 0x53, IORESOURCE_BUSY }, { "keyboard", 0x60, 0x6f, IORESOURCE_BUSY }, { "dma page reg", 0x80, 0x8f, IORESOURCE_BUSY }, { "pic2", 0xa0, 0xbf, IORESOURCE_BUSY }, diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/i386/lib/usercopy.c linux-2.4.30-pre2/arch/i386/lib/usercopy.c --- linux-2.4.29/arch/i386/lib/usercopy.c 2003-06-13 14:51:29.000000000 +0000 +++ linux-2.4.30-pre2/arch/i386/lib/usercopy.c 2005-02-23 07:44:57.000000000 +0000 @@ -14,6 +14,7 @@ unsigned long __generic_copy_to_user(void *to, const void *from, unsigned long n) { + BUG_ON((long) n < 0); if (access_ok(VERIFY_WRITE, to, n)) { if(n<512) @@ -27,6 +28,7 @@ __generic_copy_to_user(void *to, const v unsigned long __generic_copy_from_user(void *to, const void *from, unsigned long n) { + BUG_ON((long) n < 0); if (access_ok(VERIFY_READ, from, n)) { if(n<512) @@ -44,6 +46,7 @@ __generic_copy_from_user(void *to, const unsigned long __generic_copy_to_user(void *to, const void *from, unsigned long n) { + BUG_ON((long) n < 0); prefetch(from); if (access_ok(VERIFY_WRITE, to, n)) __copy_user(to,from,n); @@ -53,6 +56,7 @@ __generic_copy_to_user(void *to, const v unsigned long __generic_copy_from_user(void *to, const void *from, unsigned long n) { + BUG_ON((long) n < 0); prefetchw(to); if (access_ok(VERIFY_READ, from, n)) __copy_user_zeroing(to,from,n); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/ia64/ia32/sys_ia32.c linux-2.4.30-pre2/arch/ia64/ia32/sys_ia32.c --- linux-2.4.29/arch/ia64/ia32/sys_ia32.c 2005-01-19 14:09:26.000000000 +0000 +++ linux-2.4.30-pre2/arch/ia64/ia32/sys_ia32.c 2005-02-23 07:45:55.000000000 +0000 @@ -1649,7 +1649,8 @@ scm_detach_fds32 (struct msghdr *kmsg, s * IPV6_AUTHHDR ipv6 auth exthdr 32-bit clean */ static void -cmsg32_recvmsg_fixup (struct msghdr *kmsg, unsigned long orig_cmsg_uptr) +cmsg32_recvmsg_fixup (struct msghdr *kmsg, unsigned long orig_cmsg_uptr, + __kernel_size_t orig_cmsg_len) { unsigned char *workbuf, *wp; unsigned long bufsz, space_avail; @@ -1683,6 +1684,9 @@ cmsg32_recvmsg_fixup (struct msghdr *kms goto fail2; clen64 = kcmsg32->cmsg_len; + if ((clen64 < CMSG_ALIGN(sizeof(*ucmsg))) || + (clen64 > (orig_cmsg_len + wp - workbuf))) + break; copy_from_user(CMSG32_DATA(kcmsg32), CMSG_DATA(ucmsg), clen64 - CMSG_ALIGN(sizeof(*ucmsg))); clen32 = ((clen64 - CMSG_ALIGN(sizeof(*ucmsg))) + @@ -1812,6 +1816,7 @@ sys32_recvmsg (int fd, struct msghdr32 * struct iovec *iov=iovstack; struct msghdr msg_sys; unsigned long cmsg_ptr; + __kernel_size_t cmsg_len; int err, iov_size, total_len, len; struct scm_cookie scm; @@ -1856,6 +1861,7 @@ sys32_recvmsg (int fd, struct msghdr32 * total_len=err; cmsg_ptr = (unsigned long)msg_sys.msg_control; + cmsg_len = msg_sys.msg_controllen; msg_sys.msg_flags = 0; if (sock->file->f_flags & O_NONBLOCK) @@ -1882,7 +1888,8 @@ sys32_recvmsg (int fd, struct msghdr32 * * fix it up before we tack on more stuff. */ if ((unsigned long) msg_sys.msg_control != cmsg_ptr) - cmsg32_recvmsg_fixup(&msg_sys, cmsg_ptr); + cmsg32_recvmsg_fixup(&msg_sys, cmsg_ptr, + cmsg_len); /* Wheee... */ if (sock->passcred) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/mips64/kernel/linux32.c linux-2.4.30-pre2/arch/mips64/kernel/linux32.c --- linux-2.4.29/arch/mips64/kernel/linux32.c 2005-01-19 14:09:32.000000000 +0000 +++ linux-2.4.30-pre2/arch/mips64/kernel/linux32.c 2005-02-23 07:45:56.000000000 +0000 @@ -1088,11 +1088,9 @@ do_readv_writev32(int type, struct file i--; } - inode = file->f_dentry->d_inode; /* VERIFY_WRITE actually means a read, as we write to user space */ - retval = locks_verify_area((type == VERIFY_WRITE - ? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE), - inode, file, file->f_pos, tot_len); + retval = rw_verify_area((type == VERIFY_WRITE ? READ : WRITE), + file, &file->f_pos, tot_len); if (retval) { if (iov != iovstack) kfree(iov); @@ -2792,7 +2790,8 @@ static void scm_detach_fds32(struct msgh * IPV6_RTHDR ipv6 routing exthdr 32-bit clean * IPV6_AUTHHDR ipv6 auth exthdr 32-bit clean */ -static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, unsigned long orig_cmsg_uptr) +static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, + unsigned long orig_cmsg_uptr, __kernel_size_t orig_cmsg_len) { unsigned char *workbuf, *wp; unsigned long bufsz, space_avail; @@ -2823,6 +2822,9 @@ static void cmsg32_recvmsg_fixup(struct __get_user(kcmsg32->cmsg_type, &ucmsg->cmsg_type); clen64 = kcmsg32->cmsg_len; + if ((clen64 < CMSG_ALIGN(sizeof(*ucmsg))) || + (clen64 > (orig_cmsg_len + wp - workbuf))) + break; copy_from_user(CMSG32_DATA(kcmsg32), CMSG_DATA(ucmsg), clen64 - CMSG_ALIGN(sizeof(*ucmsg))); clen32 = ((clen64 - CMSG_ALIGN(sizeof(*ucmsg))) + @@ -2908,6 +2910,7 @@ asmlinkage int sys32_recvmsg(int fd, str struct sockaddr *uaddr; int *uaddr_len; unsigned long cmsg_ptr; + __kernel_size_t cmsg_len; int err, total_len, len = 0; if(msghdr_from_user32_to_kern(&kern_msg, user_msg)) @@ -2923,6 +2926,7 @@ asmlinkage int sys32_recvmsg(int fd, str total_len = err; cmsg_ptr = (unsigned long) kern_msg.msg_control; + cmsg_len = kern_msg.msg_controllen; kern_msg.msg_flags = 0; sock = sockfd_lookup(fd, &err); @@ -2948,7 +2952,8 @@ asmlinkage int sys32_recvmsg(int fd, str * to fix it up before we tack on more stuff. */ if((unsigned long) kern_msg.msg_control != cmsg_ptr) - cmsg32_recvmsg_fixup(&kern_msg, cmsg_ptr); + cmsg32_recvmsg_fixup(&kern_msg, + cmsg_ptr, cmsg_len); /* Wheee... */ if(sock->passcred) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/parisc/kernel/sys_parisc32.c linux-2.4.30-pre2/arch/parisc/kernel/sys_parisc32.c --- linux-2.4.29/arch/parisc/kernel/sys_parisc32.c 2005-01-19 14:09:35.000000000 +0000 +++ linux-2.4.30-pre2/arch/parisc/kernel/sys_parisc32.c 2005-02-23 07:45:10.000000000 +0000 @@ -1671,11 +1671,9 @@ do_readv_writev32(int type, struct file i--; } - inode = file->f_dentry->d_inode; /* VERIFY_WRITE actually means a read, as we write to user space */ - retval = locks_verify_area((type == VERIFY_WRITE - ? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE), - inode, file, file->f_pos, tot_len); + retval = rw_verify_area((type == VERIFY_WRITE ? READ : WRITE), + file, &file->f_pos, tot_len); if (retval) { if (iov != iovstack) kfree(iov); @@ -2108,7 +2106,8 @@ static void scm_detach_fds32(struct msgh * IPV6_RTHDR ipv6 routing exthdr 32-bit clean * IPV6_AUTHHDR ipv6 auth exthdr 32-bit clean */ -static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, unsigned long orig_cmsg_uptr) +static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, + unsigned long orig_cmsg_uptr, __kernel_size_t orig_cmsg_len) { unsigned char *workbuf, *wp; unsigned long bufsz, space_avail; @@ -2139,6 +2138,9 @@ static void cmsg32_recvmsg_fixup(struct __get_user(kcmsg32->cmsg_type, &ucmsg->cmsg_type); clen64 = kcmsg32->cmsg_len; + if ((clen64 < CMSG_ALIGN(sizeof(*ucmsg))) || + (clen64 > (orig_cmsg_len + wp - workbuf))) + break; copy_from_user(CMSG32_DATA(kcmsg32), CMSG_DATA(ucmsg), clen64 - CMSG_ALIGN(sizeof(*ucmsg))); clen32 = ((clen64 - CMSG_ALIGN(sizeof(*ucmsg))) + @@ -2224,6 +2226,7 @@ asmlinkage int sys32_recvmsg(int fd, str struct sockaddr *uaddr; int *uaddr_len; unsigned long cmsg_ptr; + __kernel_size_t cmsg_len; int err, total_len, len = 0; if(msghdr_from_user32_to_kern(&kern_msg, user_msg)) @@ -2239,6 +2242,7 @@ asmlinkage int sys32_recvmsg(int fd, str total_len = err; cmsg_ptr = (unsigned long) kern_msg.msg_control; + cmsg_len = kern_msg.msg_controllen; kern_msg.msg_flags = 0; sock = sockfd_lookup(fd, &err); @@ -2264,7 +2268,8 @@ asmlinkage int sys32_recvmsg(int fd, str * to fix it up before we tack on more stuff. */ if((unsigned long) kern_msg.msg_control != cmsg_ptr) - cmsg32_recvmsg_fixup(&kern_msg, cmsg_ptr); + cmsg32_recvmsg_fixup(&kern_msg, + cmsg_ptr, cmsg_len); /* Wheee... */ if(sock->passcred) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/ppc/kernel/cputable.c linux-2.4.30-pre2/arch/ppc/kernel/cputable.c --- linux-2.4.29/arch/ppc/kernel/cputable.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/arch/ppc/kernel/cputable.c 2005-02-23 07:45:45.000000000 +0000 @@ -480,8 +480,8 @@ struct cpu_spec cpu_specs[] = { 32, 32, 0, /*__setup_cpu_440 */ }, - { /* 440GX Rev. B1 (2.1) */ - 0xf0000fff, 0x50000852, "440GX Rev. B1 (2.1)", + { /* 440GX Rev. C */ + 0xf0000fff, 0x50000892, "440GX Rev. C", CPU_FTR_SPLIT_ID_CACHE | CPU_FTR_USE_TB, PPC_FEATURE_32 | PPC_FEATURE_HAS_MMU, 32, 32, diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/ppc/kernel/head_8xx.S linux-2.4.30-pre2/arch/ppc/kernel/head_8xx.S --- linux-2.4.29/arch/ppc/kernel/head_8xx.S 2004-02-18 13:36:30.000000000 +0000 +++ linux-2.4.30-pre2/arch/ppc/kernel/head_8xx.S 2005-02-23 07:45:32.000000000 +0000 @@ -338,13 +338,13 @@ InstructionTLBMiss: 3: lwz r21, 0(r20) /* Get the level 1 entry */ rlwinm. r20, r21,0,0,19 /* Extract page descriptor page address */ - beq 2f /* If zero, don't try to find a pte */ /* We have a pte table, so load the MI_TWC with the attributes * for this "segment." */ tophys(r21,r21) ori r21,r21,1 /* Set valid bit */ + beq- 2f /* If zero, don't try to find a pte */ #ifdef CONFIG_8xx_CPU6 li r3, 0x2b80 stw r3, 12(r0) @@ -369,7 +369,7 @@ InstructionTLBMiss: * set. All other Linux PTE bits control the behavior * of the MMU. */ - li r21, 0x00f0 +2: li r21, 0x00f0 rlwimi r20, r21, 0, 24, 28 /* Set 24-27, clear 28 */ #ifdef CONFIG_8xx_CPU6 @@ -388,15 +388,6 @@ InstructionTLBMiss: #endif rfi -2: mfspr r20, M_TW /* Restore registers */ - lwz r21, 0(r0) - mtcr r21 - lwz r21, 4(r0) -#ifdef CONFIG_8xx_CPU6 - lwz r3, 8(r0) -#endif - b InstructionAccess - . = 0x1200 DataStoreTLBMiss: #ifdef CONFIG_8xx_CPU6 @@ -422,12 +413,12 @@ DataStoreTLBMiss: 3: lwz r21, 0(r20) /* Get the level 1 entry */ rlwinm. r20, r21,0,0,19 /* Extract page descriptor page address */ - beq 2f /* If zero, don't try to find a pte */ /* We have a pte table, so load fetch the pte from the table. */ tophys(r21, r21) ori r21, r21, 1 /* Set valid bit in physical L2 page */ + beq- 2f /* If zero, don't try to find a pte */ #ifdef CONFIG_8xx_CPU6 li r3, 0x3b80 stw r3, 12(r0) @@ -461,7 +452,7 @@ DataStoreTLBMiss: * set. All other Linux PTE bits control the behavior * of the MMU. */ - li r21, 0x00f0 +2: li r21, 0x00f0 rlwimi r20, r21, 0, 24, 28 /* Set 24-27, clear 28 */ #ifdef CONFIG_8xx_CPU6 @@ -480,24 +471,6 @@ DataStoreTLBMiss: #endif rfi -2: - /* Copy 20 msb from MD_EPN to DAR since the dcxx instructions fail - * to update DAR when they cause a DTLB miss. - */ - mfspr r21, MD_EPN - mfspr r20, DAR - rlwimi r20, r21, 0, 0, 19 - mtspr DAR, r20 - - mfspr r20, M_TW /* Restore registers */ - lwz r21, 0(r0) - mtcr r21 - lwz r21, 4(r0) -#ifdef CONFIG_8xx_CPU6 - lwz r3, 8(r0) -#endif - b DataAccess - /* This is an instruction TLB error on the MPC8xx. This could be due * to many reasons, such as executing guarded memory or illegal instruction * addresses. There is nothing to do but handle a big time error fault. diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/ppc64/kernel/sys_ppc32.c linux-2.4.30-pre2/arch/ppc64/kernel/sys_ppc32.c --- linux-2.4.29/arch/ppc64/kernel/sys_ppc32.c 2005-01-19 14:09:37.000000000 +0000 +++ linux-2.4.30-pre2/arch/ppc64/kernel/sys_ppc32.c 2005-02-23 07:45:00.000000000 +0000 @@ -183,11 +183,9 @@ static long do_readv_writev32(int type, i--; } - inode = file->f_dentry->d_inode; /* VERIFY_WRITE actually means a read, as we write to user space */ - retval = locks_verify_area((type == VERIFY_WRITE - ? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE), - inode, file, file->f_pos, tot_len); + retval = rw_verify_area((type == VERIFY_WRITE ? READ : WRITE), + file, &file->f_pos, tot_len); if (retval) { if (iov != iovstack) kfree(iov); @@ -3666,7 +3664,8 @@ static void scm_detach_fds32(struct msgh * IPV6_RTHDR ipv6 routing exthdr 32-bit clean * IPV6_AUTHHDR ipv6 auth exthdr 32-bit clean */ -static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, unsigned long orig_cmsg_uptr) +static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, + unsigned long orig_cmsg_uptr, __kernel_size_t orig_cmsg_len) { unsigned char *workbuf, *wp; unsigned long bufsz, space_avail; @@ -3697,6 +3696,9 @@ static void cmsg32_recvmsg_fixup(struct __get_user(kcmsg32->cmsg_type, &ucmsg->cmsg_type); clen64 = kcmsg32->cmsg_len; + if ((clen64 < CMSG_ALIGN(sizeof(*ucmsg))) || + (clen64 > (orig_cmsg_len + wp - workbuf))) + break; copy_from_user(CMSG32_DATA(kcmsg32), CMSG_DATA(ucmsg), clen64 - CMSG_ALIGN(sizeof(*ucmsg))); clen32 = ((clen64 - CMSG_ALIGN(sizeof(*ucmsg))) + @@ -3753,6 +3755,7 @@ asmlinkage long sys32_recvmsg(int fd, st struct sockaddr *uaddr; int *uaddr_len; unsigned long cmsg_ptr; + __kernel_size_t cmsg_len; int err, total_len, len = 0; PPCDBG(PPCDBG_SYS32, "sys32_recvmsg - entered - fd=%x, user_msg@=%p, user_flags=%x \n", fd, user_msg, user_flags); @@ -3770,6 +3773,7 @@ asmlinkage long sys32_recvmsg(int fd, st total_len = err; cmsg_ptr = (unsigned long) kern_msg.msg_control; + cmsg_len = kern_msg.msg_controllen; kern_msg.msg_flags = 0; sock = sockfd_lookup(fd, &err); @@ -3795,7 +3799,8 @@ asmlinkage long sys32_recvmsg(int fd, st * to fix it up before we tack on more stuff. */ if((unsigned long) kern_msg.msg_control != cmsg_ptr) - cmsg32_recvmsg_fixup(&kern_msg, cmsg_ptr); + cmsg32_recvmsg_fixup(&kern_msg, + cmsg_ptr, cmsg_len); /* Wheee... */ if(sock->passcred) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/s390x/kernel/linux32.c linux-2.4.30-pre2/arch/s390x/kernel/linux32.c --- linux-2.4.29/arch/s390x/kernel/linux32.c 2005-01-19 14:09:38.000000000 +0000 +++ linux-2.4.30-pre2/arch/s390x/kernel/linux32.c 2005-02-23 07:46:10.000000000 +0000 @@ -1108,7 +1108,6 @@ static long do_readv_writev32(int type, unsigned long tot_len; struct iovec iovstack[UIO_FASTIOV]; struct iovec *iov=iovstack, *ivp; - struct inode *inode; long retval, i; io_fn_t fn; iov_fn_t fnv; @@ -1145,11 +1144,9 @@ static long do_readv_writev32(int type, i--; } - inode = file->f_dentry->d_inode; /* VERIFY_WRITE actually means a read, as we write to user space */ - retval = locks_verify_area((type == VERIFY_WRITE - ? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE), - inode, file, file->f_pos, tot_len); + retval = rw_verify_area((type == VERIFY_WRITE ? READ : WRITE), + file, &file->f_pos, tot_len); if (retval) goto out; @@ -2600,7 +2597,8 @@ static void scm_detach_fds32(struct msgh * IPV6_RTHDR ipv6 routing exthdr 32-bit clean * IPV6_AUTHHDR ipv6 auth exthdr 32-bit clean */ -static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, unsigned long orig_cmsg_uptr) +static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, + unsigned long orig_cmsg_uptr, __kernel_size_t orig_cmsg_len) { unsigned char *workbuf, *wp; unsigned long bufsz, space_avail; @@ -2631,6 +2629,9 @@ static void cmsg32_recvmsg_fixup(struct __get_user(kcmsg32->cmsg_type, &ucmsg->cmsg_type); clen64 = kcmsg32->cmsg_len; + if ((clen64 < CMSG_ALIGN(sizeof(*ucmsg))) || + (clen64 > (orig_cmsg_len + wp - workbuf))) + break; copy_from_user(CMSG32_DATA(kcmsg32), CMSG_DATA(ucmsg), clen64 - CMSG_ALIGN(sizeof(*ucmsg))); clen32 = ((clen64 - CMSG_ALIGN(sizeof(*ucmsg))) + @@ -2890,7 +2891,8 @@ out: static __inline__ void scm_recv32(struct socket *sock, struct msghdr *msg, - struct scm_cookie *scm, int flags, unsigned long cmsg_ptr) + struct scm_cookie *scm, int flags, unsigned long cmsg_ptr, + __kernel_size_t cmsg_len) { if(!msg->msg_control) { @@ -2905,7 +2907,7 @@ scm_recv32(struct socket *sock, struct m * to fix it up before we tack on more stuff. */ if((unsigned long) msg->msg_control != cmsg_ptr) - cmsg32_recvmsg_fixup(msg, cmsg_ptr); + cmsg32_recvmsg_fixup(msg, cmsg_ptr, cmsg_len); /* Wheee... */ if(sock->passcred) put_cmsg32(msg, @@ -2919,14 +2921,14 @@ scm_recv32(struct socket *sock, struct m static int sock_recvmsg32(struct socket *sock, struct msghdr *msg, int size, int flags, - unsigned long cmsg_ptr) + unsigned long cmsg_ptr, __kernel_size_t cmsg_len) { struct scm_cookie scm; memset(&scm, 0, sizeof(scm)); size = sock->ops->recvmsg(sock, msg, size, flags, &scm); if (size >= 0) - scm_recv32(sock, msg, &scm, flags, cmsg_ptr); + scm_recv32(sock, msg, &scm, flags, cmsg_ptr, cmsg_len); return size; } @@ -2943,6 +2945,7 @@ sys32_recvmsg (int fd, struct msghdr32 * struct iovec *iov=iovstack; struct msghdr msg_sys; unsigned long cmsg_ptr; + __kernel_size_t cmsg_len; int err, iov_size, total_len, len; /* kernel mode address */ @@ -2986,11 +2989,12 @@ sys32_recvmsg (int fd, struct msghdr32 * total_len=err; cmsg_ptr = (unsigned long)msg_sys.msg_control; + cmsg_len = msg_sys.msg_controllen; msg_sys.msg_flags = 0; if (sock->file->f_flags & O_NONBLOCK) flags |= MSG_DONTWAIT; - err = sock_recvmsg32(sock, &msg_sys, total_len, flags, cmsg_ptr); + err = sock_recvmsg32(sock, &msg_sys, total_len, flags, cmsg_ptr, cmsg_len); if (err < 0) goto out_freeiov; len = err; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc/kernel/muldiv.c linux-2.4.30-pre2/arch/sparc/kernel/muldiv.c --- linux-2.4.29/arch/sparc/kernel/muldiv.c 1998-01-12 23:15:43.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc/kernel/muldiv.c 2005-02-23 07:46:12.000000000 +0000 @@ -4,6 +4,9 @@ * * Copyright (C) 1996 Jakub Jelinek (jj@sunsite.mff.cuni.cz) * Copyright (C) 1996 David S. Miller (davem@caip.rutgers.edu) + * + * 2004-12-25 Krzysztof Helt (krzysztof.h1@wp.pl) + * - fixed registers constrains in inline assembly declarations */ #include @@ -125,7 +128,7 @@ int do_user_muldiv(struct pt_regs *regs, "mov %%o0, %0\n\t" "mov %%o1, %1\n\t" : "=r" (rs1), "=r" (rs2) - : + : "0" (rs1), "1" (rs2) : "o0", "o1", "o2", "o3", "o4", "o5", "o7", "cc"); #ifdef DEBUG_MULDIV printk ("0x%x%08x\n", rs2, rs1); @@ -145,7 +148,7 @@ int do_user_muldiv(struct pt_regs *regs, "mov %%o0, %0\n\t" "mov %%o1, %1\n\t" : "=r" (rs1), "=r" (rs2) - : + : "0" (rs1), "1" (rs2) : "o0", "o1", "o2", "o3", "o4", "o5", "o7", "cc"); #ifdef DEBUG_MULDIV printk ("0x%x%08x\n", rs2, rs1); @@ -174,7 +177,7 @@ int do_user_muldiv(struct pt_regs *regs, "mov %%o1, %0\n\t" "mov %%o0, %1\n\t" : "=r" (rs1), "=r" (rs2) - : "r" (regs->y) + : "r" (regs->y), "0" (rs1), "1" (rs2) : "o0", "o1", "o2", "o3", "o4", "o5", "o7", "g1", "g2", "g3", "cc"); #ifdef DEBUG_MULDIV @@ -203,7 +206,7 @@ int do_user_muldiv(struct pt_regs *regs, "mov %%o1, %0\n\t" "mov %%o0, %1\n\t" : "=r" (rs1), "=r" (rs2) - : "r" (regs->y) + : "r" (regs->y), "0" (rs1), "1" (rs2) : "o0", "o1", "o2", "o3", "o4", "o5", "o7", "g1", "g2", "g3", "cc"); #ifdef DEBUG_MULDIV diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc/kernel/process.c linux-2.4.30-pre2/arch/sparc/kernel/process.c --- linux-2.4.29/arch/sparc/kernel/process.c 2004-08-07 23:26:04.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc/kernel/process.c 2005-02-23 07:44:59.000000000 +0000 @@ -512,6 +512,11 @@ int copy_thread(int nr, unsigned long cl } } +#ifdef CONFIG_SMP + /* FPU must be disabled on SMP. */ + childregs->psr &= ~PSR_EF; +#endif + /* Set the return value for the child. */ childregs->u_regs[UREG_I0] = current->pid; childregs->u_regs[UREG_I1] = 1; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc64/kernel/ioctl32.c linux-2.4.30-pre2/arch/sparc64/kernel/ioctl32.c --- linux-2.4.29/arch/sparc64/kernel/ioctl32.c 2005-01-19 14:09:39.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc64/kernel/ioctl32.c 2005-02-23 07:46:28.000000000 +0000 @@ -562,6 +562,8 @@ static __inline__ void *alloc_user_space if (!(current->thread.flags & SPARC_FLAG_32BIT)) usp += STACK_BIAS; + else + usp &= 0xffffffffUL; return (void *) (usp - len); } @@ -696,6 +698,7 @@ static int dev_ifsioc(unsigned int fd, u set_fs (old_fs); if (!err) { switch (cmd) { + case TUNSETIFF: case SIOCGIFFLAGS: case SIOCGIFMETRIC: case SIOCGIFMTU: diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc64/kernel/smp.c linux-2.4.30-pre2/arch/sparc64/kernel/smp.c --- linux-2.4.29/arch/sparc64/kernel/smp.c 2005-01-19 14:09:39.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc64/kernel/smp.c 2005-02-23 07:44:57.000000000 +0000 @@ -1034,7 +1034,7 @@ static unsigned long penguins_are_doing_ void smp_capture(void) { if (smp_processors_ready) { - int result = __atomic_add(1, &smp_capture_depth); + int result = atomic_add_ret(1, &smp_capture_depth); membar("#StoreStore | #LoadStore"); if (result == 1) { diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc64/kernel/sparc64_ksyms.c linux-2.4.30-pre2/arch/sparc64/kernel/sparc64_ksyms.c --- linux-2.4.29/arch/sparc64/kernel/sparc64_ksyms.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc64/kernel/sparc64_ksyms.c 2005-02-23 07:46:21.000000000 +0000 @@ -173,18 +173,21 @@ EXPORT_SYMBOL(__down_interruptible); EXPORT_SYMBOL(__up); /* Atomic counter implementation. */ -EXPORT_SYMBOL(__atomic_add); -EXPORT_SYMBOL(__atomic_sub); +EXPORT_SYMBOL(atomic_add); +EXPORT_SYMBOL(atomic_add_ret); +EXPORT_SYMBOL(atomic_sub); +EXPORT_SYMBOL(atomic_sub_ret); #ifdef CONFIG_SMP EXPORT_SYMBOL(atomic_dec_and_lock); #endif /* Atomic bit operations. */ -EXPORT_SYMBOL(___test_and_set_bit); -EXPORT_SYMBOL(___test_and_clear_bit); -EXPORT_SYMBOL(___test_and_change_bit); -EXPORT_SYMBOL(___test_and_set_le_bit); -EXPORT_SYMBOL(___test_and_clear_le_bit); +EXPORT_SYMBOL(test_and_set_bit); +EXPORT_SYMBOL(test_and_clear_bit); +EXPORT_SYMBOL(test_and_change_bit); +EXPORT_SYMBOL(set_bit); +EXPORT_SYMBOL(clear_bit); +EXPORT_SYMBOL(change_bit); EXPORT_SYMBOL(ivector_table); EXPORT_SYMBOL(enable_irq); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc64/kernel/sys_sparc32.c linux-2.4.30-pre2/arch/sparc64/kernel/sys_sparc32.c --- linux-2.4.29/arch/sparc64/kernel/sys_sparc32.c 2005-01-19 14:09:39.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc64/kernel/sys_sparc32.c 2005-02-23 07:45:57.000000000 +0000 @@ -770,6 +770,8 @@ static __inline__ void *alloc_user_space if (!(current->thread.flags & SPARC_FLAG_32BIT)) usp += STACK_BIAS; + else + usp &= 0xffffffffUL; return (void *) (usp - len); } @@ -1093,7 +1095,6 @@ static long do_readv_writev32(int type, __kernel_ssize_t32 tot_len; struct iovec iovstack[UIO_FASTIOV]; struct iovec *iov=iovstack, *ivp; - struct inode *inode; long retval, i; io_fn_t fn; iov_fn_t fnv; @@ -1140,11 +1141,9 @@ static long do_readv_writev32(int type, i--; } - inode = file->f_dentry->d_inode; /* VERIFY_WRITE actually means a read, as we write to user space */ - retval = locks_verify_area((type == VERIFY_WRITE - ? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE), - inode, file, file->f_pos, tot_len); + retval = rw_verify_area((type == VERIFY_WRITE ? READ : WRITE), + file, &file->f_pos, tot_len); if (retval) goto out; @@ -2648,7 +2647,8 @@ static void scm_detach_fds32(struct msgh * IPV6_RTHDR ipv6 routing exthdr 32-bit clean * IPV6_AUTHHDR ipv6 auth exthdr 32-bit clean */ -static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, unsigned long orig_cmsg_uptr) +static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, + unsigned long orig_cmsg_uptr, __kernel_size_t orig_cmsg_len) { unsigned char *workbuf, *wp; unsigned long bufsz, space_avail; @@ -2679,6 +2679,9 @@ static void cmsg32_recvmsg_fixup(struct __get_user(kcmsg32->cmsg_type, &ucmsg->cmsg_type); clen64 = kcmsg32->cmsg_len; + if ((clen64 < CMSG_ALIGN(sizeof(*ucmsg))) || + (clen64 > (orig_cmsg_len + wp - workbuf))) + break; if (kcmsg32->cmsg_level == SOL_SOCKET && kcmsg32->cmsg_type == SO_TIMESTAMP) { struct timeval tv; @@ -2782,6 +2785,7 @@ asmlinkage int sys32_recvmsg(int fd, str struct sockaddr *uaddr; int *uaddr_len; unsigned long cmsg_ptr; + __kernel_size_t cmsg_len; int err, total_len, len = 0; if(msghdr_from_user32_to_kern(&kern_msg, user_msg)) @@ -2797,6 +2801,7 @@ asmlinkage int sys32_recvmsg(int fd, str total_len = err; cmsg_ptr = (unsigned long) kern_msg.msg_control; + cmsg_len = kern_msg.msg_controllen; kern_msg.msg_flags = 0; sock = sockfd_lookup(fd, &err); @@ -2822,7 +2827,8 @@ asmlinkage int sys32_recvmsg(int fd, str * to fix it up before we tack on more stuff. */ if((unsigned long) kern_msg.msg_control != cmsg_ptr) - cmsg32_recvmsg_fixup(&kern_msg, cmsg_ptr); + cmsg32_recvmsg_fixup(&kern_msg, + cmsg_ptr, cmsg_len); /* Wheee... */ if(sock->passcred) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc64/lib/atomic.S linux-2.4.30-pre2/arch/sparc64/lib/atomic.S --- linux-2.4.29/arch/sparc64/lib/atomic.S 2001-12-21 17:41:53.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc64/lib/atomic.S 2005-02-23 07:46:28.000000000 +0000 @@ -4,33 +4,83 @@ * Copyright (C) 1999 David S. Miller (davem@redhat.com) */ +#include #include + /* On SMP we need to use memory barriers to ensure + * correct memory operation ordering, nop these out + * for uniprocessor. + */ +#ifdef CONFIG_SMP +#define ATOMIC_PRE_BARRIER membar #StoreLoad | #LoadLoad +#define ATOMIC_POST_BARRIER membar #StoreLoad | #StoreStore +#else +#define ATOMIC_PRE_BARRIER nop +#define ATOMIC_POST_BARRIER nop +#endif + .text - .align 64 .globl atomic_impl_begin, atomic_impl_end - - .globl __atomic_add atomic_impl_begin: -__atomic_add: /* %o0 = increment, %o1 = atomic_ptr */ - lduw [%o1], %g5 + /* Two versions of the atomic routines, one that + * does not return a value and does not perform + * memory barriers, and a second which returns + * a value and does the barriers. + */ + .globl atomic_add + .type atomic_add,#function +atomic_add: /* %o0 = increment, %o1 = atomic_ptr */ +1: lduw [%o1], %g5 + add %g5, %o0, %g7 + cas [%o1], %g5, %g7 + cmp %g5, %g7 + bne,pn %icc, 1b + nop + retl + nop + .size atomic_add, .-atomic_add + + .globl atomic_sub + .type atomic_sub,#function +atomic_sub: /* %o0 = decrement, %o1 = atomic_ptr */ +1: lduw [%o1], %g5 + sub %g5, %o0, %g7 + cas [%o1], %g5, %g7 + cmp %g5, %g7 + bne,pn %icc, 1b + nop + retl + nop + .size atomic_sub, .-atomic_sub + + .globl atomic_add_ret + .type atomic_add_ret,#function +atomic_add_ret: /* %o0 = increment, %o1 = atomic_ptr */ + ATOMIC_PRE_BARRIER +1: lduw [%o1], %g5 add %g5, %o0, %g7 cas [%o1], %g5, %g7 cmp %g5, %g7 - bne,pn %icc, __atomic_add - membar #StoreLoad | #StoreStore + bne,pn %icc, 1b + add %g7, %o0, %g7 + ATOMIC_POST_BARRIER retl - add %g7, %o0, %o0 + sra %g7, 0, %o0 + .size atomic_add_ret, .-atomic_add_ret - .globl __atomic_sub -__atomic_sub: /* %o0 = increment, %o1 = atomic_ptr */ - lduw [%o1], %g5 + .globl atomic_sub_ret + .type atomic_sub_ret,#function +atomic_sub_ret: /* %o0 = decrement, %o1 = atomic_ptr */ + ATOMIC_PRE_BARRIER +1: lduw [%o1], %g5 sub %g5, %o0, %g7 cas [%o1], %g5, %g7 cmp %g5, %g7 - bne,pn %icc, __atomic_sub - membar #StoreLoad | #StoreStore + bne,pn %icc, 1b + sub %g7, %o0, %g7 + ATOMIC_POST_BARRIER retl - sub %g7, %o0, %o0 + sra %g7, 0, %o0 + .size atomic_sub_ret, .-atomic_sub_ret atomic_impl_end: diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc64/lib/bitops.S linux-2.4.30-pre2/arch/sparc64/lib/bitops.S --- linux-2.4.29/arch/sparc64/lib/bitops.S 2001-12-21 17:41:53.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc64/lib/bitops.S 2005-02-23 07:46:26.000000000 +0000 @@ -4,107 +4,149 @@ * Copyright (C) 2000 David S. Miller (davem@redhat.com) */ +#include #include + /* On SMP we need to use memory barriers to ensure + * correct memory operation ordering, nop these out + * for uniprocessor. + */ +#ifdef CONFIG_SMP +#define BITOP_PRE_BARRIER membar #StoreLoad | #LoadLoad +#define BITOP_POST_BARRIER membar #StoreLoad | #StoreStore +#else +#define BITOP_PRE_BARRIER nop +#define BITOP_POST_BARRIER nop +#endif + .text - .align 64 + .globl __bitops_begin __bitops_begin: - .globl ___test_and_set_bit -___test_and_set_bit: /* %o0=nr, %o1=addr */ + + .globl test_and_set_bit + .type test_and_set_bit,#function +test_and_set_bit: /* %o0=nr, %o1=addr */ + BITOP_PRE_BARRIER srlx %o0, 6, %g1 mov 1, %g5 sllx %g1, 3, %g3 and %o0, 63, %g2 sllx %g5, %g2, %g5 add %o1, %g3, %o1 - ldx [%o1], %g7 -1: andcc %g7, %g5, %o0 - bne,pn %xcc, 2f - xor %g7, %g5, %g1 +1: ldx [%o1], %g7 + or %g7, %g5, %g1 casx [%o1], %g7, %g1 cmp %g7, %g1 - bne,a,pn %xcc, 1b - ldx [%o1], %g7 -2: retl - membar #StoreLoad | #StoreStore - - .globl ___test_and_clear_bit -___test_and_clear_bit: /* %o0=nr, %o1=addr */ + bne,pn %xcc, 1b + and %g7, %g5, %g2 + BITOP_POST_BARRIER + clr %o0 + retl + movrne %g2, 1, %o0 + .size test_and_set_bit, .-test_and_set_bit + + .globl test_and_clear_bit + .type test_and_clear_bit,#function +test_and_clear_bit: /* %o0=nr, %o1=addr */ + BITOP_PRE_BARRIER srlx %o0, 6, %g1 mov 1, %g5 sllx %g1, 3, %g3 and %o0, 63, %g2 sllx %g5, %g2, %g5 add %o1, %g3, %o1 - ldx [%o1], %g7 -1: andcc %g7, %g5, %o0 - be,pn %xcc, 2f - xor %g7, %g5, %g1 +1: ldx [%o1], %g7 + andn %g7, %g5, %g1 casx [%o1], %g7, %g1 cmp %g7, %g1 - bne,a,pn %xcc, 1b - ldx [%o1], %g7 -2: retl - membar #StoreLoad | #StoreStore - - .globl ___test_and_change_bit -___test_and_change_bit: /* %o0=nr, %o1=addr */ + bne,pn %xcc, 1b + and %g7, %g5, %g2 + BITOP_POST_BARRIER + clr %o0 + retl + movrne %g2, 1, %o0 + .size test_and_clear_bit, .-test_and_clear_bit + + .globl test_and_change_bit + .type test_and_change_bit,#function +test_and_change_bit: /* %o0=nr, %o1=addr */ + BITOP_PRE_BARRIER + srlx %o0, 6, %g1 + mov 1, %g5 + sllx %g1, 3, %g3 + and %o0, 63, %g2 + sllx %g5, %g2, %g5 + add %o1, %g3, %o1 +1: ldx [%o1], %g7 + xor %g7, %g5, %g1 + casx [%o1], %g7, %g1 + cmp %g7, %g1 + bne,pn %xcc, 1b + and %g7, %g5, %g2 + BITOP_POST_BARRIER + clr %o0 + retl + movrne %g2, 1, %o0 + .size test_and_change_bit, .-test_and_change_bit + + .globl set_bit + .type set_bit,#function +set_bit: /* %o0=nr, %o1=addr */ + srlx %o0, 6, %g1 + mov 1, %g5 + sllx %g1, 3, %g3 + and %o0, 63, %g2 + sllx %g5, %g2, %g5 + add %o1, %g3, %o1 +1: ldx [%o1], %g7 + or %g7, %g5, %g1 + casx [%o1], %g7, %g1 + cmp %g7, %g1 + bne,pn %xcc, 1b + nop + retl + nop + .size set_bit, .-set_bit + + .globl clear_bit + .type clear_bit,#function +clear_bit: /* %o0=nr, %o1=addr */ + srlx %o0, 6, %g1 + mov 1, %g5 + sllx %g1, 3, %g3 + and %o0, 63, %g2 + sllx %g5, %g2, %g5 + add %o1, %g3, %o1 +1: ldx [%o1], %g7 + andn %g7, %g5, %g1 + casx [%o1], %g7, %g1 + cmp %g7, %g1 + bne,pn %xcc, 1b + nop + retl + nop + .size clear_bit, .-clear_bit + + .globl change_bit + .type change_bit,#function +change_bit: /* %o0=nr, %o1=addr */ srlx %o0, 6, %g1 mov 1, %g5 sllx %g1, 3, %g3 and %o0, 63, %g2 sllx %g5, %g2, %g5 add %o1, %g3, %o1 - ldx [%o1], %g7 -1: and %g7, %g5, %o0 +1: ldx [%o1], %g7 xor %g7, %g5, %g1 casx [%o1], %g7, %g1 cmp %g7, %g1 - bne,a,pn %xcc, 1b - ldx [%o1], %g7 -2: retl - membar #StoreLoad | #StoreStore - nop - - .globl ___test_and_set_le_bit -___test_and_set_le_bit: /* %o0=nr, %o1=addr */ - srlx %o0, 5, %g1 - mov 1, %g5 - sllx %g1, 2, %g3 - and %o0, 31, %g2 - sllx %g5, %g2, %g5 - add %o1, %g3, %o1 - lduwa [%o1] ASI_PL, %g7 -1: andcc %g7, %g5, %o0 - bne,pn %icc, 2f - xor %g7, %g5, %g1 - casa [%o1] ASI_PL, %g7, %g1 - cmp %g7, %g1 - bne,a,pn %icc, 1b - lduwa [%o1] ASI_PL, %g7 -2: retl - membar #StoreLoad | #StoreStore - - .globl ___test_and_clear_le_bit -___test_and_clear_le_bit: /* %o0=nr, %o1=addr */ - srlx %o0, 5, %g1 - mov 1, %g5 - sllx %g1, 2, %g3 - and %o0, 31, %g2 - sllx %g5, %g2, %g5 - add %o1, %g3, %o1 - lduwa [%o1] ASI_PL, %g7 -1: andcc %g7, %g5, %o0 - be,pn %icc, 2f - xor %g7, %g5, %g1 - casa [%o1] ASI_PL, %g7, %g1 - cmp %g7, %g1 - bne,a,pn %icc, 1b - lduwa [%o1] ASI_PL, %g7 -2: retl - membar #StoreLoad | #StoreStore + bne,pn %xcc, 1b + nop + retl + nop + .size change_bit, .-change_bit .globl __bitops_end __bitops_end: diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc64/lib/debuglocks.c linux-2.4.30-pre2/arch/sparc64/lib/debuglocks.c --- linux-2.4.29/arch/sparc64/lib/debuglocks.c 2001-12-21 17:41:53.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc64/lib/debuglocks.c 2005-02-23 07:45:55.000000000 +0000 @@ -162,6 +162,7 @@ void _do_read_unlock (rwlock_t *rw, char runlock_again: /* Spin trying to decrement the counter using casx. */ __asm__ __volatile__( +" membar #StoreLoad | #LoadLoad\n" " ldx [%0], %%g5\n" " sub %%g5, 1, %%g7\n" " casx [%0], %%g5, %%g7\n" @@ -276,6 +277,7 @@ void _do_write_unlock(rwlock_t *rw) current->thread.smp_lock_count--; wlock_again: __asm__ __volatile__( +" membar #StoreLoad | #LoadLoad\n" " mov 1, %%g3\n" " sllx %%g3, 63, %%g3\n" " ldx [%0], %%g5\n" diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/sparc64/lib/rwlock.S linux-2.4.30-pre2/arch/sparc64/lib/rwlock.S --- linux-2.4.29/arch/sparc64/lib/rwlock.S 2000-09-09 00:55:17.000000000 +0000 +++ linux-2.4.30-pre2/arch/sparc64/lib/rwlock.S 2005-02-23 07:45:28.000000000 +0000 @@ -24,12 +24,13 @@ __read_lock: /* %o0 = lock_ptr */ 99: retl nop __read_unlock: /* %o0 = lock_ptr */ + membar #StoreLoad | #LoadLoad lduw [%o0], %g5 sub %g5, 1, %g7 cas [%o0], %g5, %g7 cmp %g5, %g7 be,pt %xcc, 99b - membar #StoreLoad | #StoreStore + nop ba,a,pt %xcc, __read_unlock __read_wait_for_writer: diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/x86_64/ia32/socket32.c linux-2.4.30-pre2/arch/x86_64/ia32/socket32.c --- linux-2.4.29/arch/x86_64/ia32/socket32.c 2005-01-19 14:09:39.000000000 +0000 +++ linux-2.4.30-pre2/arch/x86_64/ia32/socket32.c 2005-02-23 07:45:00.000000000 +0000 @@ -302,7 +302,8 @@ static void scm_detach_fds32(struct msgh * IPV6_RTHDR ipv6 routing exthdr 32-bit clean * IPV6_AUTHHDR ipv6 auth exthdr 32-bit clean */ -static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, unsigned long orig_cmsg_uptr) +static void cmsg32_recvmsg_fixup(struct msghdr *kmsg, + unsigned long orig_cmsg_uptr, __kernel_size_t orig_cmsg_len) { unsigned char *workbuf, *wp; unsigned long bufsz, space_avail; @@ -333,6 +334,9 @@ static void cmsg32_recvmsg_fixup(struct __get_user(kcmsg32->cmsg_type, &ucmsg->cmsg_type); clen64 = kcmsg32->cmsg_len; + if ((clen64 < CMSG_ALIGN(sizeof(*ucmsg))) || + (clen64 > (orig_cmsg_len + wp - workbuf))) + break; copy_from_user(CMSG32_DATA(kcmsg32), CMSG_DATA(ucmsg), clen64 - CMSG_ALIGN(sizeof(*ucmsg))); clen32 = ((clen64 - CMSG_ALIGN(sizeof(*ucmsg))) + @@ -418,6 +422,7 @@ asmlinkage long sys32_recvmsg(int fd, st struct sockaddr *uaddr; int *uaddr_len; unsigned long cmsg_ptr; + __kernel_size_t cmsg_len; int err, total_len, len = 0; if(msghdr_from_user32_to_kern(&kern_msg, user_msg)) @@ -433,6 +438,7 @@ asmlinkage long sys32_recvmsg(int fd, st total_len = err; cmsg_ptr = (unsigned long) kern_msg.msg_control; + cmsg_len = kern_msg.msg_controllen; kern_msg.msg_flags = 0; sock = sockfd_lookup(fd, &err); @@ -458,7 +464,8 @@ asmlinkage long sys32_recvmsg(int fd, st * to fix it up before we tack on more stuff. */ if((unsigned long) kern_msg.msg_control != cmsg_ptr) - cmsg32_recvmsg_fixup(&kern_msg, cmsg_ptr); + cmsg32_recvmsg_fixup(&kern_msg, + cmsg_ptr, cmsg_len); /* Wheee... */ if(sock->passcred) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/x86_64/kernel/pci-irq.c linux-2.4.30-pre2/arch/x86_64/kernel/pci-irq.c --- linux-2.4.29/arch/x86_64/kernel/pci-irq.c 2003-08-25 11:44:40.000000000 +0000 +++ linux-2.4.30-pre2/arch/x86_64/kernel/pci-irq.c 2005-02-23 07:46:06.000000000 +0000 @@ -742,7 +742,7 @@ void pcibios_penalize_isa_irq(int irq) void pcibios_enable_irq(struct pci_dev *dev) { u8 pin; - extern int interrupt_line_quirk; + extern int via_interrupt_line_quirk; pci_read_config_byte(dev, PCI_INTERRUPT_PIN, &pin); if (pin && !pcibios_lookup_irq(dev, 1) && !dev->irq) { @@ -762,6 +762,6 @@ void pcibios_enable_irq(struct pci_dev * } /* VIA bridges use interrupt line for apic/pci steering across the V-Link */ - else if (interrupt_line_quirk) + else if (via_interrupt_line_quirk) pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq); } diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/arch/x86_64/kernel/setup.c linux-2.4.30-pre2/arch/x86_64/kernel/setup.c --- linux-2.4.29/arch/x86_64/kernel/setup.c 2005-01-19 14:09:39.000000000 +0000 +++ linux-2.4.30-pre2/arch/x86_64/kernel/setup.c 2005-02-23 07:45:00.000000000 +0000 @@ -93,7 +93,8 @@ char saved_command_line[COMMAND_LINE_SIZ struct resource standard_io_resources[] = { { "dma1", 0x00, 0x1f, IORESOURCE_BUSY }, { "pic1", 0x20, 0x3f, IORESOURCE_BUSY }, - { "timer", 0x40, 0x5f, IORESOURCE_BUSY }, + { "timer0", 0x40, 0x43, IORESOURCE_BUSY }, + { "timer1", 0x50, 0x53, IORESOURCE_BUSY }, { "keyboard", 0x60, 0x6f, IORESOURCE_BUSY }, { "dma page reg", 0x80, 0x8f, IORESOURCE_BUSY }, { "pic2", 0xa0, 0xbf, IORESOURCE_BUSY }, diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/acpi/pci_irq.c linux-2.4.30-pre2/drivers/acpi/pci_irq.c --- linux-2.4.29/drivers/acpi/pci_irq.c 2004-08-07 23:26:04.000000000 +0000 +++ linux-2.4.30-pre2/drivers/acpi/pci_irq.c 2005-02-23 07:46:41.000000000 +0000 @@ -335,6 +335,7 @@ acpi_pci_irq_enable ( { int irq = 0; u8 pin = 0; + extern int via_interrupt_line_quirk; ACPI_FUNCTION_TRACE("acpi_pci_irq_enable"); @@ -383,6 +384,9 @@ acpi_pci_irq_enable ( } } + if (via_interrupt_line_quirk) + pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq & 15); + dev->irq = irq; ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Device %s using IRQ %d\n", dev->slot_name, dev->irq)); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/block/nbd.c linux-2.4.30-pre2/drivers/block/nbd.c --- linux-2.4.29/drivers/block/nbd.c 2003-08-25 11:44:41.000000000 +0000 +++ linux-2.4.30-pre2/drivers/block/nbd.c 2005-02-23 07:45:00.000000000 +0000 @@ -408,10 +408,7 @@ static int nbd_ioctl(struct inode *inode int dev, error, temp; struct request sreq ; - /* Anyone capable of this syscall can do *real bad* things */ - if (!capable(CAP_SYS_ADMIN)) - return -EPERM; if (!inode) return -EINVAL; dev = MINOR(inode->i_rdev); @@ -419,6 +416,20 @@ static int nbd_ioctl(struct inode *inode return -ENODEV; lo = &nbd_dev[dev]; + + /* these are innocent, but.... */ + switch (cmd) { + case BLKGETSIZE: + return put_user(nbd_bytesizes[dev] >> 9, (unsigned long *) arg); + case BLKGETSIZE64: + return put_user((u64)nbd_bytesizes[dev], (u64 *) arg); + } + + /* ... anyone capable of any of the below ioctls can do *real bad* + things */ + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + switch (cmd) { case NBD_DISCONNECT: printk("NBD_DISCONNECT\n"); @@ -524,10 +535,6 @@ static int nbd_ioctl(struct inode *inode dev, lo->queue_head.next, lo->queue_head.prev, requests_in, requests_out); return 0; #endif - case BLKGETSIZE: - return put_user(nbd_bytesizes[dev] >> 9, (unsigned long *) arg); - case BLKGETSIZE64: - return put_user((u64)nbd_bytesizes[dev], (u64 *) arg); } return -EINVAL; } diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/char/lcd.c linux-2.4.30-pre2/drivers/char/lcd.c --- linux-2.4.29/drivers/char/lcd.c 2005-01-19 14:09:46.000000000 +0000 +++ linux-2.4.30-pre2/drivers/char/lcd.c 2005-02-23 07:45:07.000000000 +0000 @@ -386,6 +386,8 @@ static int lcd_ioctl(struct inode *inode int ctr=0; + if (!capable(CAP_SYS_ADMIN)) return -EPERM; + // Chip Erase Sequence WRITE_FLASH( kFlash_Addr1, kFlash_Data1 ); WRITE_FLASH( kFlash_Addr2, kFlash_Data2 ); @@ -422,6 +424,8 @@ static int lcd_ioctl(struct inode *inode struct lcd_display display; + if (!capable(CAP_SYS_ADMIN)) return -EPERM; + if(copy_from_user(&display, (struct lcd_display*)arg, sizeof(struct lcd_display))) return -EFAULT; rom = (unsigned char *) kmalloc((128),GFP_ATOMIC); @@ -434,8 +438,10 @@ static int lcd_ioctl(struct inode *inode save_flags(flags); for (i=0; i LP_BUFFER_SIZE) copy_size = LP_BUFFER_SIZE; - if (copy_from_user (kbuf, buf, copy_size)) - return -EFAULT; - if (down_interruptible (&lp_table[minor].port_mutex)) return -EINTR; + if (copy_from_user (kbuf, buf, copy_size)) { + retv = -EFAULT; + goto out_unlock; + } + /* Claim Parport or sleep until it becomes available */ lp_claim_parport_or_block (&lp_table[minor]); @@ -398,7 +400,7 @@ static ssize_t lp_write(struct file * fi lp_table[minor].current_mode = IEEE1284_MODE_COMPAT; lp_release_parport (&lp_table[minor]); } - +out_unlock: up (&lp_table[minor].port_mutex); return retv; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/i2c/i2c-algo-bit.c linux-2.4.30-pre2/drivers/i2c/i2c-algo-bit.c --- linux-2.4.29/drivers/i2c/i2c-algo-bit.c 2004-02-18 13:36:31.000000000 +0000 +++ linux-2.4.30-pre2/drivers/i2c/i2c-algo-bit.c 2005-02-23 07:45:44.000000000 +0000 @@ -28,14 +28,12 @@ #include #include #include -#include -#include #include #include - #include #include + /* ----- global defines ----------------------------------------------- */ #define DEB(x) if (i2c_debug>=1) x; #define DEB2(x) if (i2c_debug>=2) x; @@ -522,8 +520,8 @@ static int algo_control(struct i2c_adapt static u32 bit_func(struct i2c_adapter *adap) { - return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_10BIT_ADDR | - I2C_FUNC_PROTOCOL_MANGLING; + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | + I2C_FUNC_10BIT_ADDR | I2C_FUNC_PROTOCOL_MANGLING; } diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/i2c/i2c-algo-pcf.c linux-2.4.30-pre2/drivers/i2c/i2c-algo-pcf.c --- linux-2.4.29/drivers/i2c/i2c-algo-pcf.c 2004-02-18 13:36:31.000000000 +0000 +++ linux-2.4.30-pre2/drivers/i2c/i2c-algo-pcf.c 2005-02-23 07:46:15.000000000 +0000 @@ -32,15 +32,13 @@ #include #include #include -#include -#include #include #include - #include #include #include "i2c-pcf8584.h" + /* ----- global defines ----------------------------------------------- */ #define DEB(x) if (i2c_debug>=1) x #define DEB2(x) if (i2c_debug>=2) x @@ -435,8 +433,8 @@ static int algo_control(struct i2c_adapt static u32 pcf_func(struct i2c_adapter *adap) { - return I2C_FUNC_SMBUS_EMUL | I2C_FUNC_10BIT_ADDR | - I2C_FUNC_PROTOCOL_MANGLING; + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | + I2C_FUNC_10BIT_ADDR | I2C_FUNC_PROTOCOL_MANGLING; } /* -----exported algorithm data: ------------------------------------- */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/ide/ide-cd.c linux-2.4.30-pre2/drivers/ide/ide-cd.c --- linux-2.4.29/drivers/ide/ide-cd.c 2003-11-28 18:26:20.000000000 +0000 +++ linux-2.4.30-pre2/drivers/ide/ide-cd.c 2005-02-23 07:45:28.000000000 +0000 @@ -2206,25 +2206,31 @@ static int cdrom_read_toc(ide_drive_t *d /* Read the multisession information. */ if (toc->hdr.first_track != CDROM_LEADOUT) { /* Read the multisession information. */ - stat = cdrom_read_tocentry(drive, 0, 1, 1, (char *)&ms_tmp, + stat = cdrom_read_tocentry(drive, 0, 0, 1, (char *)&ms_tmp, sizeof(ms_tmp), sense); if (stat) return stat; + + toc->last_session_lba = be32_to_cpu(ms_tmp.ent.addr.lba); } else { - ms_tmp.ent.addr.msf.minute = 0; - ms_tmp.ent.addr.msf.second = 2; - ms_tmp.ent.addr.msf.frame = 0; ms_tmp.hdr.first_track = ms_tmp.hdr.last_track = CDROM_LEADOUT; + toc->last_session_lba = msf_to_lba(0, 2, 0); /* 0m 2s 0f */ } #if ! STANDARD_ATAPI - if (CDROM_CONFIG_FLAGS(drive)->tocaddr_as_bcd) + if (CDROM_CONFIG_FLAGS(drive)->tocaddr_as_bcd) { + /* Re-read multisession information using MSF format */ + stat = cdrom_read_tocentry(drive, 0, 1, 1, (char *)&ms_tmp, + sizeof(ms_tmp), sense); + if (stat) + return stat; + msf_from_bcd (&ms_tmp.ent.addr.msf); + toc->last_session_lba = msf_to_lba(ms_tmp.ent.addr.msf.minute, + ms_tmp.ent.addr.msf.second, + ms_tmp.ent.addr.msf.frame); + } #endif /* not STANDARD_ATAPI */ - toc->last_session_lba = msf_to_lba (ms_tmp.ent.addr.msf.minute, - ms_tmp.ent.addr.msf.second, - ms_tmp.ent.addr.msf.frame); - toc->xa_flag = (ms_tmp.hdr.first_track != ms_tmp.hdr.last_track); /* Now try to get the total cdrom capacity. */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/isdn/hisax/ipacx.c linux-2.4.30-pre2/drivers/isdn/hisax/ipacx.c --- linux-2.4.29/drivers/isdn/hisax/ipacx.c 2002-11-28 23:53:13.000000000 +0000 +++ linux-2.4.30-pre2/drivers/isdn/hisax/ipacx.c 2005-02-23 07:44:59.000000000 +0000 @@ -152,7 +152,13 @@ dch_l2l1(struct PStack *st, int pr, void case (HW_RESET | REQUEST): case (HW_ENABLE | REQUEST): - ph_command(cs, IPACX_CMD_TIM); + if ((cs->dc.isac.ph_state == IPACX_IND_RES) || + (cs->dc.isac.ph_state == IPACX_IND_DR) || + (cs->dc.isac.ph_state == IPACX_IND_DC)) + ph_command(cs, IPACX_CMD_TIM); + else + ph_command(cs, IPACX_CMD_RES); + break; case (HW_INFO3 | REQUEST): diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/md/lvm-snap.c linux-2.4.30-pre2/drivers/md/lvm-snap.c --- linux-2.4.29/drivers/md/lvm-snap.c 2004-04-14 13:05:30.000000000 +0000 +++ linux-2.4.30-pre2/drivers/md/lvm-snap.c 2005-02-23 07:46:10.000000000 +0000 @@ -119,7 +119,6 @@ static inline lv_block_exception_t *lvm_ unsigned long mask = lv->lv_snapshot_hash_mask; int chunk_size = lv->lv_chunk_size; lv_block_exception_t *ret; - int i = 0; hash_table = &hash_table[hashfn(org_dev, org_start, mask, chunk_size)]; @@ -132,15 +131,9 @@ static inline lv_block_exception_t *lvm_ exception = list_entry(next, lv_block_exception_t, hash); if (exception->rsector_org == org_start && exception->rdev_org == org_dev) { - if (i) { - /* fun, isn't it? :) */ - list_del(next); - list_add(next, hash_table); - } ret = exception; break; } - i++; } return ret; } diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/net/tg3.c linux-2.4.30-pre2/drivers/net/tg3.c --- linux-2.4.29/drivers/net/tg3.c 2005-01-19 14:09:56.000000000 +0000 +++ linux-2.4.30-pre2/drivers/net/tg3.c 2005-02-23 07:45:26.000000000 +0000 @@ -59,8 +59,8 @@ #define DRV_MODULE_NAME "tg3" #define PFX DRV_MODULE_NAME ": " -#define DRV_MODULE_VERSION "3.15" -#define DRV_MODULE_RELDATE "January 6, 2005" +#define DRV_MODULE_VERSION "3.23" +#define DRV_MODULE_RELDATE "February 15, 2005" #define TG3_DEF_MAC_MODE 0 #define TG3_DEF_RX_MODE 0 @@ -575,9 +575,10 @@ static void tg3_phy_set_wirespeed(struct if (tp->tg3_flags2 & TG3_FLG2_NO_ETH_WIRE_SPEED) return; - tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x7007); - tg3_readphy(tp, MII_TG3_AUX_CTRL, &val); - tg3_writephy(tp, MII_TG3_AUX_CTRL, (val | (1 << 15) | (1 << 4))); + if (!tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x7007) && + !tg3_readphy(tp, MII_TG3_AUX_CTRL, &val)) + tg3_writephy(tp, MII_TG3_AUX_CTRL, + (val | (1 << 15) | (1 << 4))); } static int tg3_bmcr_reset(struct tg3 *tp) @@ -618,9 +619,10 @@ static int tg3_wait_macro_done(struct tg while (limit--) { u32 tmp32; - tg3_readphy(tp, 0x16, &tmp32); - if ((tmp32 & 0x1000) == 0) - break; + if (!tg3_readphy(tp, 0x16, &tmp32)) { + if ((tmp32 & 0x1000) == 0) + break; + } } if (limit <= 0) return -EBUSY; @@ -672,9 +674,9 @@ static int tg3_phy_write_and_check_testp for (i = 0; i < 6; i += 2) { u32 low, high; - tg3_readphy(tp, MII_TG3_DSP_RW_PORT, &low); - tg3_readphy(tp, MII_TG3_DSP_RW_PORT, &high); - if (tg3_wait_macro_done(tp)) { + if (tg3_readphy(tp, MII_TG3_DSP_RW_PORT, &low) || + tg3_readphy(tp, MII_TG3_DSP_RW_PORT, &high) || + tg3_wait_macro_done(tp)) { *resetp = 1; return -EBUSY; } @@ -730,7 +732,9 @@ static int tg3_phy_reset_5703_4_5(struct } /* Disable transmitter and interrupt. */ - tg3_readphy(tp, MII_TG3_EXT_CTRL, ®32); + if (tg3_readphy(tp, MII_TG3_EXT_CTRL, ®32)) + continue; + reg32 |= 0x3000; tg3_writephy(tp, MII_TG3_EXT_CTRL, reg32); @@ -739,7 +743,9 @@ static int tg3_phy_reset_5703_4_5(struct BMCR_FULLDPLX | TG3_BMCR_SPEED1000); /* Set to master mode. */ - tg3_readphy(tp, MII_TG3_CTRL, &phy9_orig); + if (tg3_readphy(tp, MII_TG3_CTRL, &phy9_orig)) + continue; + tg3_writephy(tp, MII_TG3_CTRL, (MII_TG3_CTRL_AS_MASTER | MII_TG3_CTRL_ENABLE_AS_MASTER)); @@ -777,9 +783,11 @@ static int tg3_phy_reset_5703_4_5(struct tg3_writephy(tp, MII_TG3_CTRL, phy9_orig); - tg3_readphy(tp, MII_TG3_EXT_CTRL, ®32); - reg32 &= ~0x3000; - tg3_writephy(tp, MII_TG3_EXT_CTRL, reg32); + if (!tg3_readphy(tp, MII_TG3_EXT_CTRL, ®32)) { + reg32 &= ~0x3000; + tg3_writephy(tp, MII_TG3_EXT_CTRL, reg32); + } else if (!err) + err = -EBUSY; return err; } @@ -843,9 +851,9 @@ out: u32 phy_reg; /* Set bit 14 with read-modify-write to preserve other bits */ - tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0007); - tg3_readphy(tp, MII_TG3_AUX_CTRL, &phy_reg); - tg3_writephy(tp, MII_TG3_AUX_CTRL, phy_reg | 0x4000); + if (!tg3_writephy(tp, MII_TG3_AUX_CTRL, 0x0007) && + !tg3_readphy(tp, MII_TG3_AUX_CTRL, &phy_reg)) + tg3_writephy(tp, MII_TG3_AUX_CTRL, phy_reg | 0x4000); } tg3_phy_set_wirespeed(tp); return 0; @@ -877,7 +885,7 @@ static void tg3_frob_aux_power(struct tg GRC_LCLCTRL_GPIO_OUTPUT1)); udelay(100); } else { - int no_gpio2; + u32 no_gpio2; u32 grc_local_ctrl; if (tp_peer != tp && @@ -885,8 +893,8 @@ static void tg3_frob_aux_power(struct tg return; /* On 5753 and variants, GPIO2 cannot be used. */ - no_gpio2 = (tp->nic_sram_data_cfg & - NIC_SRAM_DATA_CFG_NO_GPIO2) != 0; + no_gpio2 = tp->nic_sram_data_cfg & + NIC_SRAM_DATA_CFG_NO_GPIO2; grc_local_ctrl = GRC_LCLCTRL_GPIO_OE0 | GRC_LCLCTRL_GPIO_OE1 | @@ -898,29 +906,17 @@ static void tg3_frob_aux_power(struct tg GRC_LCLCTRL_GPIO_OUTPUT2); } tw32_f(GRC_LOCAL_CTRL, tp->grc_local_ctrl | - grc_local_ctrl); + grc_local_ctrl); udelay(100); - grc_local_ctrl = GRC_LCLCTRL_GPIO_OE0 | - GRC_LCLCTRL_GPIO_OE1 | - GRC_LCLCTRL_GPIO_OE2 | - GRC_LCLCTRL_GPIO_OUTPUT0 | - GRC_LCLCTRL_GPIO_OUTPUT1 | - GRC_LCLCTRL_GPIO_OUTPUT2; - if (no_gpio2) { - grc_local_ctrl &= ~(GRC_LCLCTRL_GPIO_OE2 | - GRC_LCLCTRL_GPIO_OUTPUT2); - } + grc_local_ctrl |= GRC_LCLCTRL_GPIO_OUTPUT0; + tw32_f(GRC_LOCAL_CTRL, tp->grc_local_ctrl | - grc_local_ctrl); + grc_local_ctrl); udelay(100); - grc_local_ctrl = GRC_LCLCTRL_GPIO_OE0 | - GRC_LCLCTRL_GPIO_OE1 | - GRC_LCLCTRL_GPIO_OE2 | - GRC_LCLCTRL_GPIO_OUTPUT0 | - GRC_LCLCTRL_GPIO_OUTPUT1; if (!no_gpio2) { + grc_local_ctrl &= ~GRC_LCLCTRL_GPIO_OUTPUT2; tw32_f(GRC_LOCAL_CTRL, tp->grc_local_ctrl | grc_local_ctrl); udelay(100); @@ -1240,7 +1236,7 @@ static void tg3_aux_stat_to_speed_duplex }; } -static int tg3_phy_copper_begin(struct tg3 *tp) +static void tg3_phy_copper_begin(struct tg3 *tp) { u32 new_adv; int i; @@ -1355,15 +1351,16 @@ static int tg3_phy_copper_begin(struct t if (tp->link_config.duplex == DUPLEX_FULL) bmcr |= BMCR_FULLDPLX; - tg3_readphy(tp, MII_BMCR, &orig_bmcr); - if (bmcr != orig_bmcr) { + if (!tg3_readphy(tp, MII_BMCR, &orig_bmcr) && + (bmcr != orig_bmcr)) { tg3_writephy(tp, MII_BMCR, BMCR_LOOPBACK); for (i = 0; i < 1500; i++) { u32 tmp; udelay(10); - tg3_readphy(tp, MII_BMSR, &tmp); - tg3_readphy(tp, MII_BMSR, &tmp); + if (tg3_readphy(tp, MII_BMSR, &tmp) || + tg3_readphy(tp, MII_BMSR, &tmp)) + continue; if (!(tmp & BMSR_LSTATUS)) { udelay(40); break; @@ -1376,8 +1373,6 @@ static int tg3_phy_copper_begin(struct t tg3_writephy(tp, MII_BMCR, BMCR_ANENABLE | BMCR_ANRESTART); } - - return 0; } static int tg3_init_5401phy_dsp(struct tg3 *tp) @@ -1412,7 +1407,9 @@ static int tg3_copper_is_advertising_all { u32 adv_reg, all_mask; - tg3_readphy(tp, MII_ADVERTISE, &adv_reg); + if (tg3_readphy(tp, MII_ADVERTISE, &adv_reg)) + return 0; + all_mask = (ADVERTISE_10HALF | ADVERTISE_10FULL | ADVERTISE_100HALF | ADVERTISE_100FULL); if ((adv_reg & all_mask) != all_mask) @@ -1420,7 +1417,9 @@ static int tg3_copper_is_advertising_all if (!(tp->tg3_flags & TG3_FLAG_10_100_ONLY)) { u32 tg3_ctrl; - tg3_readphy(tp, MII_TG3_CTRL, &tg3_ctrl); + if (tg3_readphy(tp, MII_TG3_CTRL, &tg3_ctrl)) + return 0; + all_mask = (MII_TG3_CTRL_ADV_1000_HALF | MII_TG3_CTRL_ADV_1000_FULL); if ((tg3_ctrl & all_mask) != all_mask) @@ -1460,8 +1459,8 @@ static int tg3_setup_copper_phy(struct t GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705) && netif_carrier_ok(tp->dev)) { tg3_readphy(tp, MII_BMSR, &bmsr); - tg3_readphy(tp, MII_BMSR, &bmsr); - if (!(bmsr & BMSR_LSTATUS)) + if (!tg3_readphy(tp, MII_BMSR, &bmsr) && + !(bmsr & BMSR_LSTATUS)) force_reset = 1; } if (force_reset) @@ -1469,9 +1468,8 @@ static int tg3_setup_copper_phy(struct t if ((tp->phy_id & PHY_ID_MASK) == PHY_ID_BCM5401) { tg3_readphy(tp, MII_BMSR, &bmsr); - tg3_readphy(tp, MII_BMSR, &bmsr); - - if (!(tp->tg3_flags & TG3_FLAG_INIT_COMPLETE)) + if (tg3_readphy(tp, MII_BMSR, &bmsr) || + !(tp->tg3_flags & TG3_FLAG_INIT_COMPLETE)) bmsr = 0; if (!(bmsr & BMSR_LSTATUS)) { @@ -1482,8 +1480,8 @@ static int tg3_setup_copper_phy(struct t tg3_readphy(tp, MII_BMSR, &bmsr); for (i = 0; i < 1000; i++) { udelay(10); - tg3_readphy(tp, MII_BMSR, &bmsr); - if (bmsr & BMSR_LSTATUS) { + if (!tg3_readphy(tp, MII_BMSR, &bmsr) && + (bmsr & BMSR_LSTATUS)) { udelay(40); break; } @@ -1545,8 +1543,8 @@ static int tg3_setup_copper_phy(struct t bmsr = 0; for (i = 0; i < 100; i++) { tg3_readphy(tp, MII_BMSR, &bmsr); - tg3_readphy(tp, MII_BMSR, &bmsr); - if (bmsr & BMSR_LSTATUS) + if (!tg3_readphy(tp, MII_BMSR, &bmsr) && + (bmsr & BMSR_LSTATUS)) break; udelay(40); } @@ -1557,8 +1555,8 @@ static int tg3_setup_copper_phy(struct t tg3_readphy(tp, MII_TG3_AUX_STAT, &aux_stat); for (i = 0; i < 2000; i++) { udelay(10); - tg3_readphy(tp, MII_TG3_AUX_STAT, &aux_stat); - if (aux_stat) + if (!tg3_readphy(tp, MII_TG3_AUX_STAT, &aux_stat) && + aux_stat) break; } @@ -1569,7 +1567,8 @@ static int tg3_setup_copper_phy(struct t bmcr = 0; for (i = 0; i < 200; i++) { tg3_readphy(tp, MII_BMCR, &bmcr); - tg3_readphy(tp, MII_BMCR, &bmcr); + if (tg3_readphy(tp, MII_BMCR, &bmcr)) + continue; if (bmcr && bmcr != 0x7fff) break; udelay(10); @@ -1606,10 +1605,13 @@ static int tg3_setup_copper_phy(struct t (tp->link_config.autoneg == AUTONEG_ENABLE)) { u32 local_adv, remote_adv; - tg3_readphy(tp, MII_ADVERTISE, &local_adv); + if (tg3_readphy(tp, MII_ADVERTISE, &local_adv)) + local_adv = 0; local_adv &= (ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM); - tg3_readphy(tp, MII_LPA, &remote_adv); + if (tg3_readphy(tp, MII_LPA, &remote_adv)) + remote_adv = 0; + remote_adv &= (LPA_PAUSE_CAP | LPA_PAUSE_ASYM); /* If we are not advertising full pause capability, @@ -1628,8 +1630,8 @@ relink: tg3_phy_copper_begin(tp); tg3_readphy(tp, MII_BMSR, &tmp); - tg3_readphy(tp, MII_BMSR, &tmp); - if (tmp & BMSR_LSTATUS) + if (!tg3_readphy(tp, MII_BMSR, &tmp) && + (tmp & BMSR_LSTATUS)) current_link_up = 1; } @@ -2130,8 +2132,9 @@ static int tg3_setup_fiber_hw_autoneg(st if (tr32(TG3PCI_DUAL_MAC_CTRL) & DUAL_MAC_CTRL_ID) port_a = 0; - serdes_cfg = tr32(MAC_SERDES_CFG) & - ((1 << 23) | (1 << 22) | (1 << 21) | (1 << 20)); + /* preserve bits 0-11,13,14 for signal pre-emphasis */ + /* preserve bits 20-23 for voltage regulator */ + serdes_cfg = tr32(MAC_SERDES_CFG) & 0x00f06fff; } sg_dig_ctrl = tr32(SG_DIG_CTRL); @@ -2142,9 +2145,9 @@ static int tg3_setup_fiber_hw_autoneg(st u32 val = serdes_cfg; if (port_a) - val |= 0xc010880; + val |= 0xc010000; else - val |= 0x4010880; + val |= 0x4010000; tw32_f(MAC_SERDES_CFG, val); } tw32_f(SG_DIG_CTRL, 0x01388400); @@ -2167,7 +2170,7 @@ static int tg3_setup_fiber_hw_autoneg(st if (sg_dig_ctrl != expected_sg_dig_ctrl) { if (workaround) - tw32_f(MAC_SERDES_CFG, serdes_cfg | 0xc011880); + tw32_f(MAC_SERDES_CFG, serdes_cfg | 0xc011000); tw32_f(SG_DIG_CTRL, expected_sg_dig_ctrl | (1 << 30)); udelay(5); tw32_f(SG_DIG_CTRL, expected_sg_dig_ctrl); @@ -2208,9 +2211,9 @@ static int tg3_setup_fiber_hw_autoneg(st u32 val = serdes_cfg; if (port_a) - val |= 0xc010880; + val |= 0xc010000; else - val |= 0x4010880; + val |= 0x4010000; tw32_f(MAC_SERDES_CFG, val); } @@ -2218,8 +2221,12 @@ static int tg3_setup_fiber_hw_autoneg(st tw32_f(SG_DIG_CTRL, 0x01388400); udelay(40); + /* Link parallel detection - link is up */ + /* only if we have PCS_SYNC and not */ + /* receiving config code words */ mac_status = tr32(MAC_STATUS); - if (mac_status & MAC_STATUS_PCS_SYNCED) { + if ((mac_status & MAC_STATUS_PCS_SYNCED) && + !(mac_status & MAC_STATUS_RCVD_CFG)) { tg3_setup_flow_control(tp, 0, 0); current_link_up = 1; } @@ -2690,7 +2697,11 @@ static int tg3_rx(struct tg3 *tp, int bu len = ((desc->idx_len & RXD_LEN_MASK) >> RXD_LEN_SHIFT) - 4; /* omit crc */ - if (len > RX_COPY_THRESHOLD) { + if (len > RX_COPY_THRESHOLD + && tp->rx_offset == 2 + /* rx_offset != 2 iff this is a 5701 card running + * in PCI-X mode [see tg3_get_invariants()] */ + ) { int skb_size; skb_size = tg3_alloc_rx_skb(tp, opaque_key, @@ -3085,11 +3096,19 @@ static int tg3_start_xmit(struct sk_buff skb->nh.iph->check = 0; skb->nh.iph->tot_len = ntohs(mss + ip_tcp_len + tcp_opt_len); - skb->h.th->check = ~csum_tcpudp_magic(skb->nh.iph->saddr, - skb->nh.iph->daddr, - 0, IPPROTO_TCP, 0); + if (tp->tg3_flags2 & TG3_FLG2_HW_TSO) { + skb->h.th->check = 0; + base_flags &= ~TXD_FLAG_TCPUDP_CSUM; + } + else { + skb->h.th->check = + ~csum_tcpudp_magic(skb->nh.iph->saddr, + skb->nh.iph->daddr, + 0, IPPROTO_TCP, 0); + } - if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705) { + if ((tp->tg3_flags2 & TG3_FLG2_HW_TSO) || + (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705)) { if (tcp_opt_len || skb->nh.iph->ihl > 5) { int tsflags; @@ -3156,7 +3175,7 @@ static int tg3_start_xmit(struct sk_buff would_hit_hwbug = entry + 1; } - if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) + if (tp->tg3_flags2 & TG3_FLG2_HW_TSO) tg3_set_txd(tp, entry, mapping, len, base_flags, (i == last)|(mss << 1)); else @@ -4747,7 +4766,7 @@ static int tg3_load_tso_firmware(struct unsigned long cpu_base, cpu_scratch_base, cpu_scratch_size; int err, i; - if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) + if (tp->tg3_flags2 & TG3_FLG2_HW_TSO) return 0; if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705) { @@ -4831,9 +4850,8 @@ static void __tg3_set_mac_addr(struct tg tw32(MAC_ADDR_0_LOW + (i * 8), addr_low); } - if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700 && - GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701 && - GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5705) { + if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5703 || + GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704) { for (i = 0; i < 12; i++) { tw32(MAC_EXTADDR_0_HIGH + (i * 8), addr_high); tw32(MAC_EXTADDR_0_LOW + (i * 8), addr_low); @@ -4879,7 +4897,8 @@ static void tg3_set_bdinfo(struct tg3 *t (bdinfo_addr + TG3_BDINFO_MAXLEN_FLAGS), maxlen_flags); - if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5705) + if ((GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5705) && + (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5750)) tg3_write_mem(tp, (bdinfo_addr + TG3_BDINFO_NIC_ADDR), nic_addr); @@ -5181,7 +5200,7 @@ static int tg3_reset_hw(struct tg3 *tp) } #if TG3_TSO_SUPPORT != 0 - if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) + if (tp->tg3_flags2 & TG3_FLG2_HW_TSO) rdmac_mode |= (1 << 27); #endif @@ -5331,7 +5350,7 @@ static int tg3_reset_hw(struct tg3 *tp) tw32(RCVDBDI_MODE, RCVDBDI_MODE_ENABLE | RCVDBDI_MODE_INV_RING_SZ); tw32(SNDDATAI_MODE, SNDDATAI_MODE_ENABLE); #if TG3_TSO_SUPPORT != 0 - if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) + if (tp->tg3_flags2 & TG3_FLG2_HW_TSO) tw32(SNDDATAI_MODE, SNDDATAI_MODE_ENABLE | 0x8); #endif tw32(SNDBDI_MODE, SNDBDI_MODE_ENABLE | SNDBDI_MODE_ATTN_ENABLE); @@ -5381,8 +5400,10 @@ static int tg3_reset_hw(struct tg3 *tp) udelay(10); if (tp->tg3_flags2 & TG3_FLG2_PHY_SERDES) { - if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704) { + if ((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704) && + !(tp->tg3_flags2 & TG3_FLG2_SERDES_PREEMPHASIS)) { /* Set drive transmission level to 1.2V */ + /* only if the signal pre-emphasis bit is not set */ val = tr32(MAC_SERDES_CFG); val &= 0xfffff000; val |= 0x880; @@ -5411,9 +5432,10 @@ static int tg3_reset_hw(struct tg3 *tp) u32 tmp; /* Clear CRC stats. */ - tg3_readphy(tp, 0x1e, &tmp); - tg3_writephy(tp, 0x1e, tmp | 0x8000); - tg3_readphy(tp, 0x14, &tmp); + if (!tg3_readphy(tp, 0x1e, &tmp)) { + tg3_writephy(tp, 0x1e, tmp | 0x8000); + tg3_readphy(tp, 0x14, &tmp); + } } __tg3_set_rx_mode(tp->dev); @@ -6003,9 +6025,11 @@ static unsigned long calc_crc_errors(str u32 val; spin_lock_irqsave(&tp->lock, flags); - tg3_readphy(tp, 0x1e, &val); - tg3_writephy(tp, 0x1e, val | 0x8000); - tg3_readphy(tp, 0x14, &val); + if (!tg3_readphy(tp, 0x1e, &val)) { + tg3_writephy(tp, 0x1e, val | 0x8000); + tg3_readphy(tp, 0x14, &val); + } else + val = 0; spin_unlock_irqrestore(&tp->lock, flags); tp->phy_crc_errors += val; @@ -6349,11 +6373,13 @@ do { p = (u32 *)(orig_p + (reg)); \ static int tg3_get_eeprom_len(struct net_device *dev) { - return EEPROM_CHIP_SIZE; + struct tg3 *tp = netdev_priv(dev); + + return tp->nvram_size; } -static int tg3_nvram_read_using_eeprom(struct tg3 *tp, - u32 offset, u32 *val); +static int tg3_nvram_read(struct tg3 *tp, u32 offset, u32 *val); + static int tg3_get_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom, u8 *data) { struct tg3 *tp = dev->priv; @@ -6365,10 +6391,7 @@ static int tg3_get_eeprom(struct net_dev len = eeprom->len; eeprom->len = 0; - ret = tg3_nvram_read_using_eeprom(tp, 0, &eeprom->magic); - if (ret) - return ret; - eeprom->magic = swab32(eeprom->magic); + eeprom->magic = TG3_EEPROM_MAGIC; if (offset & 3) { /* adjustments to start on required 4 byte boundary */ @@ -6378,9 +6401,10 @@ static int tg3_get_eeprom(struct net_dev /* i.e. offset=1 len=2 */ b_count = len; } - ret = tg3_nvram_read_using_eeprom(tp, offset-b_offset, &val); + ret = tg3_nvram_read(tp, offset-b_offset, &val); if (ret) return ret; + val = cpu_to_le32(val); memcpy(data, ((char*)&val) + b_offset, b_count); len -= b_count; offset += b_count; @@ -6390,12 +6414,13 @@ static int tg3_get_eeprom(struct net_dev /* read bytes upto the last 4 byte boundary */ pd = &data[eeprom->len]; for (i = 0; i < (len - (len & 3)); i += 4) { - ret = tg3_nvram_read_using_eeprom(tp, offset + i, - (u32*)(pd + i)); + ret = tg3_nvram_read(tp, offset + i, &val); if (ret) { eeprom->len += i; return ret; } + val = cpu_to_le32(val); + memcpy(pd + i, &val, 4); } eeprom->len += i; @@ -6404,15 +6429,72 @@ static int tg3_get_eeprom(struct net_dev pd = &data[eeprom->len]; b_count = len & 3; b_offset = offset + len - b_count; - ret = tg3_nvram_read_using_eeprom(tp, b_offset, &val); + ret = tg3_nvram_read(tp, b_offset, &val); if (ret) return ret; + val = cpu_to_le32(val); memcpy(pd, ((char*)&val), b_count); eeprom->len += b_count; } return 0; } +static int tg3_nvram_write_block(struct tg3 *tp, u32 offset, u32 len, u8 *buf); + +static int tg3_set_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom, u8 *data) +{ + struct tg3 *tp = netdev_priv(dev); + int ret; + u32 offset, len, b_offset, odd_len, start, end; + u8 *buf; + + if (eeprom->magic != TG3_EEPROM_MAGIC) + return -EINVAL; + + offset = eeprom->offset; + len = eeprom->len; + + if ((b_offset = (offset & 3))) { + /* adjustments to start on required 4 byte boundary */ + ret = tg3_nvram_read(tp, offset-b_offset, &start); + if (ret) + return ret; + start = cpu_to_le32(start); + len += b_offset; + offset &= ~3; + } + + odd_len = 0; + if ((len & 3) && ((len > 4) || (b_offset == 0))) { + /* adjustments to end on required 4 byte boundary */ + odd_len = 1; + len = (len + 3) & ~3; + ret = tg3_nvram_read(tp, offset+len-4, &end); + if (ret) + return ret; + end = cpu_to_le32(end); + } + + buf = data; + if (b_offset || odd_len) { + buf = kmalloc(len, GFP_KERNEL); + if (buf == 0) + return -ENOMEM; + if (b_offset) + memcpy(buf, &start, 4); + if (odd_len) + memcpy(buf+len-4, &end, 4); + memcpy(buf + b_offset, data, eeprom->len); + } + + ret = tg3_nvram_write_block(tp, offset, len, buf); + + if (buf != data) + kfree(buf); + + return ret; +} + static int tg3_get_settings(struct net_device *dev, struct ethtool_cmd *cmd) { struct tg3 *tp = netdev_priv(dev); @@ -6561,10 +6643,10 @@ static int tg3_nway_reset(struct net_dev int r; spin_lock_irq(&tp->lock); - tg3_readphy(tp, MII_BMCR, &bmcr); - tg3_readphy(tp, MII_BMCR, &bmcr); r = -EINVAL; - if (bmcr & BMCR_ANENABLE) { + tg3_readphy(tp, MII_BMCR, &bmcr); + if (!tg3_readphy(tp, MII_BMCR, &bmcr) && + (bmcr & BMCR_ANENABLE)) { tg3_writephy(tp, MII_BMCR, bmcr | BMCR_ANRESTART); r = 0; } @@ -6812,6 +6894,7 @@ static struct ethtool_ops tg3_ethtool_op .get_link = ethtool_op_get_link, .get_eeprom_len = tg3_get_eeprom_len, .get_eeprom = tg3_get_eeprom, + .set_eeprom = tg3_set_eeprom, .get_ringparam = tg3_get_ringparam, .set_ringparam = tg3_set_ringparam, .get_pauseparam = tg3_get_pauseparam, @@ -6831,6 +6914,103 @@ static struct ethtool_ops tg3_ethtool_op .get_ethtool_stats = tg3_get_ethtool_stats, }; +static void __devinit tg3_get_eeprom_size(struct tg3 *tp) +{ + u32 cursize, val; + + tp->nvram_size = EEPROM_CHIP_SIZE; + + if (tg3_nvram_read(tp, 0, &val) != 0) + return; + + if (swab32(val) != TG3_EEPROM_MAGIC) + return; + + /* + * Size the chip by reading offsets at increasing powers of two. + * When we encounter our validation signature, we know the addressing + * has wrapped around, and thus have our chip size. + */ + cursize = 0x800; + + while (cursize < tp->nvram_size) { + if (tg3_nvram_read(tp, cursize, &val) != 0) + return; + + if (swab32(val) == TG3_EEPROM_MAGIC) + break; + + cursize <<= 1; + } + + tp->nvram_size = cursize; +} + +static void __devinit tg3_get_nvram_size(struct tg3 *tp) +{ + u32 val; + + if (tg3_nvram_read(tp, 0xf0, &val) == 0) { + if (val != 0) { + tp->nvram_size = (val >> 16) * 1024; + return; + } + } + tp->nvram_size = 0x20000; +} + +static void __devinit tg3_get_nvram_info(struct tg3 *tp) +{ + u32 nvcfg1; + + nvcfg1 = tr32(NVRAM_CFG1); + if (nvcfg1 & NVRAM_CFG1_FLASHIF_ENAB) { + tp->tg3_flags2 |= TG3_FLG2_FLASH; + } + else { + nvcfg1 &= ~NVRAM_CFG1_COMPAT_BYPASS; + tw32(NVRAM_CFG1, nvcfg1); + } + + if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) { + switch (nvcfg1 & NVRAM_CFG1_VENDOR_MASK) { + case FLASH_VENDOR_ATMEL_FLASH_BUFFERED: + tp->nvram_jedecnum = JEDEC_ATMEL; + tp->nvram_pagesize = ATMEL_AT45DB0X1B_PAGE_SIZE; + tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED; + break; + case FLASH_VENDOR_ATMEL_FLASH_UNBUFFERED: + tp->nvram_jedecnum = JEDEC_ATMEL; + tp->nvram_pagesize = ATMEL_AT25F512_PAGE_SIZE; + break; + case FLASH_VENDOR_ATMEL_EEPROM: + tp->nvram_jedecnum = JEDEC_ATMEL; + tp->nvram_pagesize = ATMEL_AT24C512_CHIP_SIZE; + tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED; + break; + case FLASH_VENDOR_ST: + tp->nvram_jedecnum = JEDEC_ST; + tp->nvram_pagesize = ST_M45PEX0_PAGE_SIZE; + tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED; + break; + case FLASH_VENDOR_SAIFUN: + tp->nvram_jedecnum = JEDEC_SAIFUN; + tp->nvram_pagesize = SAIFUN_SA25F0XX_PAGE_SIZE; + break; + case FLASH_VENDOR_SST_SMALL: + case FLASH_VENDOR_SST_LARGE: + tp->nvram_jedecnum = JEDEC_SST; + tp->nvram_pagesize = SST_25VF0X0_PAGE_SIZE; + break; + } + } + else { + tp->nvram_jedecnum = JEDEC_ATMEL; + tp->nvram_pagesize = ATMEL_AT45DB0X1B_PAGE_SIZE; + tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED; + } +} + /* Chips other than 5700/5701 use the NVRAM for fetching info. */ static void __devinit tg3_nvram_init(struct tg3 *tp) { @@ -6855,32 +7035,27 @@ static void __devinit tg3_nvram_init(str if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700 && GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701) { - u32 nvcfg1; + tp->tg3_flags |= TG3_FLAG_NVRAM; if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) { u32 nvaccess = tr32(NVRAM_ACCESS); - tw32_f(NVRAM_ACCESS, nvaccess | ACCESS_ENABLE); + tw32(NVRAM_ACCESS, nvaccess | ACCESS_ENABLE); } - nvcfg1 = tr32(NVRAM_CFG1); - - tp->tg3_flags |= TG3_FLAG_NVRAM; - if (nvcfg1 & NVRAM_CFG1_FLASHIF_ENAB) { - if (nvcfg1 & NVRAM_CFG1_BUFFERED_MODE) - tp->tg3_flags |= TG3_FLAG_NVRAM_BUFFERED; - } else { - nvcfg1 &= ~NVRAM_CFG1_COMPAT_BYPASS; - tw32(NVRAM_CFG1, nvcfg1); - } + tg3_get_nvram_info(tp); + tg3_get_nvram_size(tp); if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) { u32 nvaccess = tr32(NVRAM_ACCESS); - tw32_f(NVRAM_ACCESS, nvaccess & ~ACCESS_ENABLE); + tw32(NVRAM_ACCESS, nvaccess & ~ACCESS_ENABLE); } + } else { tp->tg3_flags &= ~(TG3_FLAG_NVRAM | TG3_FLAG_NVRAM_BUFFERED); + + tg3_get_eeprom_size(tp); } } @@ -6918,11 +7093,30 @@ static int tg3_nvram_read_using_eeprom(s return 0; } -static int __devinit tg3_nvram_read(struct tg3 *tp, - u32 offset, u32 *val) +#define NVRAM_CMD_TIMEOUT 10000 + +static int tg3_nvram_exec_cmd(struct tg3 *tp, u32 nvram_cmd) { int i; + tw32(NVRAM_CMD, nvram_cmd); + for (i = 0; i < NVRAM_CMD_TIMEOUT; i++) { + udelay(10); + if (tr32(NVRAM_CMD) & NVRAM_CMD_DONE) { + udelay(10); + break; + } + } + if (i == NVRAM_CMD_TIMEOUT) { + return -EBUSY; + } + return 0; +} + +static int tg3_nvram_read(struct tg3 *tp, u32 offset, u32 *val) +{ + int ret; + if (tp->tg3_flags2 & TG3_FLG2_SUN_570X) { printk(KERN_ERR PFX "Attempt to do nvram_read on Sun 570X\n"); return -EINVAL; @@ -6931,10 +7125,14 @@ static int __devinit tg3_nvram_read(stru if (!(tp->tg3_flags & TG3_FLAG_NVRAM)) return tg3_nvram_read_using_eeprom(tp, offset, val); - if (tp->tg3_flags & TG3_FLAG_NVRAM_BUFFERED) - offset = ((offset / NVRAM_BUFFERED_PAGE_SIZE) << - NVRAM_BUFFERED_PAGE_POS) + - (offset % NVRAM_BUFFERED_PAGE_SIZE); + if ((tp->tg3_flags & TG3_FLAG_NVRAM_BUFFERED) && + (tp->tg3_flags2 & TG3_FLG2_FLASH) && + (tp->nvram_jedecnum == JEDEC_ATMEL)) { + + offset = ((offset / tp->nvram_pagesize) << + ATMEL_AT45DB0X1B_PAGE_POS) + + (offset % tp->nvram_pagesize); + } if (offset > NVRAM_ADDR_MSK) return -EINVAL; @@ -6948,19 +7146,11 @@ static int __devinit tg3_nvram_read(stru } tw32(NVRAM_ADDR, offset); - tw32(NVRAM_CMD, - NVRAM_CMD_RD | NVRAM_CMD_GO | - NVRAM_CMD_FIRST | NVRAM_CMD_LAST | NVRAM_CMD_DONE); + ret = tg3_nvram_exec_cmd(tp, NVRAM_CMD_RD | NVRAM_CMD_GO | + NVRAM_CMD_FIRST | NVRAM_CMD_LAST | NVRAM_CMD_DONE); - /* Wait for done bit to clear. */ - for (i = 0; i < 1000; i++) { - udelay(10); - if (tr32(NVRAM_CMD) & NVRAM_CMD_DONE) { - udelay(10); - *val = swab32(tr32(NVRAM_RDDATA)); - break; - } - } + if (ret == 0) + *val = swab32(tr32(NVRAM_RDDATA)); tg3_nvram_unlock(tp); @@ -6970,10 +7160,268 @@ static int __devinit tg3_nvram_read(stru tw32_f(NVRAM_ACCESS, nvaccess & ~ACCESS_ENABLE); } - if (i >= 1000) - return -EBUSY; + return ret; +} - return 0; +static int tg3_nvram_write_block_using_eeprom(struct tg3 *tp, + u32 offset, u32 len, u8 *buf) +{ + int i, j, rc = 0; + u32 val; + + for (i = 0; i < len; i += 4) { + u32 addr, data; + + addr = offset + i; + + memcpy(&data, buf + i, 4); + + tw32(GRC_EEPROM_DATA, cpu_to_le32(data)); + + val = tr32(GRC_EEPROM_ADDR); + tw32(GRC_EEPROM_ADDR, val | EEPROM_ADDR_COMPLETE); + + val &= ~(EEPROM_ADDR_ADDR_MASK | EEPROM_ADDR_DEVID_MASK | + EEPROM_ADDR_READ); + tw32(GRC_EEPROM_ADDR, val | + (0 << EEPROM_ADDR_DEVID_SHIFT) | + (addr & EEPROM_ADDR_ADDR_MASK) | + EEPROM_ADDR_START | + EEPROM_ADDR_WRITE); + + for (j = 0; j < 10000; j++) { + val = tr32(GRC_EEPROM_ADDR); + + if (val & EEPROM_ADDR_COMPLETE) + break; + udelay(100); + } + if (!(val & EEPROM_ADDR_COMPLETE)) { + rc = -EBUSY; + break; + } + } + + return rc; +} + +/* offset and length are dword aligned */ +static int tg3_nvram_write_block_unbuffered(struct tg3 *tp, u32 offset, u32 len, + u8 *buf) +{ + int ret = 0; + u32 pagesize = tp->nvram_pagesize; + u32 pagemask = pagesize - 1; + u32 nvram_cmd; + u8 *tmp; + + tmp = kmalloc(pagesize, GFP_KERNEL); + if (tmp == NULL) + return -ENOMEM; + + while (len) { + int j; + u32 phy_addr, page_off, size, nvaccess; + + phy_addr = offset & ~pagemask; + + for (j = 0; j < pagesize; j += 4) { + if ((ret = tg3_nvram_read(tp, phy_addr + j, + (u32 *) (tmp + j)))) + break; + } + if (ret) + break; + + page_off = offset & pagemask; + size = pagesize; + if (len < size) + size = len; + + len -= size; + + memcpy(tmp + page_off, buf, size); + + offset = offset + (pagesize - page_off); + + nvaccess = tr32(NVRAM_ACCESS); + tw32_f(NVRAM_ACCESS, nvaccess | ACCESS_ENABLE); + + /* + * Before we can erase the flash page, we need + * to issue a special "write enable" command. + */ + nvram_cmd = NVRAM_CMD_WREN | NVRAM_CMD_GO | NVRAM_CMD_DONE; + + if (tg3_nvram_exec_cmd(tp, nvram_cmd)) + break; + + /* Erase the target page */ + tw32(NVRAM_ADDR, phy_addr); + + nvram_cmd = NVRAM_CMD_GO | NVRAM_CMD_DONE | NVRAM_CMD_WR | + NVRAM_CMD_FIRST | NVRAM_CMD_LAST | NVRAM_CMD_ERASE; + + if (tg3_nvram_exec_cmd(tp, nvram_cmd)) + break; + + /* Issue another write enable to start the write. */ + nvram_cmd = NVRAM_CMD_WREN | NVRAM_CMD_GO | NVRAM_CMD_DONE; + + if (tg3_nvram_exec_cmd(tp, nvram_cmd)) + break; + + for (j = 0; j < pagesize; j += 4) { + u32 data; + + data = *((u32 *) (tmp + j)); + tw32(NVRAM_WRDATA, cpu_to_be32(data)); + + tw32(NVRAM_ADDR, phy_addr + j); + + nvram_cmd = NVRAM_CMD_GO | NVRAM_CMD_DONE | + NVRAM_CMD_WR; + + if (j == 0) + nvram_cmd |= NVRAM_CMD_FIRST; + else if (j == (pagesize - 4)) + nvram_cmd |= NVRAM_CMD_LAST; + + if ((ret = tg3_nvram_exec_cmd(tp, nvram_cmd))) + break; + } + if (ret) + break; + } + + nvram_cmd = NVRAM_CMD_WRDI | NVRAM_CMD_GO | NVRAM_CMD_DONE; + tg3_nvram_exec_cmd(tp, nvram_cmd); + + kfree(tmp); + + return ret; +} + +/* offset and length are dword aligned */ +static int tg3_nvram_write_block_buffered(struct tg3 *tp, u32 offset, u32 len, + u8 *buf) +{ + int i, ret = 0; + + for (i = 0; i < len; i += 4, offset += 4) { + u32 data, page_off, phy_addr, nvram_cmd; + + memcpy(&data, buf + i, 4); + tw32(NVRAM_WRDATA, cpu_to_be32(data)); + + page_off = offset % tp->nvram_pagesize; + + if ((tp->tg3_flags2 & TG3_FLG2_FLASH) && + (tp->nvram_jedecnum == JEDEC_ATMEL)) { + + phy_addr = ((offset / tp->nvram_pagesize) << + ATMEL_AT45DB0X1B_PAGE_POS) + page_off; + } + else { + phy_addr = offset; + } + + tw32(NVRAM_ADDR, phy_addr); + + nvram_cmd = NVRAM_CMD_GO | NVRAM_CMD_DONE | NVRAM_CMD_WR; + + if ((page_off == 0) || (i == 0)) + nvram_cmd |= NVRAM_CMD_FIRST; + else if (page_off == (tp->nvram_pagesize - 4)) + nvram_cmd |= NVRAM_CMD_LAST; + + if (i == (len - 4)) + nvram_cmd |= NVRAM_CMD_LAST; + + if ((tp->nvram_jedecnum == JEDEC_ST) && + (nvram_cmd & NVRAM_CMD_FIRST)) { + + if ((ret = tg3_nvram_exec_cmd(tp, + NVRAM_CMD_WREN | NVRAM_CMD_GO | + NVRAM_CMD_DONE))) + + break; + } + if (!(tp->tg3_flags2 & TG3_FLG2_FLASH)) { + /* We always do complete word writes to eeprom. */ + nvram_cmd |= (NVRAM_CMD_FIRST | NVRAM_CMD_LAST); + } + + if ((ret = tg3_nvram_exec_cmd(tp, nvram_cmd))) + break; + } + return ret; +} + +/* offset and length are dword aligned */ +static int tg3_nvram_write_block(struct tg3 *tp, u32 offset, u32 len, u8 *buf) +{ + int ret; + + if (tp->tg3_flags2 & TG3_FLG2_SUN_570X) { + printk(KERN_ERR PFX "Attempt to do nvram_write on Sun 570X\n"); + return -EINVAL; + } + + if (tp->tg3_flags & TG3_FLAG_EEPROM_WRITE_PROT) { + tw32_f(GRC_LOCAL_CTRL, tp->grc_local_ctrl | + GRC_LCLCTRL_GPIO_OE1); + udelay(40); + } + + if (!(tp->tg3_flags & TG3_FLAG_NVRAM)) { + ret = tg3_nvram_write_block_using_eeprom(tp, offset, len, buf); + } + else { + u32 grc_mode; + + tg3_nvram_lock(tp); + + if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) { + u32 nvaccess = tr32(NVRAM_ACCESS); + + tw32(NVRAM_ACCESS, nvaccess | ACCESS_ENABLE); + + tw32(NVRAM_WRITE1, 0x406); + } + + grc_mode = tr32(GRC_MODE); + tw32(GRC_MODE, grc_mode | GRC_MODE_NVRAM_WR_ENABLE); + + if ((tp->tg3_flags & TG3_FLAG_NVRAM_BUFFERED) || + !(tp->tg3_flags2 & TG3_FLG2_FLASH)) { + + ret = tg3_nvram_write_block_buffered(tp, offset, len, + buf); + } + else { + ret = tg3_nvram_write_block_unbuffered(tp, offset, len, + buf); + } + + grc_mode = tr32(GRC_MODE); + tw32(GRC_MODE, grc_mode & ~GRC_MODE_NVRAM_WR_ENABLE); + + if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) { + u32 nvaccess = tr32(NVRAM_ACCESS); + + tw32(NVRAM_ACCESS, nvaccess & ~ACCESS_ENABLE); + } + tg3_nvram_unlock(tp); + } + + if (tp->tg3_flags & TG3_FLAG_EEPROM_WRITE_PROT) { + tw32_f(GRC_LOCAL_CTRL, tp->grc_local_ctrl | + GRC_LCLCTRL_GPIO_OE1 | GRC_LCLCTRL_GPIO_OUTPUT1); + udelay(40); + } + + return ret; } struct subsys_tbl_ent { @@ -7047,11 +7495,19 @@ static int __devinit tg3_phy_probe(struc tg3_read_mem(tp, NIC_SRAM_DATA_SIG, &val); if (val == NIC_SRAM_DATA_SIG_MAGIC) { u32 nic_cfg, led_cfg; - u32 nic_phy_id, cfg2; + u32 nic_phy_id, ver, cfg2 = 0; tg3_read_mem(tp, NIC_SRAM_DATA_CFG, &nic_cfg); tp->nic_sram_data_cfg = nic_cfg; + tg3_read_mem(tp, NIC_SRAM_DATA_VER, &ver); + ver >>= NIC_SRAM_DATA_VER_SHIFT; + if ((GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700) && + (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701) && + (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5703) && + (ver > 0) && (ver < 0x100)) + tg3_read_mem(tp, NIC_SRAM_DATA_CFG_2, &cfg2); + eeprom_signature_found = 1; if ((nic_cfg & NIC_SRAM_DATA_CFG_PHY_TYPE_MASK) == @@ -7070,8 +7526,7 @@ static int __devinit tg3_phy_probe(struc eeprom_phy_id = 0; if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) { - tg3_read_mem(tp, NIC_SRAM_DATA_CFG_2, &led_cfg); - led_cfg &= (NIC_SRAM_DATA_CFG_LED_MODE_MASK | + led_cfg = cfg2 & (NIC_SRAM_DATA_CFG_LED_MODE_MASK | SHASTA_EXT_LED_MODE_MASK); } else led_cfg = nic_cfg & NIC_SRAM_DATA_CFG_LED_MODE_MASK; @@ -7116,9 +7571,8 @@ static int __devinit tg3_phy_probe(struc tp->pdev->subsystem_vendor == PCI_VENDOR_ID_DELL) tp->led_ctrl = LED_CTRL_MODE_PHY_2; - if (((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5703) || - (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704) || - (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705)) && + if ((GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700) && + (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701) && (nic_cfg & NIC_SRAM_DATA_CFG_EEPROM_WP)) tp->tg3_flags |= TG3_FLAG_EEPROM_WRITE_PROT; @@ -7130,9 +7584,13 @@ static int __devinit tg3_phy_probe(struc if (nic_cfg & NIC_SRAM_DATA_CFG_FIBER_WOL) tp->tg3_flags |= TG3_FLAG_SERDES_WOL_CAP; - tg3_read_mem(tp, NIC_SRAM_DATA_PHY_ID, &cfg2); if (cfg2 & (1 << 17)) tp->tg3_flags2 |= TG3_FLG2_CAPACITIVE_COUPLING; + + /* serdes signal pre-emphasis in register 0x590 set by */ + /* bootcode if bit 18 is set */ + if (cfg2 & (1 << 18)) + tp->tg3_flags2 |= TG3_FLG2_SERDES_PREEMPHASIS; } /* Reading the PHY ID register can conflict with ASF @@ -7188,9 +7646,8 @@ static int __devinit tg3_phy_probe(struc u32 bmsr, adv_reg, tg3_ctrl; tg3_readphy(tp, MII_BMSR, &bmsr); - tg3_readphy(tp, MII_BMSR, &bmsr); - - if (bmsr & BMSR_LSTATUS) + if (!tg3_readphy(tp, MII_BMSR, &bmsr) && + (bmsr & BMSR_LSTATUS)) goto skip_phy_reset; err = tg3_phy_reset(tp); @@ -7414,6 +7871,9 @@ static int __devinit tg3_get_invariants( tp->pci_hdr_type = (cacheline_sz_reg >> 16) & 0xff; tp->pci_bist = (cacheline_sz_reg >> 24) & 0xff; + if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5750) + tp->tg3_flags2 |= TG3_FLG2_HW_TSO; + if (pci_find_capability(tp->pdev, PCI_CAP_ID_EXP) != 0) tp->tg3_flags2 |= TG3_FLG2_PCI_EXPRESS; @@ -8302,11 +8762,13 @@ static int __devinit tg3_init_one(struct } #if TG3_TSO_SUPPORT != 0 - if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 || + if (tp->tg3_flags2 & TG3_FLG2_HW_TSO) { + tp->tg3_flags2 |= TG3_FLG2_TSO_CAPABLE; + } + else if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5700 || GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5701 || tp->pci_chip_rev_id == CHIPREV_ID_5705_A0 || - ((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) != 0 && - GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5750)) { + (tp->tg3_flags & TG3_FLAG_ENABLE_ASF) != 0) { tp->tg3_flags2 &= ~TG3_FLG2_TSO_CAPABLE; } else { tp->tg3_flags2 |= TG3_FLG2_TSO_CAPABLE; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/net/tg3.h linux-2.4.30-pre2/drivers/net/tg3.h --- linux-2.4.29/drivers/net/tg3.h 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/drivers/net/tg3.h 2005-02-23 07:45:55.000000000 +0000 @@ -1274,6 +1274,7 @@ #define GRC_MODE_HOST_STACKUP 0x00010000 #define GRC_MODE_HOST_SENDBDS 0x00020000 #define GRC_MODE_NO_TX_PHDR_CSUM 0x00100000 +#define GRC_MODE_NVRAM_WR_ENABLE 0x00200000 #define GRC_MODE_NO_RX_PHDR_CSUM 0x00800000 #define GRC_MODE_IRQ_ON_TX_CPU_ATTN 0x01000000 #define GRC_MODE_IRQ_ON_RX_CPU_ATTN 0x02000000 @@ -1366,6 +1367,8 @@ #define NVRAM_CMD_ERASE 0x00000040 #define NVRAM_CMD_FIRST 0x00000080 #define NVRAM_CMD_LAST 0x00000100 +#define NVRAM_CMD_WREN 0x00010000 +#define NVRAM_CMD_WRDI 0x00020000 #define NVRAM_STAT 0x00007004 #define NVRAM_WRDATA 0x00007008 #define NVRAM_ADDR 0x0000700c @@ -1375,8 +1378,18 @@ #define NVRAM_CFG1_FLASHIF_ENAB 0x00000001 #define NVRAM_CFG1_BUFFERED_MODE 0x00000002 #define NVRAM_CFG1_PASS_THRU 0x00000004 +#define NVRAM_CFG1_STATUS_BITS 0x00000070 #define NVRAM_CFG1_BIT_BANG 0x00000008 +#define NVRAM_CFG1_FLASH_SIZE 0x02000000 #define NVRAM_CFG1_COMPAT_BYPASS 0x80000000 +#define NVRAM_CFG1_VENDOR_MASK 0x03000003 +#define FLASH_VENDOR_ATMEL_EEPROM 0x02000000 +#define FLASH_VENDOR_ATMEL_FLASH_BUFFERED 0x02000003 +#define FLASH_VENDOR_ATMEL_FLASH_UNBUFFERED 0x00000003 +#define FLASH_VENDOR_ST 0x03000001 +#define FLASH_VENDOR_SAIFUN 0x01000003 +#define FLASH_VENDOR_SST_SMALL 0x00000001 +#define FLASH_VENDOR_SST_LARGE 0x02000001 #define NVRAM_CFG2 0x00007018 #define NVRAM_CFG3 0x0000701c #define NVRAM_SWARB 0x00007020 @@ -1396,15 +1409,16 @@ #define SWARB_REQ1 0x00002000 #define SWARB_REQ2 0x00004000 #define SWARB_REQ3 0x00008000 -#define NVRAM_BUFFERED_PAGE_SIZE 264 -#define NVRAM_BUFFERED_PAGE_POS 9 #define NVRAM_ACCESS 0x00007024 #define ACCESS_ENABLE 0x00000001 #define ACCESS_WR_ENABLE 0x00000002 -/* 0x7024 --> 0x7400 unused */ +#define NVRAM_WRITE1 0x00007028 +/* 0x702c --> 0x7400 unused */ /* 0x7400 --> 0x8000 unused */ +#define TG3_EEPROM_MAGIC 0x669955aa + /* 32K Window into NIC internal memory */ #define NIC_SRAM_WIN_BASE 0x00008000 @@ -1438,6 +1452,9 @@ #define NIC_SRAM_DATA_CFG_FIBER_WOL 0x00004000 #define NIC_SRAM_DATA_CFG_NO_GPIO2 0x00100000 +#define NIC_SRAM_DATA_VER 0x00000b5c +#define NIC_SRAM_DATA_VER_SHIFT 16 + #define NIC_SRAM_DATA_PHY_ID 0x00000b74 #define NIC_SRAM_DATA_PHY_ID1_MASK 0xffff0000 #define NIC_SRAM_DATA_PHY_ID2_MASK 0x0000ffff @@ -2090,6 +2107,9 @@ struct tg3 { #define TG3_FLG2_PHY_JUST_INITTED 0x00001000 #define TG3_FLG2_PHY_SERDES 0x00002000 #define TG3_FLG2_CAPACITIVE_COUPLING 0x00004000 +#define TG3_FLG2_FLASH 0x00008000 +#define TG3_FLG2_HW_TSO 0x00010000 +#define TG3_FLG2_SERDES_PREEMPHASIS 0x00020000 u32 split_mode_max_reqs; #define SPLIT_MODE_5704_MAX_REQ 3 @@ -2164,6 +2184,34 @@ struct tg3 { struct tg3_hw_stats *hw_stats; dma_addr_t stats_mapping; struct tq_struct reset_task; + + u32 nvram_size; + u32 nvram_pagesize; + u32 nvram_jedecnum; + +#define JEDEC_ATMEL 0x1f +#define JEDEC_ST 0x20 +#define JEDEC_SAIFUN 0x4f +#define JEDEC_SST 0xbf + +#define ATMEL_AT24C64_CHIP_SIZE (64 * 1024) +#define ATMEL_AT24C64_PAGE_SIZE (32) + +#define ATMEL_AT24C512_CHIP_SIZE (512 * 1024) +#define ATMEL_AT24C512_PAGE_SIZE (128) + +#define ATMEL_AT45DB0X1B_PAGE_POS 9 +#define ATMEL_AT45DB0X1B_PAGE_SIZE 264 + +#define ATMEL_AT25F512_PAGE_SIZE 256 + +#define ST_M45PEX0_PAGE_SIZE 256 + +#define SAIFUN_SA25F0XX_PAGE_SIZE 256 + +#define SST_25VF0X0_PAGE_SIZE 4098 + + }; #endif /* !(_T3_H) */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/pci/quirks.c linux-2.4.30-pre2/drivers/pci/quirks.c --- linux-2.4.29/drivers/pci/quirks.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/drivers/pci/quirks.c 2005-02-23 07:44:58.000000000 +0000 @@ -368,9 +368,6 @@ static void __init quirk_via_ioapic(stru * non-x86 architectures (yes Via exists on PPC among other places), * we must mask the PCI_INTERRUPT_LINE value versus 0xf to get * interrupts delivered properly. - * - * TODO: When we have device-specific interrupt routers, - * quirk_via_irqpic will go away from quirks. */ /* @@ -393,22 +390,6 @@ static void __init quirk_via_acpi(struct d->irq = irq; } -static void __init quirk_via_irqpic(struct pci_dev *dev) -{ - u8 irq, new_irq = dev->irq & 0xf; - - pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq); - - if (new_irq != irq) { - printk(KERN_INFO "PCI: Via IRQ fixup for %s, from %d to %d\n", - dev->slot_name, irq, new_irq); - - udelay(15); - pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq); - } -} - - /* * PIIX3 USB: We have to disable USB interrupts that are * hardwired to PIRQD# and may be shared with an @@ -639,12 +620,14 @@ static void __init quirk_disable_pxb(str * VIA northbridges care about PCI_INTERRUPT_LINE */ -int interrupt_line_quirk; +int via_interrupt_line_quirk; static void __init quirk_via_bridge(struct pci_dev *pdev) { - if(pdev->devfn == 0) - interrupt_line_quirk = 1; + if(pdev->devfn == 0) { + printk(KERN_INFO "PCI: Via IRQ fixup\n"); + via_interrupt_line_quirk = 1; + } } /* @@ -773,9 +756,6 @@ static struct pci_fixup pci_fixups[] __i #endif { PCI_FIXUP_HEADER, PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, quirk_via_acpi }, { PCI_FIXUP_HEADER, PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_acpi }, - { PCI_FIXUP_FINAL, PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, quirk_via_irqpic }, - { PCI_FIXUP_FINAL, PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irqpic }, - { PCI_FIXUP_FINAL, PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_6, quirk_via_irqpic }, { PCI_FIXUP_FINAL, PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_VIPER_7410, quirk_amd_ioapic }, { PCI_FIXUP_FINAL, PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_FE_GATE_700C, quirk_amd_ordering }, diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/scsi/ahci.c linux-2.4.30-pre2/drivers/scsi/ahci.c --- linux-2.4.29/drivers/scsi/ahci.c 2005-01-19 14:10:01.000000000 +0000 +++ linux-2.4.30-pre2/drivers/scsi/ahci.c 2005-02-23 07:46:40.000000000 +0000 @@ -248,6 +248,12 @@ static struct pci_device_id ahci_pci_tbl board_ahci }, /* ICH7 */ { PCI_VENDOR_ID_INTEL, 0x27c5, PCI_ANY_ID, PCI_ANY_ID, 0, 0, board_ahci }, /* ICH7M */ + { PCI_VENDOR_ID_INTEL, 0x27c2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, + board_ahci }, /* ICH7R */ + { PCI_VENDOR_ID_INTEL, 0x27c3, PCI_ANY_ID, PCI_ANY_ID, 0, 0, + board_ahci }, /* ICH7R */ + { PCI_VENDOR_ID_AL, 0x5288, PCI_ANY_ID, PCI_ANY_ID, 0, 0, + board_ahci }, /* ULi M5288 */ { } /* terminate list */ }; @@ -515,15 +521,6 @@ static void ahci_qc_prep(struct ata_queu ahci_fill_sg(qc); } -static inline void ahci_dma_complete (struct ata_port *ap, - struct ata_queued_cmd *qc, - int have_err) -{ - /* get drive status; clear intr; complete txn */ - ata_qc_complete(ata_qc_from_tag(ap, ap->active_tag), - have_err ? ATA_ERR : 0); -} - static void ahci_intr_error(struct ata_port *ap, u32 irq_stat) { void *mmio = ap->host_set->mmio_base; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/scsi/libata-core.c linux-2.4.30-pre2/drivers/scsi/libata-core.c --- linux-2.4.29/drivers/scsi/libata-core.c 2005-01-19 14:10:03.000000000 +0000 +++ linux-2.4.30-pre2/drivers/scsi/libata-core.c 2005-02-23 07:45:50.000000000 +0000 @@ -1699,6 +1699,69 @@ err_out: DPRINTK("EXIT\n"); } +static void ata_pr_blacklisted(struct ata_port *ap, struct ata_device *dev) +{ + printk(KERN_WARNING "ata%u: dev %u is on DMA blacklist, disabling DMA\n", + ap->id, dev->devno); +} + +static const char * ata_dma_blacklist [] = { + "WDC AC11000H", + "WDC AC22100H", + "WDC AC32500H", + "WDC AC33100H", + "WDC AC31600H", + "WDC AC32100H", + "WDC AC23200L", + "Compaq CRD-8241B", + "CRD-8400B", + "CRD-8480B", + "CRD-8482B", + "CRD-84", + "SanDisk SDP3B", + "SanDisk SDP3B-64", + "SANYO CD-ROM CRD", + "HITACHI CDR-8", + "HITACHI CDR-8335", + "HITACHI CDR-8435", + "Toshiba CD-ROM XM-6202B", + "CD-532E-A", + "E-IDE CD-ROM CR-840", + "CD-ROM Drive/F5A", + "WPI CDD-820", + "SAMSUNG CD-ROM SC-148C", + "SAMSUNG CD-ROM SC", + "SanDisk SDP3B-64", + "SAMSUNG CD-ROM SN-124", + "ATAPI CD-ROM DRIVE 40X MAXIMUM", + "_NEC DV5800A", +}; + +static int ata_dma_blacklisted(struct ata_port *ap, struct ata_device *dev) +{ + unsigned char model_num[40]; + char *s; + unsigned int len; + int i; + + ata_dev_id_string(dev->id, model_num, ATA_ID_PROD_OFS, + sizeof(model_num)); + s = &model_num[0]; + len = strnlen(s, sizeof(model_num)); + + /* ATAPI specifies that empty space is blank-filled; remove blanks */ + while ((len > 0) && (s[len - 1] == ' ')) { + len--; + s[len] = 0; + } + + for (i = 0; i < ARRAY_SIZE(ata_dma_blacklist); i++) + if (!strncmp(ata_dma_blacklist[i], s, len)) + return 1; + + return 0; +} + static unsigned int ata_get_mode_mask(struct ata_port *ap, int shift) { struct ata_device *master, *slave; @@ -1711,17 +1774,37 @@ static unsigned int ata_get_mode_mask(st if (shift == ATA_SHIFT_UDMA) { mask = ap->udma_mask; - if (ata_dev_present(master)) + if (ata_dev_present(master)) { mask &= (master->id[ATA_ID_UDMA_MODES] & 0xff); - if (ata_dev_present(slave)) + if (ata_dma_blacklisted(ap, master)) { + mask = 0; + ata_pr_blacklisted(ap, master); + } + } + if (ata_dev_present(slave)) { mask &= (slave->id[ATA_ID_UDMA_MODES] & 0xff); + if (ata_dma_blacklisted(ap, slave)) { + mask = 0; + ata_pr_blacklisted(ap, slave); + } + } } else if (shift == ATA_SHIFT_MWDMA) { mask = ap->mwdma_mask; - if (ata_dev_present(master)) + if (ata_dev_present(master)) { mask &= (master->id[ATA_ID_MWDMA_MODES] & 0x07); - if (ata_dev_present(slave)) + if (ata_dma_blacklisted(ap, master)) { + mask = 0; + ata_pr_blacklisted(ap, master); + } + } + if (ata_dev_present(slave)) { mask &= (slave->id[ATA_ID_MWDMA_MODES] & 0x07); + if (ata_dma_blacklisted(ap, slave)) { + mask = 0; + ata_pr_blacklisted(ap, slave); + } + } } else if (shift == ATA_SHIFT_PIO) { mask = ap->pio_mask; @@ -3470,32 +3553,28 @@ void ata_std_ports(struct ata_ioports *i } static struct ata_probe_ent * -ata_probe_ent_alloc(int n, struct device *dev, struct ata_port_info **port) +ata_probe_ent_alloc(struct device *dev, struct ata_port_info *port) { struct ata_probe_ent *probe_ent; - int i; - probe_ent = kmalloc(sizeof(*probe_ent) * n, GFP_KERNEL); + probe_ent = kmalloc(sizeof(*probe_ent), GFP_KERNEL); if (!probe_ent) { printk(KERN_ERR DRV_NAME "(%s): out of memory\n", pci_name(to_pci_dev(dev))); return NULL; } - memset(probe_ent, 0, sizeof(*probe_ent) * n); + memset(probe_ent, 0, sizeof(*probe_ent)); - for (i = 0; i < n; i++) { - INIT_LIST_HEAD(&probe_ent[i].node); - probe_ent[i].dev = dev; - - probe_ent[i].sht = port[i]->sht; - probe_ent[i].host_flags = port[i]->host_flags; - probe_ent[i].pio_mask = port[i]->pio_mask; - probe_ent[i].mwdma_mask = port[i]->mwdma_mask; - probe_ent[i].udma_mask = port[i]->udma_mask; - probe_ent[i].port_ops = port[i]->port_ops; + INIT_LIST_HEAD(&probe_ent->node); + probe_ent->dev = dev; - } + probe_ent->sht = port->sht; + probe_ent->host_flags = port->host_flags; + probe_ent->pio_mask = port->pio_mask; + probe_ent->mwdma_mask = port->mwdma_mask; + probe_ent->udma_mask = port->udma_mask; + probe_ent->port_ops = port->port_ops; return probe_ent; } @@ -3505,7 +3584,7 @@ struct ata_probe_ent * ata_pci_init_native_mode(struct pci_dev *pdev, struct ata_port_info **port) { struct ata_probe_ent *probe_ent = - ata_probe_ent_alloc(1, pci_dev_to_dev(pdev), port); + ata_probe_ent_alloc(pci_dev_to_dev(pdev), port[0]); if (!probe_ent) return NULL; @@ -3531,39 +3610,47 @@ ata_pci_init_native_mode(struct pci_dev return probe_ent; } -struct ata_probe_ent * -ata_pci_init_legacy_mode(struct pci_dev *pdev, struct ata_port_info **port) +static struct ata_probe_ent * +ata_pci_init_legacy_mode(struct pci_dev *pdev, struct ata_port_info **port, + struct ata_probe_ent **ppe2) { - struct ata_probe_ent *probe_ent = - ata_probe_ent_alloc(2, pci_dev_to_dev(pdev), port); + struct ata_probe_ent *probe_ent, *probe_ent2; + + probe_ent = ata_probe_ent_alloc(pci_dev_to_dev(pdev), port[0]); if (!probe_ent) return NULL; + probe_ent2 = ata_probe_ent_alloc(pci_dev_to_dev(pdev), port[1]); + if (!probe_ent2) { + kfree(probe_ent); + return NULL; + } + + probe_ent->n_ports = 1; + probe_ent->irq = 14; - probe_ent[0].n_ports = 1; - probe_ent[0].irq = 14; + probe_ent->hard_port_no = 0; + probe_ent->legacy_mode = 1; - probe_ent[0].hard_port_no = 0; - probe_ent[0].legacy_mode = 1; + probe_ent2->n_ports = 1; + probe_ent2->irq = 15; - probe_ent[1].n_ports = 1; - probe_ent[1].irq = 15; + probe_ent2->hard_port_no = 1; + probe_ent2->legacy_mode = 1; + + probe_ent->port[0].cmd_addr = 0x1f0; + probe_ent->port[0].altstatus_addr = + probe_ent->port[0].ctl_addr = 0x3f6; + probe_ent->port[0].bmdma_addr = pci_resource_start(pdev, 4); - probe_ent[1].hard_port_no = 1; - probe_ent[1].legacy_mode = 1; - - probe_ent[0].port[0].cmd_addr = 0x1f0; - probe_ent[0].port[0].altstatus_addr = - probe_ent[0].port[0].ctl_addr = 0x3f6; - probe_ent[0].port[0].bmdma_addr = pci_resource_start(pdev, 4); - - probe_ent[1].port[0].cmd_addr = 0x170; - probe_ent[1].port[0].altstatus_addr = - probe_ent[1].port[0].ctl_addr = 0x376; - probe_ent[1].port[0].bmdma_addr = pci_resource_start(pdev, 4)+8; + probe_ent2->port[0].cmd_addr = 0x170; + probe_ent2->port[0].altstatus_addr = + probe_ent2->port[0].ctl_addr = 0x376; + probe_ent2->port[0].bmdma_addr = pci_resource_start(pdev, 4)+8; - ata_std_ports(&probe_ent[0].port[0]); - ata_std_ports(&probe_ent[1].port[0]); + ata_std_ports(&probe_ent->port[0]); + ata_std_ports(&probe_ent2->port[0]); + *ppe2 = probe_ent2; return probe_ent; } @@ -3597,7 +3684,8 @@ int ata_pci_init_one (struct pci_dev *pd else port[1] = port[0]; - if ((port[0]->host_flags & ATA_FLAG_NO_LEGACY) == 0) { + if ((port[0]->host_flags & ATA_FLAG_NO_LEGACY) == 0 + && (pdev->class >> 8) == PCI_CLASS_STORAGE_IDE) { /* TODO: support transitioning to native mode? */ pci_read_config_byte(pdev, PCI_CLASS_PROG, &tmp8); mask = (1 << 2) | (1 << 0); @@ -3642,9 +3730,7 @@ int ata_pci_init_one (struct pci_dev *pd goto err_out_regions; if (legacy_mode) { - probe_ent = ata_pci_init_legacy_mode(pdev, port); - if (probe_ent) - probe_ent2 = &probe_ent[1]; + probe_ent = ata_pci_init_legacy_mode(pdev, port, &probe_ent2); } else probe_ent = ata_pci_init_native_mode(pdev, port); if (!probe_ent) { @@ -3656,17 +3742,14 @@ int ata_pci_init_one (struct pci_dev *pd spin_lock(&ata_module_lock); if (legacy_mode) { - int free = 0; if (legacy_mode & (1 << 0)) list_add_tail(&probe_ent->node, &ata_probe_list); else - free++; + kfree(probe_ent); if (legacy_mode & (1 << 1)) list_add_tail(&probe_ent2->node, &ata_probe_list); else - free++; - if (free > 1) - kfree(probe_ent); + kfree(probe_ent2); } else { list_add_tail(&probe_ent->node, &ata_probe_list); } @@ -3867,7 +3950,6 @@ EXPORT_SYMBOL_GPL(ata_scsi_simulate); #ifdef CONFIG_PCI EXPORT_SYMBOL_GPL(pci_test_config_bits); -EXPORT_SYMBOL_GPL(ata_pci_init_legacy_mode); EXPORT_SYMBOL_GPL(ata_pci_init_native_mode); EXPORT_SYMBOL_GPL(ata_pci_init_one); EXPORT_SYMBOL_GPL(ata_pci_remove_one); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/scsi/libata-scsi.c linux-2.4.30-pre2/drivers/scsi/libata-scsi.c --- linux-2.4.29/drivers/scsi/libata-scsi.c 2005-01-19 14:10:03.000000000 +0000 +++ linux-2.4.30-pre2/drivers/scsi/libata-scsi.c 2005-02-23 07:44:59.000000000 +0000 @@ -203,7 +203,7 @@ void ata_to_sense_error(struct ata_queue {0x40, MEDIUM_ERROR, 0x11, 0x04}, // Uncorrectable ECC error Unrecovered read error /* BBD - block marked bad */ {0x80, MEDIUM_ERROR, 0x11, 0x04}, // Block marked bad Medium error, unrecovered read error - {0xFF, 0xFF, 0xFF, 0xFF}, // END mark + {0xFF, 0xFF, 0xFF, 0xFF}, // END mark }; static unsigned char stat_table[][4] = { /* Must be first because BUSY means no other bits valid */ @@ -211,22 +211,22 @@ void ata_to_sense_error(struct ata_queue {0x20, HARDWARE_ERROR, 0x00, 0x00}, // Device fault {0x08, ABORTED_COMMAND, 0x47, 0x00}, // Timed out in xfer, fake parity for now {0x04, RECOVERED_ERROR, 0x11, 0x00}, // Recovered ECC error Medium error, recovered - {0xFF, 0xFF, 0xFF, 0xFF}, // END mark + {0xFF, 0xFF, 0xFF, 0xFF}, // END mark }; int i = 0; cmd->result = SAM_STAT_CHECK_CONDITION; - + /* * Is this an error we can process/parse */ - + if(drv_stat & ATA_ERR) /* Read the err bits */ err = ata_chk_err(qc->ap); /* Display the ATA level error info */ - + printk(KERN_WARNING "ata%u: status=0x%02x { ", qc->ap->id, drv_stat); if(drv_stat & 0x80) { @@ -243,7 +243,7 @@ void ata_to_sense_error(struct ata_queue if(drv_stat & 0x01) printk("Error "); } printk("}\n"); - + if(err) { printk(KERN_WARNING "ata%u: error=0x%02x { ", qc->ap->id, err); @@ -260,11 +260,11 @@ void ata_to_sense_error(struct ata_queue if(err & 0x02) printk("TrackZeroNotFound "); if(err & 0x01) printk("AddrMarkNotFound "); printk("}\n"); - + /* Should we dump sector info here too ?? */ } - - + + /* Look for err */ while(sense_table[i][0] != 0xFF) { @@ -283,7 +283,8 @@ void ata_to_sense_error(struct ata_queue /* No immediate match */ if(err) printk(KERN_DEBUG "ata%u: no sense translation for 0x%02x\n", qc->ap->id, err); - + + i = 0; /* Fall back to interpreting status bits */ while(stat_table[i][0] != 0xFF) { @@ -301,7 +302,7 @@ void ata_to_sense_error(struct ata_queue /* No error ?? */ printk(KERN_ERR "ata%u: called with no error (%02X)!\n", qc->ap->id, drv_stat); /* additional-sense-code[-qualifier] */ - + sb[0] = 0x70; sb[2] = MEDIUM_ERROR; sb[7] = 0x0A; @@ -449,19 +450,24 @@ static unsigned int ata_scsi_verify_xlat } if (lba48) { + tf->command = ATA_CMD_VERIFY_EXT; + tf->hob_nsect = (n_sect >> 8) & 0xff; tf->hob_lbah = (sect >> 40) & 0xff; tf->hob_lbam = (sect >> 32) & 0xff; tf->hob_lbal = (sect >> 24) & 0xff; - } else + } else { + tf->command = ATA_CMD_VERIFY; + tf->device |= (sect >> 24) & 0xf; + } tf->nsect = n_sect & 0xff; - tf->hob_lbah = (sect >> 16) & 0xff; - tf->hob_lbam = (sect >> 8) & 0xff; - tf->hob_lbal = sect & 0xff; + tf->lbah = (sect >> 16) & 0xff; + tf->lbam = (sect >> 8) & 0xff; + tf->lbal = sect & 0xff; return 0; } @@ -561,7 +567,7 @@ static unsigned int ata_scsi_rw_xlat(str return 1; /* stores LBA27:24 in lower 4 bits of device reg */ - tf->device |= scsicmd[2]; + tf->device |= scsicmd[6]; qc->nsect = scsicmd[13]; } diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/scsi/megaraid2.c linux-2.4.30-pre2/drivers/scsi/megaraid2.c --- linux-2.4.29/drivers/scsi/megaraid2.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/drivers/scsi/megaraid2.c 2005-02-23 07:45:00.000000000 +0000 @@ -14,7 +14,7 @@ * - speed-ups (list handling fixes, issued_list, optimizations.) * - lots of cleanups. * - * Version : v2.10.3 (Apr 08, 2004) + * Version : v2.10.8.2 (July 26, 2004) * * Authors: Atul Mukker * Sreenivas Bagalkote @@ -46,7 +46,7 @@ #include "megaraid2.h" -#ifdef LSI_CONFIG_COMPAT +#if defined(__x86_64__) #include #endif @@ -90,10 +90,15 @@ static struct notifier_block mega_notifi static struct mega_hbas mega_hbas[MAX_CONTROLLERS]; /* + * Lock to protect access to IOCTL + */ +static struct semaphore megaraid_ioc_mtx; + +/* * The File Operations structure for the serial/ioctl interface of the driver */ static struct file_operations megadev_fops = { - .ioctl = megadev_ioctl, + .ioctl = megadev_ioctl_entry, .open = megadev_open, .release = megadev_close, .owner = THIS_MODULE, @@ -107,7 +112,7 @@ static struct file_operations megadev_fo static struct mcontroller mcontroller[MAX_CONTROLLERS]; /* The current driver version */ -static u32 driver_ver = 0x02100000; +static u32 driver_ver = 0x02104000; /* major number used by the device for character interface */ static int major; @@ -189,6 +194,11 @@ megaraid_detect(Scsi_Host_Template *host */ mega_reorder_hosts(); + /* + * Initialize the IOCTL lock + */ + init_MUTEX( &megaraid_ioc_mtx ); + #ifdef CONFIG_PROC_FS mega_proc_dir_entry = proc_mkdir("megaraid", &proc_root); @@ -223,7 +233,7 @@ megaraid_detect(Scsi_Host_Template *host "MegaRAID Shutdown routine not registered!!\n"); } -#ifdef LSI_CONFIG_COMPAT +#if defined(__x86_64__) /* * Register the 32-bit ioctl conversion */ @@ -273,6 +283,8 @@ mega_find_card(Scsi_Host_Template *host_ unsigned long tbase; unsigned long flag = 0; int i, j; + u8 did_int_pthru_f = 0; + u8 did_int_data_f = 0; while((pdev = pci_find_device(pci_vendor, pci_device, pdev))) { @@ -328,6 +340,7 @@ mega_find_card(Scsi_Host_Template *host_ (subsysvid != HP_SUBSYS_VID) && (subsysvid != INTEL_SUBSYS_VID) && (subsysvid != FSC_SUBSYS_VID) && + (subsysvid != ACER_SUBSYS_VID) && (subsysvid != LSI_SUBSYS_VID) ) continue; @@ -465,6 +478,33 @@ mega_find_card(Scsi_Host_Template *host_ alloc_scb_f = 1; + /* + * Allocate memory for ioctls + */ + adapter->int_pthru = pci_alloc_consistent ( + adapter->dev, + sizeof(mega_passthru), + &adapter->int_pthru_dma_hndl ); + + if( adapter->int_pthru == NULL ) { + printk(KERN_WARNING "megaraid: out of RAM.\n"); + goto fail_attach; + } + else + did_int_pthru_f = 1; + + adapter->int_data = pci_alloc_consistent ( + adapter->dev, + INT_MEMBLK_SZ, + &adapter->int_data_dma_hndl ); + + if( adapter->int_data == NULL ) { + printk(KERN_WARNING "megaraid: out of RAM.\n"); + goto fail_attach; + } + else + did_int_data_f = 1; + /* Request our IRQ */ if( adapter->flag & BOARD_MEMMAP ) { if(request_irq(irq, megaraid_isr_memmapped, SA_SHIRQ, @@ -676,6 +716,19 @@ mega_find_card(Scsi_Host_Template *host_ continue; fail_attach: + if( did_int_data_f ) { + pci_free_consistent( + adapter->dev, INT_MEMBLK_SZ, adapter->int_data, + adapter->int_data_dma_hndl ); + } + + if( did_int_pthru_f ) { + pci_free_consistent( + adapter->dev, sizeof(mega_passthru), + (void*) adapter->int_pthru, + adapter->int_pthru_dma_hndl ); + } + if( did_setup_mbox_f ) { pci_free_consistent(adapter->dev, sizeof(mbox64_t), (void *)adapter->una_mbox64, @@ -937,6 +990,78 @@ mega_query_adapter(adapter_t *adapter) /** + * issue_scb() + * @adapter - pointer to our soft state + * @scb - scsi control block + * + * Post a command to the card if the mailbox is available, otherwise return + * busy. We also take the scb from the pending list if the mailbox is + * available. + */ +static inline int +issue_scb(adapter_t *adapter, scb_t *scb) +{ + volatile mbox64_t *mbox64 = adapter->mbox64; + volatile mbox_t *mbox = adapter->mbox; + unsigned int i = 0; + + if(unlikely(mbox->busy)) { + do { + udelay(1); + i++; + } while( mbox->busy && (i < max_mbox_busy_wait) ); + + if(mbox->busy) return -1; + } + + /* Copy mailbox data into host structure */ + memcpy((char *)mbox, (char *)scb->raw_mbox, 16); + + mbox->cmdid = scb->idx; /* Set cmdid */ + mbox->busy = 1; /* Set busy */ + + + /* + * Increment the pending queue counter + */ + atomic_inc(&adapter->pend_cmds); + + switch (mbox->cmd) { + case MEGA_MBOXCMD_EXTPTHRU: + if( !adapter->has_64bit_addr ) break; + // else fall through + case MEGA_MBOXCMD_LREAD64: + case MEGA_MBOXCMD_LWRITE64: + case MEGA_MBOXCMD_PASSTHRU64: + mbox64->xfer_segment_lo = mbox->xferaddr; + mbox64->xfer_segment_hi = 0; + mbox->xferaddr = 0xFFFFFFFF; + break; + default: + mbox64->xfer_segment_lo = 0; + mbox64->xfer_segment_hi = 0; + } + + /* + * post the command + */ + scb->state |= SCB_ISSUED; + + if( likely(adapter->flag & BOARD_MEMMAP) ) { + mbox->poll = 0; + mbox->ack = 0; + WRINDOOR(adapter, adapter->mbox_dma | 0x1); + } + else { + irq_enable(adapter); + issue_command(adapter); + } + + return 0; +} + + +/** * mega_runpendq() * @adapter - pointer to our soft state * @@ -949,52 +1074,26 @@ mega_runpendq(adapter_t *adapter) __mega_runpendq(adapter); } -/* - * megaraid_queue() - * @scmd - Issue this scsi command - * @done - the callback hook into the scsi mid-layer - * - * The command queuing entry point for the mid-layer. - */ -static int -megaraid_queue(Scsi_Cmnd *scmd, void (*done)(Scsi_Cmnd *)) -{ - adapter_t *adapter; - scb_t *scb; - int busy=0; - - adapter = (adapter_t *)scmd->host->hostdata; - - scmd->scsi_done = done; +static void +__mega_runpendq(adapter_t *adapter) +{ + scb_t *scb; + struct list_head *pos, *next; - /* - * Allocate and build a SCB request - * busy flag will be set if mega_build_cmd() command could not - * allocate scb. We will return non-zero status in that case. - * NOTE: scb can be null even though certain commands completed - * successfully, e.g., MODE_SENSE and TEST_UNIT_READY, we would - * return 0 in that case. - */ + /* Issue any pending commands to the card */ + list_for_each_safe(pos, next, &adapter->pending_list) { - scb = mega_build_cmd(adapter, scmd, &busy); + scb = list_entry(pos, scb_t, list); - if(scb) { - scb->state |= SCB_PENDQ; - list_add_tail(&scb->list, &adapter->pending_list); + if( !(scb->state & SCB_ISSUED) ) { - /* - * Check if the HBA is in quiescent state, e.g., during a - * delete logical drive opertion. If it is, don't run - * the pending_list. - */ - if(atomic_read(&adapter->quiescent) == 0) { - mega_runpendq(adapter); + if( issue_scb(adapter, scb) != 0 ) + return; } - return 0; } - return busy; + return; } @@ -1068,25 +1167,136 @@ mega_get_ldrv_num(adapter_t *adapter, Sc } /* - * If "delete logical drive" feature is enabled on this controller. - * Do only if at least one delete logical drive operation was done. - * - * Also, after logical drive deletion, instead of logical drive number, + * If "delete logical drive" feature is enabled on this controller, * the value returned should be 0x80+logical drive id. - * - * These is valid only for IO commands. */ + if (adapter->support_random_del) + ldrv_num += 0x80; - if (adapter->support_random_del && adapter->read_ldidmap ) - switch (cmd->cmnd[0]) { - case READ_6: /* fall through */ - case WRITE_6: /* fall through */ - case READ_10: /* fall through */ - case WRITE_10: - ldrv_num += 0x80; + return ldrv_num; +} + +/* + * Wait until the controller's mailbox is available + */ +static inline int +mega_busywait_mbox (adapter_t *adapter) +{ + if (adapter->mbox->busy) + return __mega_busywait_mbox(adapter); + return 0; +} + + +/** + * megaraid_iombox_ack_sequence - interrupt ack sequence for IO mapped HBAs + * @adapter - controller's soft state + * + * Interrupt ackrowledgement sequence for IO mapped HBAs + */ +static inline void +megaraid_iombox_ack_sequence(adapter_t *adapter) +{ + u8 status; + u8 nstatus; + u8 completed[MAX_FIRMWARE_STATUS]; + u8 byte; + int i; + + + /* + * loop till F/W has more commands for us to complete. + */ + do { + /* Check if a valid interrupt is pending */ + byte = irq_state(adapter); + if( (byte & VALID_INTR_BYTE) == 0 ) { + return; } + set_irq_state(adapter, byte); - return ldrv_num; + while ((nstatus = adapter->mbox->numstatus) == 0xFF) { + cpu_relax(); + } + adapter->mbox->numstatus = 0xFF; + + for (i = 0; i < nstatus; i++) { + while ((completed[i] = adapter->mbox->completed[i]) + == 0xFF) { + cpu_relax(); + } + + adapter->mbox->completed[i] = 0xFF; + } + + // we must read the valid status now + if ((status = adapter->mbox->status) == 0xFF) { + printk(KERN_WARNING + "megaraid critical: status 0xFF from firmware.\n"); + } + adapter->mbox->status = 0xFF; + + /* + * decrement the pending queue counter + */ + atomic_sub(nstatus, &adapter->pend_cmds); + + /* Acknowledge interrupt */ + irq_ack(adapter); + + mega_cmd_done(adapter, completed, nstatus, status); + + } while(1); +} + + + +/* + * megaraid_queue() + * @scmd - Issue this scsi command + * @done - the callback hook into the scsi mid-layer + * + * The command queuing entry point for the mid-layer. + */ +static int +megaraid_queue(Scsi_Cmnd *scmd, void (*done)(Scsi_Cmnd *)) +{ + adapter_t *adapter; + scb_t *scb; + int busy=0; + + adapter = (adapter_t *)scmd->host->hostdata; + + scmd->scsi_done = done; + + + /* + * Allocate and build a SCB request + * busy flag will be set if mega_build_cmd() command could not + * allocate scb. We will return non-zero status in that case. + * NOTE: scb can be null even though certain commands completed + * successfully, e.g., MODE_SENSE and TEST_UNIT_READY, we would + * return 0 in that case. + */ + + scb = mega_build_cmd(adapter, scmd, &busy); + + if(scb) { + scb->state |= SCB_PENDQ; + list_add_tail(&scb->list, &adapter->pending_list); + + /* + * Check if the HBA is in quiescent state, e.g., during a + * delete logical drive opertion. If it is, don't run + * the pending_list. + */ + if(atomic_read(&adapter->quiescent) == 0) { + mega_runpendq(adapter); + } + return 0; + } + + return busy; } @@ -1112,7 +1322,6 @@ mega_build_cmd(adapter_t *adapter, Scsi_ mbox_t *mbox; long seg; char islogical; - int max_ldrv_num; int channel = 0; int target = 0; int ldrv_num = 0; /* logical drive number */ @@ -1184,24 +1393,6 @@ mega_build_cmd(adapter_t *adapter, Scsi_ } ldrv_num = mega_get_ldrv_num(adapter, cmd, channel); - - - max_ldrv_num = (adapter->flag & BOARD_40LD) ? - MAX_LOGICAL_DRIVES_40LD : MAX_LOGICAL_DRIVES_8LD; - - /* - * max_ldrv_num increases by 0x80 if some logical drive was - * deleted. - */ - if(adapter->read_ldidmap) - max_ldrv_num += 0x80; - - if(ldrv_num > max_ldrv_num ) { - cmd->result = (DID_BAD_TARGET << 16); - cmd->scsi_done(cmd); - return NULL; - } - } else { if( cmd->lun > 7) { @@ -1671,111 +1862,6 @@ mega_prepare_extpassthru(adapter_t *adap } -static void -__mega_runpendq(adapter_t *adapter) -{ - scb_t *scb; - struct list_head *pos, *next; - - /* Issue any pending commands to the card */ - list_for_each_safe(pos, next, &adapter->pending_list) { - - scb = list_entry(pos, scb_t, list); - - if( !(scb->state & SCB_ISSUED) ) { - - if( issue_scb(adapter, scb) != 0 ) - return; - } - } - - return; -} - - -/** - * issue_scb() - * @adapter - pointer to our soft state - * @scb - scsi control block - * - * Post a command to the card if the mailbox is available, otherwise return - * busy. We also take the scb from the pending list if the mailbox is - * available. - */ -static int -issue_scb(adapter_t *adapter, scb_t *scb) -{ - volatile mbox64_t *mbox64 = adapter->mbox64; - volatile mbox_t *mbox = adapter->mbox; - unsigned int i = 0; - - if(unlikely(mbox->busy)) { - do { - udelay(1); - i++; - } while( mbox->busy && (i < max_mbox_busy_wait) ); - - if(mbox->busy) return -1; - } - - /* Copy mailbox data into host structure */ - memcpy((char *)mbox, (char *)scb->raw_mbox, 16); - - mbox->cmdid = scb->idx; /* Set cmdid */ - mbox->busy = 1; /* Set busy */ - - - /* - * Increment the pending queue counter - */ - atomic_inc(&adapter->pend_cmds); - - switch (mbox->cmd) { - case MEGA_MBOXCMD_EXTPTHRU: - if( !adapter->has_64bit_addr ) break; - // else fall through - case MEGA_MBOXCMD_LREAD64: - case MEGA_MBOXCMD_LWRITE64: - case MEGA_MBOXCMD_PASSTHRU64: - mbox64->xfer_segment_lo = mbox->xferaddr; - mbox64->xfer_segment_hi = 0; - mbox->xferaddr = 0xFFFFFFFF; - break; - default: - mbox64->xfer_segment_lo = 0; - mbox64->xfer_segment_hi = 0; - } - - /* - * post the command - */ - scb->state |= SCB_ISSUED; - - if( likely(adapter->flag & BOARD_MEMMAP) ) { - mbox->poll = 0; - mbox->ack = 0; - WRINDOOR(adapter, adapter->mbox_dma | 0x1); - } - else { - irq_enable(adapter); - issue_command(adapter); - } - - return 0; -} - - -/* - * Wait until the controller's mailbox is available - */ -static inline int -mega_busywait_mbox (adapter_t *adapter) -{ - if (adapter->mbox->busy) - return __mega_busywait_mbox(adapter); - return 0; -} - /** * issue_scb_block() * @adapter - pointer to our soft state @@ -1865,77 +1951,47 @@ issue_scb_block(adapter_t *adapter, u_ch // invalidate the completed command id array. After command // completion, firmware would write the valid id. for (i = 0; i < MAX_FIRMWARE_STATUS; i++) { - mbox->completed[i] = 0xFF; - } - - return status; - -bug_blocked_mailbox: - printk(KERN_WARNING "megaraid: Blocked mailbox......!!\n"); - udelay (1000); - return -1; -} - - -/** - * megaraid_iombox_ack_sequence - interrupt ack sequence for IO mapped HBAs - * @adapter - controller's soft state - * - * Interrupt ackrowledgement sequence for IO mapped HBAs - */ -static inline void -megaraid_iombox_ack_sequence(adapter_t *adapter) -{ - u8 status; - u8 nstatus; - u8 completed[MAX_FIRMWARE_STATUS]; - u8 byte; - int i; - - - /* - * loop till F/W has more commands for us to complete. - */ - do { - /* Check if a valid interrupt is pending */ - byte = irq_state(adapter); - if( (byte & VALID_INTR_BYTE) == 0 ) { - return; - } - set_irq_state(adapter, byte); + mbox->completed[i] = 0xFF; + } - while ((nstatus = adapter->mbox->numstatus) == 0xFF) { - cpu_relax(); - } - adapter->mbox->numstatus = 0xFF; + return status; - for (i = 0; i < nstatus; i++) { - while ((completed[i] = adapter->mbox->completed[i]) - == 0xFF) { - cpu_relax(); - } +bug_blocked_mailbox: + printk(KERN_WARNING "megaraid: Blocked mailbox......!!\n"); + udelay (1000); + return -1; +} - adapter->mbox->completed[i] = 0xFF; - } - // we must read the valid status now - if ((status = adapter->mbox->status) == 0xFF) { - printk(KERN_WARNING - "megaraid critical: status 0xFF from firmware.\n"); - } - adapter->mbox->status = 0xFF; +/** + * megaraid_isr_iomapped() + * @irq - irq + * @devp - pointer to our soft state + * @regs - unused + * + * Interrupt service routine for io-mapped controllers. + * Find out if our device is interrupting. If yes, acknowledge the interrupt + * and service the completed commands. + */ +static void +megaraid_isr_iomapped(int irq, void *devp, struct pt_regs *regs) +{ + adapter_t *adapter = devp; + unsigned long flags; - /* - * decrement the pending queue counter - */ - atomic_sub(nstatus, &adapter->pend_cmds); - /* Acknowledge interrupt */ - irq_ack(adapter); + spin_lock_irqsave(adapter->host_lock, flags); - mega_cmd_done(adapter, completed, nstatus, status); + megaraid_iombox_ack_sequence(adapter); - } while(1); + /* Loop through any pending requests */ + if( atomic_read(&adapter->quiescent ) == 0) { + mega_runpendq(adapter); + } + + spin_unlock_irqrestore(adapter->host_lock, flags); + + return; } @@ -2007,38 +2063,6 @@ megaraid_memmbox_ack_sequence(adapter_t /** - * megaraid_isr_iomapped() - * @irq - irq - * @devp - pointer to our soft state - * @regs - unused - * - * Interrupt service routine for io-mapped controllers. - * Find out if our device is interrupting. If yes, acknowledge the interrupt - * and service the completed commands. - */ -static void -megaraid_isr_iomapped(int irq, void *devp, struct pt_regs *regs) -{ - adapter_t *adapter = devp; - unsigned long flags; - - - spin_lock_irqsave(adapter->host_lock, flags); - - megaraid_iombox_ack_sequence(adapter); - - /* Loop through any pending requests */ - if( atomic_read(&adapter->quiescent ) == 0) { - mega_runpendq(adapter); - } - - spin_unlock_irqrestore(adapter->host_lock, flags); - - return; -} - - -/** * megaraid_isr_memmapped() * @irq - irq * @devp - pointer to our soft state @@ -2069,7 +2093,6 @@ megaraid_isr_memmapped(int irq, void *de return; } - /** * mega_cmd_done() * @adapter - pointer to our soft state @@ -2381,7 +2404,6 @@ mega_free_scb(adapter_t *adapter, scb_t list_add(&scb->list, &adapter->free_list); } - static int __mega_busywait_mbox (adapter_t *adapter) { @@ -2412,6 +2434,10 @@ mega_build_sglist(adapter_t *adapter, sc cmd = scb->cmd; + /* return 0 elements if no data transfer */ + if (!cmd->request_buffer || !cmd->request_bufflen) + return 0; + /* Scatter-gather not used */ if( !cmd->use_sg ) { @@ -2535,7 +2561,6 @@ mega_8_to_40ld(mraid_inquiry *inquiry, m enquiry3->pdrv_state[i] = inquiry->pdrv_info.pdrv_state[i]; } - static inline void mega_free_sgl(adapter_t *adapter) { @@ -2666,6 +2691,13 @@ megaraid_release(struct Scsi_Host *host) pci_free_consistent(adapter->dev, sizeof(mbox64_t), (void *)adapter->una_mbox64, adapter->una_mbox64_dma); + pci_free_consistent( adapter->dev, sizeof(mega_passthru), + (void*) adapter->int_pthru, + adapter->int_pthru_dma_hndl ); + + pci_free_consistent( adapter->dev, INT_MEMBLK_SZ, adapter->int_data, + adapter->int_data_dma_hndl ); + hba_count--; if( hba_count == 0 ) { @@ -2694,7 +2726,7 @@ megaraid_release(struct Scsi_Host *host) */ scsi_unregister(host); -#ifdef LSI_CONFIG_COMPAT +#if defined(__x86_64__) unregister_ioctl32_conversion(MEGAIOCCMD); #endif @@ -2736,30 +2768,36 @@ megaraid_command (Scsi_Cmnd *cmd) } -/** - * megaraid_abort - abort the scsi command - * @scp - command to be aborted - * - * Abort a previous SCSI request. Only commands on the pending list can be - * aborted. All the commands issued to the F/W must complete. - */ static int megaraid_abort(Scsi_Cmnd *scp) { adapter_t *adapter; struct list_head *pos, *next; scb_t *scb; - long iter; - int rval = SUCCESS; + + printk("megaraid: aborting-%ld cmd=%x \n", + scp->serial_number, scp->cmnd[0], scp->channel, + scp->target, scp->lun); adapter = (adapter_t *)scp->host->hostdata; - ASSERT( spin_is_locked(adapter->host_lock) ); + /* + * Check if hw_error flag was set in previous RESET call. If it was, + * then FW is hanging and unlikely to function. We can return FAILURE + * from here and expect the RESET handler to be called. + */ - printk("megaraid: aborting-%ld cmd=%x \n", - scp->serial_number, scp->cmnd[0], scp->channel, scp->target, - scp->lun); + if (adapter->hw_error) { + printk("megaraid: hw error, cannot abort\n"); + return FAILED; + } + + ASSERT( spin_is_locked(adapter->host_lock) ); + /* + * If cmd is waiting to be issued to FW, ABORT it with SUCEESS. If it + * has already been issued, return FAILURE and expect RESET later. + */ list_for_each_safe( pos, next, &adapter->pending_list ) { @@ -2769,15 +2807,11 @@ megaraid_abort(Scsi_Cmnd *scp) scb->state |= SCB_ABORT; - /* - * Check if this command was never issued. If this is - * the case, take it off from the pending list and - * complete. - */ if( !(scb->state & SCB_ISSUED) ) { - printk(KERN_WARNING - "megaraid: %ld:%d, driver owner.\n", + /* Not issued to the FW yet; ABORT it */ + + printk( "megaraid: %ld:%d, driver owner.\n", scp->serial_number, scb->idx); scp->result = (DID_ABORT << 16); @@ -2786,67 +2820,31 @@ megaraid_abort(Scsi_Cmnd *scp) scp->scsi_done(scp); - break; + return SUCCESS; + } + else { + /* Issued to the FW; can do nothing */ + return FAILED; } } } /* - * By this time, either all commands are completed or aborted by - * mid-layer. Do not return until all the commands are actually - * completed by the firmware + * cmd is _not_ in our pending_list. Most likely we completed the cmd */ - iter = 0; - while( atomic_read(&adapter->pend_cmds) > 0 ) { - /* - * Perform the ack sequence, since interrupts are not - * available right now! - */ - if( adapter->flag & BOARD_MEMMAP ) { - megaraid_memmbox_ack_sequence(adapter); - } - else { - megaraid_iombox_ack_sequence(adapter); - } - - /* - * print a message once every second only - */ - if( !(iter % 1000) ) { - printk( - "megaraid: Waiting for %d commands to flush: iter:%ld\n", - atomic_read(&adapter->pend_cmds), iter); - } - - if( iter++ < MBOX_ABORT_SLEEP*1000 ) { - mdelay(1); - } - else { - printk(KERN_WARNING - "megaraid: critical hardware error!\n"); - - rval = FAILED; - - break; - } - } - - if( rval == SUCCESS ) { - printk(KERN_INFO - "megaraid: abort sequence successfully completed.\n"); - } - - return rval; + return SUCCESS; } static int megaraid_reset(Scsi_Cmnd *cmd) { - adapter_t *adapter; - megacmd_t mc; - long iter; - int rval = SUCCESS; + DECLARE_WAIT_QUEUE_HEAD(wq); + int i; + scb_t *scb; + adapter_t *adapter; + struct list_head *pos, *next; + int rval; adapter = (adapter_t *)cmd->host->hostdata; @@ -2856,31 +2854,54 @@ megaraid_reset(Scsi_Cmnd *cmd) cmd->serial_number, cmd->cmnd[0], cmd->channel, cmd->target, cmd->lun); + /* + * Check if hw_error flag was set in previous RESET call. If it was, + * then we needn't do any handling here. The controller will be marked + * offline soon + */ -#if MEGA_HAVE_CLUSTERING - mc.cmd = MEGA_CLUSTER_CMD; - mc.opcode = MEGA_RESET_RESERVATIONS; - - spin_unlock_irq(adapter->host_lock); - if( mega_internal_command(adapter, LOCK_INT, &mc, NULL) != 0 ) { - printk(KERN_WARNING - "megaraid: reservation reset failed.\n"); + if (adapter->hw_error) { + printk("megaraid: hw error, cannot reset\n"); + return FAILED; } - else { - printk(KERN_INFO "megaraid: reservation reset.\n"); + + /* + * Return all the pending cmds to the mid-layer with the cmd result + * DID_RESET. Make sure you don't return the cmds ISSUED to FW. + */ + list_for_each_safe( pos, next, &adapter->pending_list ) { + + scb = list_entry(pos, scb_t, list); + scb->state |= SCB_RESET; + + if( !(scb->state & SCB_ISSUED) ) { + + /* Not issued to the FW; return with RESET */ + cmd->result = (DID_RESET << 16); + + mega_free_scb(adapter, scb); + cmd->scsi_done(cmd); + } } - spin_lock_irq(adapter->host_lock); -#endif /* - * Do not return until all the commands are actually completed by the - * firmware + * Under exceptional conditions, FW may take up to 3 mins to complete + * processing all pending commands. We'll wait for maximum 3 mins to + * see if all outstanding commands are completed. */ - iter = 0; - while( atomic_read(&adapter->pend_cmds) > 0 ) { + + if (atomic_read(&adapter->pend_cmds) == 0) + return SUCCESS; + + printk("megaraid: %d pending cmds; max wait %d seconds\n", + atomic_read(&adapter->pend_cmds), MBOX_RESET_WAIT ); + + for(i=0; (ipend_cmds)); i++){ + + ASSERT( spin_is_locked(adapter->host_lock) ); + /* - * Perform the ack sequence, since interrupts are not - * available right now! + * Perform the ack sequence, since interrupts are unavailable */ if( adapter->flag & BOARD_MEMMAP ) { megaraid_memmbox_ack_sequence(adapter); @@ -2889,55 +2910,35 @@ megaraid_reset(Scsi_Cmnd *cmd) megaraid_iombox_ack_sequence(adapter); } - /* - * print a message once every second only - */ - if( !(iter % 1000) ) { - printk( - "megaraid: Waiting for %d commands to flush: iter:%ld\n", - atomic_read(&adapter->pend_cmds), iter); - } + spin_unlock(adapter->host_lock); - if( iter++ < MBOX_RESET_SLEEP*1000 ) { - mdelay(1); + /* Print a message once every 5 seconds */ + if (!(i % 5)) { + printk("megaraid: pending %d; remaining %d seconds\n", + atomic_read(&adapter->pend_cmds), + MBOX_RESET_WAIT - i); } - else { - printk(KERN_WARNING - "megaraid: critical hardware error!\n"); - rval = FAILED; - - break; - } - } + sleep_on_timeout(&wq, HZ); - if( rval == SUCCESS ) { - printk(KERN_INFO - "megaraid: reset sequence successfully completed.\n"); + spin_lock(adapter->host_lock); } - return rval; -} - + /* + * If after 3 mins there are still outstanding cmds, set the hw_error + * flag so that we can return from subsequent ABORT/RESET handlers + * without any processing + */ -/** - * mega_allocate_inquiry() - * @dma_handle - handle returned for dma address - * @pdev - handle to pci device - * - * allocates memory for inquiry structure - */ -static inline caddr_t -mega_allocate_inquiry(dma_addr_t *dma_handle, struct pci_dev *pdev) -{ - return pci_alloc_consistent(pdev, sizeof(mega_inquiry3), dma_handle); -} + rval = SUCCESS; + if (atomic_read(&adapter->pend_cmds)) { + adapter->hw_error = 1; + printk("megaraid: critical hardware error!\n" ); + rval = FAILED; + } -static inline void -mega_free_inquiry(caddr_t inquiry, dma_addr_t dma_handle, struct pci_dev *pdev) -{ - pci_free_consistent(pdev, sizeof(mega_inquiry3), inquiry, dma_handle); + return rval; } @@ -3199,6 +3200,26 @@ proc_read_mbox(char *page, char **start, return len; } +/** + * mega_allocate_inquiry() + * @dma_handle - handle returned for dma address + * @pdev - handle to pci device + * + * allocates memory for inquiry structure + */ +static inline caddr_t +mega_allocate_inquiry(dma_addr_t *dma_handle, struct pci_dev *pdev) +{ + return pci_alloc_consistent(pdev, sizeof(mega_inquiry3), dma_handle); +} + + +static inline void +mega_free_inquiry(caddr_t inquiry, dma_addr_t dma_handle, struct pci_dev *pdev) +{ + pci_free_consistent(pdev, sizeof(mega_inquiry3), inquiry, dma_handle); +} + /** * proc_rebuild_rate() @@ -3988,6 +4009,7 @@ static int megaraid_reboot_notify (struct notifier_block *this, unsigned long code, void *unused) { + DECLARE_WAIT_QUEUE_HEAD(wq); adapter_t *adapter; struct Scsi_Host *host; u8 raw_mbox[sizeof(mbox_t)]; @@ -4040,10 +4062,10 @@ megaraid_reboot_notify (struct notifier_ printk(KERN_INFO "megaraid: cache flush delay: "); for( i = 9; i >= 0; i-- ) { printk("\b\b\b[%d]", i); - mdelay(1000); + sleep_on_timeout(&wq, HZ); } printk("\b\b\b[done]\n"); - mdelay(1000); + sleep_on_timeout(&wq, HZ); return NOTIFY_DONE; } @@ -4150,17 +4172,27 @@ megadev_open (struct inode *inode, struc } -#ifdef LSI_CONFIG_COMPAT +#if defined(__x86_64__) static int megadev_compat_ioctl(unsigned int fd, unsigned int cmd, unsigned long arg, struct file *filep) { struct inode *inode = filep->f_dentry->d_inode; - return megadev_ioctl(inode, filep, cmd, arg); + return megadev_ioctl_entry(inode, filep, cmd, arg); } #endif +static int +megadev_ioctl_entry(struct inode *inode, struct file *filep, unsigned int cmd, + unsigned long arg) +{ + int rval; + down( &megaraid_ioc_mtx ); + rval = megadev_ioctl( inode, filep, cmd, arg ); + up( &megaraid_ioc_mtx ); + return rval; +} /** * megadev_ioctl() @@ -4184,9 +4216,8 @@ megadev_ioctl(struct inode *inode, struc int rval; mega_passthru *upthru; /* user address for passthru */ mega_passthru *pthru; /* copy user passthru here */ - dma_addr_t pthru_dma_hndl; void *data = NULL; /* data to be transferred */ - dma_addr_t data_dma_hndl; /* dma handle for data xfer area */ + dma_addr_t data_dma_hndl = 0; megacmd_t mc; megastat_t *ustats; int num_ldrv; @@ -4302,7 +4333,7 @@ megadev_ioctl(struct inode *inode, struc /* * Which adapter */ - if( (adapno = GETADAP(uioc.adapno)) >= hba_count ) + if( (adapno = GETADAP(uioc.adapno)) >= hba_count ) return (-ENODEV); adapter = hba_soft_state[adapno]; @@ -4358,13 +4389,7 @@ megadev_ioctl(struct inode *inode, struc if( uioc.uioc_rmbox[0] == MEGA_MBOXCMD_PASSTHRU ) { /* Passthru commands */ - pthru = pci_alloc_consistent(pdev, - sizeof(mega_passthru), - &pthru_dma_hndl); - - if( pthru == NULL ) { - return (-ENOMEM); - } + pthru = adapter->int_pthru; /* * The user passthru structure @@ -4376,29 +4401,27 @@ megadev_ioctl(struct inode *inode, struc */ if( copy_from_user(pthru, (char *)upthru, sizeof(mega_passthru)) ) { - - pci_free_consistent(pdev, - sizeof(mega_passthru), pthru, - pthru_dma_hndl); - return (-EFAULT); } /* - * Is there a data transfer + * Is there a data transfer; If the data transfer + * length is <= INT_MEMBLK_SZ, usr the buffer + * allocated at the load time. Otherwise, allocate it + * here. */ - if( pthru->dataxferlen ) { - data = pci_alloc_consistent(pdev, - pthru->dataxferlen, - &data_dma_hndl); - - if( data == NULL ) { - pci_free_consistent(pdev, - sizeof(mega_passthru), - pthru, - pthru_dma_hndl); + if (pthru->dataxferlen) { + if (pthru->dataxferlen > INT_MEMBLK_SZ) { + data = pci_alloc_consistent ( + pdev, + pthru->dataxferlen, + &data_dma_hndl ); - return (-ENOMEM); + if (data == NULL) + return (-ENOMEM); + } + else { + data = adapter->int_data; } /* @@ -4406,7 +4429,11 @@ megadev_ioctl(struct inode *inode, struc * address at just allocated memory */ uxferaddr = pthru->dataxferaddr; - pthru->dataxferaddr = data_dma_hndl; + if (data_dma_hndl) + pthru->dataxferaddr = data_dma_hndl; + else + pthru->dataxferaddr = + adapter->int_data_dma_hndl; } @@ -4421,14 +4448,14 @@ megadev_ioctl(struct inode *inode, struc (char *)((ulong)uxferaddr), pthru->dataxferlen) ) { rval = (-EFAULT); - goto freemem_and_return; + goto freedata_and_return; } } memset(&mc, 0, sizeof(megacmd_t)); mc.cmd = MEGA_MBOXCMD_PASSTHRU; - mc.xferaddr = (u32)pthru_dma_hndl; + mc.xferaddr = (u32)adapter->int_pthru_dma_hndl; /* * Issue the command @@ -4437,7 +4464,7 @@ megadev_ioctl(struct inode *inode, struc rval = mega_n_to_m((void *)arg, &mc); - if( rval ) goto freemem_and_return; + if( rval ) goto freedata_and_return; /* @@ -4456,18 +4483,14 @@ megadev_ioctl(struct inode *inode, struc */ copy_to_user(upthru->reqsensearea, pthru->reqsensearea, 14); - -freemem_and_return: - if( pthru->dataxferlen ) { - pci_free_consistent(pdev, - pthru->dataxferlen, data, - data_dma_hndl); +freedata_and_return: + if (data_dma_hndl) { + pci_free_consistent( pdev, pthru->dataxferlen, + data, data_dma_hndl ); } - pci_free_consistent(pdev, sizeof(mega_passthru), - pthru, pthru_dma_hndl); - return rval; + } else { /* DCMD commands */ @@ -4476,13 +4499,18 @@ freemem_and_return: * Is there a data transfer */ if( uioc.xferlen ) { - data = pci_alloc_consistent(pdev, - uioc.xferlen, &data_dma_hndl); + if (uioc.xferlen > INT_MEMBLK_SZ) { + data = pci_alloc_consistent( + pdev, + uioc.xferlen, + &data_dma_hndl ); - if( data == NULL ) { - return (-ENOMEM); + if (data == NULL) + return (-ENOMEM); + } + else { + data = adapter->int_data; } - uxferaddr = MBOX(uioc)->xferaddr; } @@ -4497,9 +4525,9 @@ freemem_and_return: (char *)((ulong)uxferaddr), uioc.xferlen) ) { - pci_free_consistent(pdev, - uioc.xferlen, data, - data_dma_hndl); + pci_free_consistent( + pdev, uioc.xferlen, + data, data_dma_hndl ); return (-EFAULT); } @@ -4507,7 +4535,10 @@ freemem_and_return: memcpy(&mc, MBOX(uioc), sizeof(megacmd_t)); - mc.xferaddr = (u32)data_dma_hndl; + if (data_dma_hndl ) + mc.xferaddr = (u32)data_dma_hndl; + else + mc.xferaddr = (u32)(adapter->int_data_dma_hndl); /* * Issue the command @@ -4517,12 +4548,10 @@ freemem_and_return: rval = mega_n_to_m((void *)arg, &mc); if( rval ) { - if( uioc.xferlen ) { - pci_free_consistent(pdev, - uioc.xferlen, data, - data_dma_hndl); + if (data_dma_hndl) { + pci_free_consistent( pdev, uioc.xferlen, + data, data_dma_hndl ); } - return rval; } @@ -4537,10 +4566,9 @@ freemem_and_return: } } - if( uioc.xferlen ) { - pci_free_consistent(pdev, - uioc.xferlen, data, - data_dma_hndl); + if (data_dma_hndl) { + pci_free_consistent( pdev, uioc.xferlen, + data, data_dma_hndl ); } return rval; @@ -4725,19 +4753,22 @@ mega_n_to_m(void *arg, megacmd_t *mc) else { uioc_mimd = (struct uioctl_t *)arg; - if( put_user(mc->status, (u8 *)&uioc_mimd->mbox[17]) ) + if( put_user(mc->status, (u8 *)&uioc_mimd->mbox[17]) ) { return (-EFAULT); + } if( mc->cmd == MEGA_MBOXCMD_PASSTHRU ) { umc = (megacmd_t *)uioc_mimd->mbox; - if (copy_from_user(&kmc, umc, sizeof(megacmd_t))) + if (copy_from_user(&kmc, umc, sizeof(megacmd_t))) { return -EFAULT; + } upthru = (mega_passthru *)((ulong)kmc.xferaddr); - if( put_user(mc->status, (u8 *)&upthru->scsistatus) ) + if( put_user(mc->status, (u8 *)&upthru->scsistatus) ){ return (-EFAULT); + } } } @@ -5148,7 +5179,6 @@ mega_support_cluster(adapter_t *adapter) } - /** * mega_reorder_hosts() * @@ -5363,6 +5393,7 @@ mega_adapinq(adapter_t *adapter, dma_add } + /** mega_internal_dev_inquiry() * @adapter - pointer to our soft state * @ch - channel for this device diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/scsi/megaraid2.h linux-2.4.30-pre2/drivers/scsi/megaraid2.h --- linux-2.4.29/drivers/scsi/megaraid2.h 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/drivers/scsi/megaraid2.h 2005-02-23 07:44:57.000000000 +0000 @@ -6,7 +6,7 @@ #define MEGARAID_VERSION \ - "v2.10.3 (Release Date: Thu Apr 8 16:16:05 EDT 2004)\n" + "v2.10.8.2 (Release Date: Mon Jul 26 12:15:51 EDT 2004)\n" /* * Driver features - change the values to enable or disable features in the @@ -82,6 +82,7 @@ #define LSI_SUBSYS_VID 0x1000 #define INTEL_SUBSYS_VID 0x8086 #define FSC_SUBSYS_VID 0x1734 +#define ACER_SUBSYS_VID 0x1025 #define HBA_SIGNATURE 0x3344 #define HBA_SIGNATURE_471 0xCCCC @@ -978,6 +979,15 @@ typedef struct { cmds */ int has_cluster; /* cluster support on this HBA */ + +#define INT_MEMBLK_SZ (28*1024) + mega_passthru *int_pthru; /*internal pthru*/ + dma_addr_t int_pthru_dma_hndl; + caddr_t int_data; /*internal data*/ + dma_addr_t int_data_dma_hndl; + + int hw_error; + }adapter_t; @@ -1085,18 +1095,21 @@ typedef enum { LOCK_INT, LOCK_EXT } lock #define MBOX_ABORT_SLEEP 60 #define MBOX_RESET_SLEEP 30 +#define MBOX_RESET_WAIT 180 const char *megaraid_info (struct Scsi_Host *); static int megaraid_detect(Scsi_Host_Template *); static void mega_find_card(Scsi_Host_Template *, u16, u16); static int mega_query_adapter(adapter_t *); -static int issue_scb(adapter_t *, scb_t *); +static inline int issue_scb(adapter_t *, scb_t *); static int mega_setup_mailbox(adapter_t *); static int megaraid_queue (Scsi_Cmnd *, void (*)(Scsi_Cmnd *)); static scb_t * mega_build_cmd(adapter_t *, Scsi_Cmnd *, int *); +static inline scb_t *mega_allocate_scb(adapter_t *, Scsi_Cmnd *); static void __mega_runpendq(adapter_t *); +static inline void mega_runpendq(adapter_t *); static int issue_scb_block(adapter_t *, u_char *); static void megaraid_isr_memmapped(int, void *, struct pt_regs *); @@ -1113,6 +1126,7 @@ static int megaraid_reset(Scsi_Cmnd *); static int mega_build_sglist (adapter_t *adapter, scb_t *scb, u32 *buffer, u32 *length); +static inline int mega_busywait_mbox (adapter_t *); static int __mega_busywait_mbox (adapter_t *); static void mega_cmd_done(adapter_t *, u8 [], int, int); static inline void mega_free_sgl (adapter_t *adapter); @@ -1123,15 +1137,13 @@ static int megaraid_reboot_notify (struc unsigned long, void *); static int megadev_open (struct inode *, struct file *); -#if defined(CONFIG_COMPAT) || defined( __x86_64__) || defined(IA32_EMULATION) -#define LSI_CONFIG_COMPAT -#endif - -#ifdef LSI_CONFIG_COMPAT +#if defined(__x86_64__) static int megadev_compat_ioctl(unsigned int, unsigned int, unsigned long, struct file *); #endif +static int megadev_ioctl_entry (struct inode *, struct file *, unsigned int, + unsigned long); static int megadev_ioctl (struct inode *, struct file *, unsigned int, unsigned long); static int mega_m_to_n(void *, nitioctl_t *); @@ -1164,6 +1176,8 @@ static int proc_rdrv(adapter_t *, char * static int mega_adapinq(adapter_t *, dma_addr_t); static int mega_internal_dev_inquiry(adapter_t *, u8, u8, dma_addr_t); +static inline caddr_t mega_allocate_inquiry(dma_addr_t *, struct pci_dev *); +static inline void mega_free_inquiry(caddr_t, dma_addr_t, struct pci_dev *); static int mega_print_inquiry(char *, char *); #endif @@ -1174,6 +1188,7 @@ static mega_ext_passthru* mega_prepare_e scb_t *, Scsi_Cmnd *, int, int); static void mega_enum_raid_scsi(adapter_t *); static void mega_get_boot_drv(adapter_t *); +static inline int mega_get_ldrv_num(adapter_t *, Scsi_Cmnd *, int); static int mega_support_random_del(adapter_t *); static int mega_del_logdrv(adapter_t *, int); static int mega_do_del_logdrv(adapter_t *, int); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/scsi/sata_nv.c linux-2.4.30-pre2/drivers/scsi/sata_nv.c --- linux-2.4.29/drivers/scsi/sata_nv.c 2005-01-19 14:10:03.000000000 +0000 +++ linux-2.4.30-pre2/drivers/scsi/sata_nv.c 2005-02-23 07:46:37.000000000 +0000 @@ -20,6 +20,10 @@ * If you do not delete the provisions above, a recipient may use your * version of this file under either the OSL or the GPL. * + * 0.06 + * - Added generic SATA support by using a pci_device_id that filters on + * the IDE storage class code. + * * 0.03 * - Fixed a bug where the hotplug handlers for non-CK804/MCP04 were using * mmio_base, which is only set for the CK804/MCP04 case. @@ -44,7 +48,7 @@ #include #define DRV_NAME "sata_nv" -#define DRV_VERSION "0.5" +#define DRV_VERSION "0.6" #define NV_PORTS 2 #define NV_PIO_MASK 0x1f @@ -108,6 +112,7 @@ static void nv_check_hotplug_ck804(struc enum nv_host_type { + GENERIC, NFORCE2, NFORCE3, CK804 @@ -128,6 +133,9 @@ static struct pci_device_id nv_pci_tbl[] PCI_ANY_ID, PCI_ANY_ID, 0, 0, CK804 }, { PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NFORCE_MCP04_SATA2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CK804 }, + { PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, + PCI_ANY_ID, PCI_ANY_ID, + PCI_CLASS_STORAGE_IDE<<8, 0xffff00, GENERIC }, { 0, } /* terminate list */ }; @@ -136,7 +144,6 @@ static struct pci_device_id nv_pci_tbl[] struct nv_host_desc { enum nv_host_type host_type; - unsigned long host_flags; void (*enable_hotplug)(struct ata_probe_ent *probe_ent); void (*disable_hotplug)(struct ata_host_set *host_set); void (*check_hotplug)(struct ata_host_set *host_set); @@ -144,21 +151,24 @@ struct nv_host_desc }; static struct nv_host_desc nv_device_tbl[] = { { + .host_type = GENERIC, + .enable_hotplug = NULL, + .disable_hotplug= NULL, + .check_hotplug = NULL, + }, + { .host_type = NFORCE2, - .host_flags = 0x00000000, .enable_hotplug = nv_enable_hotplug, .disable_hotplug= nv_disable_hotplug, .check_hotplug = nv_check_hotplug, }, { .host_type = NFORCE3, - .host_flags = 0x00000000, .enable_hotplug = nv_enable_hotplug, .disable_hotplug= nv_disable_hotplug, .check_hotplug = nv_check_hotplug, }, { .host_type = CK804, - .host_flags = NV_HOST_FLAGS_SCR_MMIO, .enable_hotplug = nv_enable_hotplug_ck804, .disable_hotplug= nv_disable_hotplug_ck804, .check_hotplug = nv_check_hotplug_ck804, @@ -168,6 +178,7 @@ static struct nv_host_desc nv_device_tbl struct nv_host { struct nv_host_desc *host_desc; + unsigned long host_flags; }; static struct pci_driver nv_pci_driver = { @@ -285,8 +296,8 @@ static u32 nv_scr_read (struct ata_port if (sc_reg > SCR_CONTROL) return 0xffffffffU; - if (host->host_desc->host_flags & NV_HOST_FLAGS_SCR_MMIO) - return readl(ap->ioaddr.scr_addr + (sc_reg * 4)); + if (host->host_flags & NV_HOST_FLAGS_SCR_MMIO) + return readl((void*)ap->ioaddr.scr_addr + (sc_reg * 4)); else return inl(ap->ioaddr.scr_addr + (sc_reg * 4)); } @@ -299,8 +310,8 @@ static void nv_scr_write (struct ata_por if (sc_reg > SCR_CONTROL) return; - if (host->host_desc->host_flags & NV_HOST_FLAGS_SCR_MMIO) - writel(val, ap->ioaddr.scr_addr + (sc_reg * 4)); + if (host->host_flags & NV_HOST_FLAGS_SCR_MMIO) + writel(val, (void*)ap->ioaddr.scr_addr + (sc_reg * 4)); else outl(val, ap->ioaddr.scr_addr + (sc_reg * 4)); } @@ -323,6 +334,14 @@ static int nv_init_one (struct pci_dev * struct ata_port_info *ppi; struct ata_probe_ent *probe_ent; int rc; + u32 bar; + + // Make sure this is a SATA controller by counting the number of bars + // (NVIDIA SATA controllers will always have six bars). Otherwise, + // it's an IDE controller and we ignore it. + for (bar=0; bar<6; bar++) + if (pci_resource_start(pdev, bar) == 0) + return -ENODEV; if (!printed_version++) printk(KERN_DEBUG DRV_NAME " version " DRV_VERSION "\n"); @@ -350,11 +369,15 @@ static int nv_init_one (struct pci_dev * if (!host) goto err_out_free_ent; + memset(host, 0, sizeof(struct nv_host)); host->host_desc = &nv_device_tbl[ent->driver_data]; probe_ent->private_data = host; - if (host->host_desc->host_flags & NV_HOST_FLAGS_SCR_MMIO) { + if (pci_resource_flags(pdev, 5) & IORESOURCE_MEM) + host->host_flags |= NV_HOST_FLAGS_SCR_MMIO; + + if (host->host_flags & NV_HOST_FLAGS_SCR_MMIO) { unsigned long base; probe_ent->mmio_base = ioremap(pci_resource_start(pdev, 5), diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/scsi/sata_promise.c linux-2.4.30-pre2/drivers/scsi/sata_promise.c --- linux-2.4.29/drivers/scsi/sata_promise.c 2005-01-19 14:10:03.000000000 +0000 +++ linux-2.4.30-pre2/drivers/scsi/sata_promise.c 2005-02-23 07:44:57.000000000 +0000 @@ -158,10 +158,18 @@ static struct pci_device_id pdc_ata_pci_ board_2037x }, { PCI_VENDOR_ID_PROMISE, 0x3376, PCI_ANY_ID, PCI_ANY_ID, 0, 0, board_2037x }, + { PCI_VENDOR_ID_PROMISE, 0x3574, PCI_ANY_ID, PCI_ANY_ID, 0, 0, + board_2037x }, + { PCI_VENDOR_ID_PROMISE, 0x3d75, PCI_ANY_ID, PCI_ANY_ID, 0, 0, + board_2037x }, + { PCI_VENDOR_ID_PROMISE, 0x3318, PCI_ANY_ID, PCI_ANY_ID, 0, 0, board_20319 }, { PCI_VENDOR_ID_PROMISE, 0x3319, PCI_ANY_ID, PCI_ANY_ID, 0, 0, board_20319 }, + { PCI_VENDOR_ID_PROMISE, 0x3d18, PCI_ANY_ID, PCI_ANY_ID, 0, 0, + board_20319 }, + { } /* terminate list */ }; @@ -408,9 +416,11 @@ static irqreturn_t pdc_interrupt (int ir return IRQ_NONE; } - spin_lock(&host_set->lock); + spin_lock(&host_set->lock); + + writel(mask, mmio_base + PDC_INT_SEQMASK); - for (i = 0; i < host_set->n_ports; i++) { + for (i = 0; i < host_set->n_ports; i++) { VPRINTK("port %u\n", i); ap = host_set->ports[i]; tmp = mask & (1 << (i + 1)); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/scsi/sata_sil.c linux-2.4.30-pre2/drivers/scsi/sata_sil.c --- linux-2.4.29/drivers/scsi/sata_sil.c 2005-01-19 14:10:03.000000000 +0000 +++ linux-2.4.30-pre2/drivers/scsi/sata_sil.c 2005-02-23 07:45:44.000000000 +0000 @@ -71,6 +71,8 @@ static struct pci_device_id sil_pci_tbl[ { 0x1095, 0x0240, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, { 0x1095, 0x3512, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, { 0x1095, 0x3114, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3114 }, + { 0x1002, 0x436e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, + { 0x1002, 0x4379, PCI_ANY_ID, PCI_ANY_ID, 0, 0, sil_3112 }, { } /* terminate list */ }; @@ -84,10 +86,12 @@ struct sil_drivelist { { "ST330013AS", SIL_QUIRK_MOD15WRITE }, { "ST340017AS", SIL_QUIRK_MOD15WRITE }, { "ST360015AS", SIL_QUIRK_MOD15WRITE }, + { "ST380013AS", SIL_QUIRK_MOD15WRITE }, { "ST380023AS", SIL_QUIRK_MOD15WRITE }, { "ST3120023AS", SIL_QUIRK_MOD15WRITE }, { "ST3160023AS", SIL_QUIRK_MOD15WRITE }, { "ST3120026AS", SIL_QUIRK_MOD15WRITE }, + { "ST3200822AS", SIL_QUIRK_MOD15WRITE }, { "ST340014ASL", SIL_QUIRK_MOD15WRITE }, { "ST360014ASL", SIL_QUIRK_MOD15WRITE }, { "ST380011ASL", SIL_QUIRK_MOD15WRITE }, diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/scsi/sym53c8xx.c linux-2.4.30-pre2/drivers/scsi/sym53c8xx.c --- linux-2.4.29/drivers/scsi/sym53c8xx.c 2004-04-14 13:05:32.000000000 +0000 +++ linux-2.4.30-pre2/drivers/scsi/sym53c8xx.c 2005-02-23 07:46:04.000000000 +0000 @@ -13182,7 +13182,7 @@ sym53c8xx_pci_init(Scsi_Host_Template *t ** descriptors. */ if (chip && (chip->features & FE_DAC)) { - if (pci_set_dma_mask(pdev, (u64) 0xffffffffff)) + if (pci_set_dma_mask(pdev, (u64) 0xffffffffffULL)) chip->features &= ~FE_DAC_IN_USE; else chip->features |= FE_DAC_IN_USE; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/usb/devio.c linux-2.4.30-pre2/drivers/usb/devio.c --- linux-2.4.29/drivers/usb/devio.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/drivers/usb/devio.c 2005-02-23 07:45:38.000000000 +0000 @@ -1132,6 +1132,8 @@ static int proc_ioctl (struct dev_state /* ifno might usefully be passed ... */ retval = driver->ioctl (ps->dev, ctrl.ioctl_code, buf); /* size = min_t(int, size, retval)? */ + if (retval == -ENOIOCTLCMD) + retval = -ENOTTY; } } @@ -1146,24 +1148,10 @@ static int proc_ioctl (struct dev_state return retval; } -static int usbdev_ioctl(struct inode *inode, struct file *file, unsigned int cmd, unsigned long arg) +static int usbdev_ioctl_exclusive(struct dev_state *ps, struct inode *inode, + unsigned int cmd, unsigned long arg) { - struct dev_state *ps = (struct dev_state *)file->private_data; - int ret = -ENOIOCTLCMD; - - if (!(file->f_mode & FMODE_WRITE)) - return -EPERM; - down_read(&ps->devsem); - if (!ps->dev) { - up_read(&ps->devsem); - return -ENODEV; - } - - /* - * grab device's exclusive_access mutex to prevent its driver from - * using this device while it is being accessed by us. - */ - down(&ps->dev->exclusive_access); + int ret; switch (cmd) { case USBDEVFS_CONTROL: @@ -1194,14 +1182,6 @@ static int usbdev_ioctl(struct inode *in inode->i_mtime = CURRENT_TIME; break; - case USBDEVFS_GETDRIVER: - ret = proc_getdriver(ps, (void *)arg); - break; - - case USBDEVFS_CONNECTINFO: - ret = proc_connectinfo(ps, (void *)arg); - break; - case USBDEVFS_SETINTERFACE: ret = proc_setintf(ps, (void *)arg); break; @@ -1220,6 +1200,53 @@ static int usbdev_ioctl(struct inode *in ret = proc_unlinkurb(ps, (void *)arg); break; + case USBDEVFS_CLAIMINTERFACE: + ret = proc_claiminterface(ps, (void *)arg); + break; + + case USBDEVFS_RELEASEINTERFACE: + ret = proc_releaseinterface(ps, (void *)arg); + break; + + case USBDEVFS_IOCTL: + ret = proc_ioctl(ps, (void *) arg); + break; + + default: + ret = -ENOTTY; + } + return ret; +} + +static int usbdev_ioctl(struct inode *inode, struct file *file, + unsigned int cmd, unsigned long arg) +{ + struct dev_state *ps = file->private_data; + int ret; + + if (!(file->f_mode & FMODE_WRITE)) + return -EPERM; + down_read(&ps->devsem); + if (!ps->dev) { + up_read(&ps->devsem); + return -ENODEV; + } + + /* + * Some ioctls don't touch the device and can be called without + * grabbing its exclusive_access mutex; they are handled in this + * switch. Other ioctls which need exclusive_access are handled in + * usbdev_ioctl_exclusive(). + */ + switch (cmd) { + case USBDEVFS_GETDRIVER: + ret = proc_getdriver(ps, (void *)arg); + break; + + case USBDEVFS_CONNECTINFO: + ret = proc_connectinfo(ps, (void *)arg); + break; + case USBDEVFS_REAPURB: ret = proc_reapurb(ps, (void *)arg); break; @@ -1232,19 +1259,28 @@ static int usbdev_ioctl(struct inode *in ret = proc_disconnectsignal(ps, (void *)arg); break; + case USBDEVFS_CONTROL: + case USBDEVFS_BULK: + case USBDEVFS_RESETEP: + case USBDEVFS_RESET: + case USBDEVFS_CLEAR_HALT: + case USBDEVFS_SETINTERFACE: + case USBDEVFS_SETCONFIGURATION: + case USBDEVFS_SUBMITURB: + case USBDEVFS_DISCARDURB: case USBDEVFS_CLAIMINTERFACE: - ret = proc_claiminterface(ps, (void *)arg); - break; - case USBDEVFS_RELEASEINTERFACE: - ret = proc_releaseinterface(ps, (void *)arg); - break; - case USBDEVFS_IOCTL: - ret = proc_ioctl(ps, (void *) arg); + ret = -ERESTARTSYS; + if (down_interruptible(&ps->dev->exclusive_access) == 0) { + ret = usbdev_ioctl_exclusive(ps, inode, cmd, arg); + up(&ps->dev->exclusive_access); + } break; + + default: + ret = -ENOTTY; } - up(&ps->dev->exclusive_access); up_read(&ps->devsem); if (ret >= 0) inode->i_atime = CURRENT_TIME; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/usb/hid-core.c linux-2.4.30-pre2/drivers/usb/hid-core.c --- linux-2.4.29/drivers/usb/hid-core.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/drivers/usb/hid-core.c 2005-02-23 07:45:51.000000000 +0000 @@ -1064,18 +1064,31 @@ static int hid_submit_out(struct hid_dev static void hid_ctrl(struct urb *urb) { struct hid_device *hid = urb->context; + unsigned long flags; if (urb->status) warn("ctrl urb status %d received", urb->status); + spin_lock_irqsave(&hid->outlock, flags); + hid->outtail = (hid->outtail + 1) & (HID_CONTROL_FIFO_SIZE - 1); - if (hid->outhead != hid->outtail) - hid_submit_out(hid); + if (hid->outhead != hid->outtail) { + if (hid_submit_out(hid)) { + clear_bit(HID_OUT_RUNNING, &hid->iofl); + } + spin_unlock_irqrestore(&hid->outlock, flags); + return; + } + + clear_bit(HID_OUT_RUNNING, &hid->iofl); + spin_unlock_irqrestore(&hid->outlock, flags); } void hid_write_report(struct hid_device *hid, struct hid_report *report) { + unsigned long flags; + if (hid->report_enum[report->type].numbered) { hid->out[hid->outhead].buffer[0] = report->id; hid_output_report(report, hid->out[hid->outhead].buffer + 1); @@ -1087,13 +1100,18 @@ void hid_write_report(struct hid_device hid->out[hid->outhead].dr.wValue = cpu_to_le16(((report->type + 1) << 8) | report->id); + spin_lock_irqsave(&hid->outlock, flags); + hid->outhead = (hid->outhead + 1) & (HID_CONTROL_FIFO_SIZE - 1); if (hid->outhead == hid->outtail) hid->outtail = (hid->outtail + 1) & (HID_CONTROL_FIFO_SIZE - 1); - if (hid->urbout.status != -EINPROGRESS) - hid_submit_out(hid); + if (!test_and_set_bit(HID_OUT_RUNNING, &hid->iofl)) + if (hid_submit_out(hid)) + clear_bit(HID_OUT_RUNNING, &hid->iofl); + + spin_unlock_irqrestore(&hid->outlock, flags); } int hid_open(struct hid_device *hid) @@ -1333,6 +1351,8 @@ static struct hid_device *usb_hid_config return NULL; } + spin_lock_init(&hid->outlock); + hid->version = hdesc->bcdHID; hid->country = hdesc->bCountryCode; hid->dev = dev; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/usb/hid.h linux-2.4.30-pre2/drivers/usb/hid.h --- linux-2.4.29/drivers/usb/hid.h 2003-08-25 11:44:42.000000000 +0000 +++ linux-2.4.30-pre2/drivers/usb/hid.h 2005-02-23 07:44:57.000000000 +0000 @@ -302,6 +302,8 @@ struct hid_control_fifo { #define HID_CLAIMED_INPUT 1 #define HID_CLAIMED_HIDDEV 2 +#define HID_OUT_RUNNING 2 + struct hid_input { struct list_head list; struct hid_report *report; @@ -322,12 +324,15 @@ struct hid_device { /* device repo struct usb_device *dev; /* USB device */ int ifnum; /* USB interface number */ + unsigned long iofl; /* I/O flags (CTRL_RUNNING, OUT_RUNNING) */ + struct urb urb; /* USB URB structure */ char buffer[HID_BUFFER_SIZE]; /* Rx buffer */ struct urb urbout; /* Output URB */ struct hid_control_fifo out[HID_CONTROL_FIFO_SIZE]; /* Transmit buffer */ unsigned char outhead, outtail; /* Tx buffer head & tail */ + spinlock_t outlock; /* Output fifo spinlock */ unsigned claimed; /* Claimed by hidinput, hiddev? */ unsigned quirks; /* Various quirks the device can pull on us */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/usb/hiddev.c linux-2.4.30-pre2/drivers/usb/hiddev.c --- linux-2.4.29/drivers/usb/hiddev.c 2004-08-07 23:26:05.000000000 +0000 +++ linux-2.4.30-pre2/drivers/usb/hiddev.c 2005-02-23 07:45:26.000000000 +0000 @@ -328,6 +328,7 @@ static ssize_t hiddev_read(struct file * } schedule(); + set_current_state(TASK_INTERRUPTIBLE); } set_current_state(TASK_RUNNING); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/usb/serial/ftdi_sio.c linux-2.4.30-pre2/drivers/usb/serial/ftdi_sio.c --- linux-2.4.29/drivers/usb/serial/ftdi_sio.c 2005-01-19 14:10:07.000000000 +0000 +++ linux-2.4.30-pre2/drivers/usb/serial/ftdi_sio.c 2005-02-23 07:46:16.000000000 +0000 @@ -737,8 +737,6 @@ static struct usb_serial_device_type ftd }; - - static struct usb_serial_device_type ftdi_userdev_device = { .owner = THIS_MODULE, .name = "FTDI SIO compatible", @@ -1240,15 +1238,6 @@ static int ftdi_HE_TIRA1_startup (struct } /* ftdi_HE_TIRA1_startup */ -/* ftdi_shutdown is called from usbserial:usb_serial_disconnect - * it is called when the usb device is disconnected - * - * usbserial:usb_serial_disconnect - * calls __serial_close for each open of the port - * shutdown is called then (ie ftdi_shutdown) - */ - - /* Startup for the 8U232AM chip */ static int ftdi_userdev_startup (struct usb_serial *serial) { @@ -1273,6 +1262,14 @@ static int ftdi_userdev_startup (struct } +/* ftdi_shutdown is called from usbserial:usb_serial_disconnect + * it is called when the usb device is disconnected + * + * usbserial:usb_serial_disconnect + * calls __serial_close for each open of the port + * shutdown is called then (ie ftdi_shutdown) + */ + static void ftdi_shutdown (struct usb_serial *serial) { /* ftdi_shutdown */ @@ -1382,6 +1379,7 @@ static void ftdi_close (struct usb_seria struct usb_serial *serial; unsigned int c_cflag = port->tty->termios->c_cflag; char buf[1]; + int err; dbg("%s", __FUNCTION__); @@ -1412,8 +1410,9 @@ static void ftdi_close (struct usb_seria /* shutdown our bulk read */ if (port->read_urb) { - if(usb_unlink_urb (port->read_urb)<0) - err("Error unlinking urb"); + err = usb_unlink_urb (port->read_urb); + if (err < 0 && err != -ENODEV) + err("Error unlinking urb (%d)", err); } /* unlink the running write urbs */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/usb/serial/mct_u232.c linux-2.4.30-pre2/drivers/usb/serial/mct_u232.c --- linux-2.4.29/drivers/usb/serial/mct_u232.c 2005-01-19 14:10:08.000000000 +0000 +++ linux-2.4.30-pre2/drivers/usb/serial/mct_u232.c 2005-02-23 07:46:02.000000000 +0000 @@ -86,26 +86,14 @@ #include "usb-serial.h" #include "mct_u232.h" - /* * Version Information */ -#define DRIVER_VERSION "v1.2" +#define DRIVER_VERSION "z2.0" /* Linux in-kernel version */ #define DRIVER_AUTHOR "Wolfgang Grandegger " #define DRIVER_DESC "Magic Control Technology USB-RS232 converter driver" /* - * Some not properly written applications do not handle the return code of - * write() correctly. This can result in character losses. A work-a-round - * can be compiled in with the following definition. This work-a-round - * should _NOT_ be part of an 'official' kernel release, of course! - */ -#undef FIX_WRITE_RETURN_CODE_PROBLEM -#ifdef FIX_WRITE_RETURN_CODE_PROBLEM -static int write_blocking; /* disabled by default */ -#endif - -/* * Function prototypes */ static int mct_u232_startup (struct usb_serial *serial); @@ -114,13 +102,6 @@ static int mct_u232_open (stru struct file *filp); static void mct_u232_close (struct usb_serial_port *port, struct file *filp); -#ifdef FIX_WRITE_RETURN_CODE_PROBLEM -static int mct_u232_write (struct usb_serial_port *port, - int from_user, - const unsigned char *buf, - int count); -static void mct_u232_write_bulk_callback (struct urb *urb); -#endif static void mct_u232_read_int_callback (struct urb *urb); static void mct_u232_set_termios (struct usb_serial_port *port, struct termios * old); @@ -147,7 +128,7 @@ MODULE_DEVICE_TABLE (usb, id_table_combi static struct usb_serial_device_type mct_u232_device = { .owner = THIS_MODULE, - .name = "Magic Control Technology USB-RS232", + .name = "MCT U232", .id_table = id_table_combined, .num_interrupt_in = 2, .num_bulk_in = 0, @@ -155,10 +136,6 @@ static struct usb_serial_device_type mct .num_ports = 1, .open = mct_u232_open, .close = mct_u232_close, -#ifdef FIX_WRITE_RETURN_CODE_PROBLEM - .write = mct_u232_write, - .write_bulk_callback = mct_u232_write_bulk_callback, -#endif .read_int_callback = mct_u232_read_int_callback, .ioctl = mct_u232_ioctl, .set_termios = mct_u232_set_termios, @@ -167,9 +144,14 @@ static struct usb_serial_device_type mct .shutdown = mct_u232_shutdown, }; +struct mct_u232_interval_kludge { + int ecnt; /* Error counter */ + int ibase; /* Initial interval value */ +}; struct mct_u232_private { spinlock_t lock; + struct mct_u232_interval_kludge ik[2]; unsigned int control_state; /* Modem Line Setting (TIOCM) */ unsigned char last_lcr; /* Line Control Register */ unsigned char last_lsr; /* Line Status Register */ @@ -359,17 +341,13 @@ static int mct_u232_startup (struct usb_ struct mct_u232_private *priv; struct usb_serial_port *port, *rport; - /* allocate the private data structure */ priv = kmalloc(sizeof(struct mct_u232_private), GFP_KERNEL); if (!priv) return -ENOMEM; - /* set initial values for control structures */ + memset(priv, 0, sizeof(struct mct_u232_private)); spin_lock_init(&priv->lock); - priv->control_state = 0; - priv->last_lsr = 0; - priv->last_msr = 0; serial->port->private = priv; - + init_waitqueue_head(&serial->port->write_wait); /* Puh, that's dirty */ @@ -383,20 +361,27 @@ static int mct_u232_startup (struct usb_ rport->interrupt_in_urb = NULL; port->read_urb->context = port; + priv->ik[0].ibase = port->read_urb->interval; + priv->ik[1].ibase = port->interrupt_in_urb->interval; + return (0); } /* mct_u232_startup */ static void mct_u232_shutdown (struct usb_serial *serial) { + struct mct_u232_private *priv; int i; dbg("%s", __FUNCTION__); for (i=0; i < serial->num_ports; ++i) { /* My special items, the standard routines free my urbs */ - if (serial->port[i].private) - kfree(serial->port[i].private); + priv = serial->port[i].private; + if (priv) { + serial->port[i].private = NULL; + kfree(priv); + } } } /* mct_u232_shutdown */ @@ -448,16 +433,20 @@ static int mct_u232_open (struct usb_se spin_unlock_irqrestore(&priv->lock, flags); port->read_urb->dev = port->serial->dev; + port->read_urb->interval = priv->ik[0].ibase; retval = usb_submit_urb(port->read_urb); if (retval) { - err("usb_submit_urb(read bulk) failed"); + err("usb_submit_urb(read bulk) failed pipe 0x%x err %d", + port->read_urb->pipe, retval); goto exit; } port->interrupt_in_urb->dev = port->serial->dev; + port->interrupt_in_urb->interval = priv->ik[1].ibase; retval = usb_submit_urb(port->interrupt_in_urb); if (retval) - err(" usb_submit_urb(read int) failed"); + err(" usb_submit_urb(read int) failed pipe 0x%x err %d", + port->interrupt_in_urb->pipe, retval); exit: return 0; @@ -476,109 +465,22 @@ static void mct_u232_close (struct usb_s } } /* mct_u232_close */ - -#ifdef FIX_WRITE_RETURN_CODE_PROBLEM -/* The generic routines work fine otherwise */ - -static int mct_u232_write (struct usb_serial_port *port, int from_user, - const unsigned char *buf, int count) +static void mct_u232_error_step (struct urb *urb, + struct mct_u232_private *priv, int n) { - struct usb_serial *serial = port->serial; - int result, bytes_sent, size; - - dbg("%s - port %d", __FUNCTION__, port->number); - - if (count == 0) { - dbg("%s - write request of 0 bytes", __FUNCTION__); - return (0); - } - - /* only do something if we have a bulk out endpoint */ - if (!serial->num_bulk_out) - return(0);; - - /* another write is still pending? */ - if (port->write_urb->status == -EINPROGRESS) { - dbg("%s - already writing", __FUNCTION__); - return (0); - } - - bytes_sent = 0; - while (count > 0) { - size = (count > port->bulk_out_size) ? port->bulk_out_size : count; - - usb_serial_debug_data (__FILE__, __FUNCTION__, size, buf); - - if (from_user) { - if (copy_from_user(port->write_urb->transfer_buffer, buf, size)) { - return -EFAULT; - } - } - else { - memcpy (port->write_urb->transfer_buffer, buf, size); - } - - /* set up our urb */ - FILL_BULK_URB(port->write_urb, serial->dev, - usb_sndbulkpipe(serial->dev, - port->bulk_out_endpointAddress), - port->write_urb->transfer_buffer, size, - ((serial->type->write_bulk_callback) ? - serial->type->write_bulk_callback : - mct_u232_write_bulk_callback), - port); - - /* send the data out the bulk port */ - result = usb_submit_urb(port->write_urb); - if (result) { - err("%s - failed submitting write urb, error %d", __FUNCTION__, result); - return result; - } - - bytes_sent += size; - if (write_blocking) - interruptible_sleep_on(&port->write_wait); - else - break; - - buf += size; - count -= size; - } - - return bytes_sent; -} /* mct_u232_write */ - -static void mct_u232_write_bulk_callback (struct urb *urb) -{ - struct usb_serial_port *port = (struct usb_serial_port *)urb->context; - struct usb_serial *serial = port->serial; - struct tty_struct *tty = port->tty; - - dbg("%s - port %d", __FUNCTION__, port->number); - - if (!serial) { - dbg("%s - bad serial pointer, exiting", __FUNCTION__); - return; - } + struct mct_u232_interval_kludge *ikp = &priv->ik[n]; - if (urb->status) { - dbg("%s - nonzero write bulk status received: %d", __FUNCTION__, - urb->status); - return; - } - - if (write_blocking) { - wake_up_interruptible(&port->write_wait); - tty_wakeup(tty); + if (ikp->ecnt >= 2) { + if (urb->interval) + err("%s - too many errors: " + "status %d pipe 0x%x interval %d", + __FUNCTION__, + urb->status, urb->pipe, urb->interval); + urb->interval = 0; } else { - /* from generic_write_bulk_callback */ - queue_task(&port->tqueue, &tq_immediate); - mark_bh(IMMEDIATE_BH); + ++ikp->ecnt; } - - return; -} /* mct_u232_write_bulk_callback */ -#endif +} static void mct_u232_read_int_callback (struct urb *urb) { @@ -589,21 +491,37 @@ static void mct_u232_read_int_callback ( unsigned char *data = urb->transfer_buffer; unsigned long flags; - dbg("%s - port %d", __FUNCTION__, port->number); - /* The urb might have been killed. */ if (urb->status) { - dbg("%s - nonzero read bulk status received: %d", __FUNCTION__, - urb->status); + dbg("%s - nonzero status %d, pipe 0x%x flags 0x%x interval %d", + __FUNCTION__, + urb->status, urb->pipe, urb->transfer_flags, urb->interval); + /* + * The bad stuff happens when a device is disconnected. + * This can cause us to spin while trying to resubmit. + * Unfortunately, in kernel 2.4 error codes are wildly + * different between controllers, so the status is useless. + * Instead we just refuse to spin too much. + */ + if (urb == port->read_urb) + mct_u232_error_step(urb, priv, 0); + if (urb == port->interrupt_in_urb) + mct_u232_error_step(urb, priv, 1); return; } if (!serial) { dbg("%s - bad serial pointer, exiting", __FUNCTION__); return; } - + + dbg("%s - port %d", __FUNCTION__, port->number); usb_serial_debug_data (__FILE__, __FUNCTION__, urb->actual_length, data); + if (urb == port->read_urb) + priv->ik[0].ecnt = 0; + if (urb == port->interrupt_in_urb) + priv->ik[1].ecnt = 0; + /* * Work-a-round: handle the 'usual' bulk-in pipe here */ @@ -660,7 +578,6 @@ static void mct_u232_read_int_callback ( /* INT urbs are automatically re-submitted */ } /* mct_u232_read_int_callback */ - static void mct_u232_set_termios (struct usb_serial_port *port, struct termios *old_termios) { @@ -781,6 +698,21 @@ static void mct_u232_break_ctl( struct u } /* mct_u232_break_ctl */ +static int mct_u232_tiocmget (struct usb_serial_port *port, struct file *file) +{ + struct mct_u232_private *priv = (struct mct_u232_private *)port->private; + unsigned int control_state; + unsigned long flags; + + dbg("%s", __FUNCTION__); + + spin_lock_irqsave(&priv->lock, flags); + control_state = priv->control_state; + spin_unlock_irqrestore(&priv->lock, flags); + + return control_state; +} + static int mct_u232_ioctl (struct usb_serial_port *port, struct file * file, unsigned int cmd, unsigned long arg) { @@ -794,8 +726,8 @@ static int mct_u232_ioctl (struct usb_se /* Based on code from acm.c and others */ switch (cmd) { case TIOCMGET: - return put_user(priv->control_state, (unsigned long *) arg); - break; + mask = mct_u232_tiocmget(port, file); + return put_user(mask, (unsigned long *) arg); case TIOCMSET: /* Turns on and off the lines as specified by the mask */ case TIOCMBIS: /* turns on (Sets) the lines as specified by the mask */ @@ -865,12 +797,5 @@ MODULE_AUTHOR( DRIVER_AUTHOR ); MODULE_DESCRIPTION( DRIVER_DESC ); MODULE_LICENSE("GPL"); -#ifdef FIX_WRITE_RETURN_CODE_PROBLEM -MODULE_PARM(write_blocking, "i"); -MODULE_PARM_DESC(write_blocking, - "The write function will block to write out all data"); -#endif - MODULE_PARM(debug, "i"); MODULE_PARM_DESC(debug, "Debug enabled or not"); - diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/usb/storage/transport.c linux-2.4.30-pre2/drivers/usb/storage/transport.c --- linux-2.4.29/drivers/usb/storage/transport.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/drivers/usb/storage/transport.c 2005-02-23 07:45:21.000000000 +0000 @@ -1181,6 +1181,13 @@ int usb_stor_Bulk_transport(Scsi_Cmnd *s /* if the command transfered well, then we go to the data stage */ if (result == 0) { + + /* Genesys Logic interface chips need a 100us delay between + * the command phase and the data phase. Some systems need + * even more, probably because of clock rate inaccuracies. */ + if (us->pusb_dev->descriptor.idVendor == USB_VENDOR_ID_GENESYS) + udelay(110); + /* send/receive data payload, if there is any */ if (bcb->DataTransferLength) { usb_stor_transfer(srb, us); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/usb/storage/usb.c linux-2.4.30-pre2/drivers/usb/storage/usb.c --- linux-2.4.29/drivers/usb/storage/usb.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/drivers/usb/storage/usb.c 2005-02-23 07:45:01.000000000 +0000 @@ -996,6 +996,15 @@ static void * storage_probe(struct usb_d */ ss->htmplt.proc_dir = (void *)ss; + /* According to the technical support people at Genesys Logic, + * devices using their chips have problems transferring more + * than 32 KB at a time. In practice people have found that + * 64 KB works okay and that's what Windows does. But we'll + * be conservative. + */ + if (ss->pusb_dev->descriptor.idVendor == USB_VENDOR_ID_GENESYS) + ss->htmplt.max_sectors = 64; + /* Just before we start our control thread, initialize * the device if it needs initialization */ if (unusual_dev && unusual_dev->initFunction) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/drivers/usb/storage/usb.h linux-2.4.30-pre2/drivers/usb/storage/usb.h --- linux-2.4.29/drivers/usb/storage/usb.h 2004-08-07 23:26:05.000000000 +0000 +++ linux-2.4.30-pre2/drivers/usb/storage/usb.h 2005-02-23 07:46:00.000000000 +0000 @@ -193,4 +193,7 @@ extern struct usb_driver usb_storage_dri /* Function to fill an inquiry response. See usb.c for details */ extern void fill_inquiry_response(struct us_data *us, unsigned char *data, unsigned int data_len); + +/* Vendor ID list for devices that require special handling */ +#define USB_VENDOR_ID_GENESYS 0x05e3 /* Genesys Logic */ #endif diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/file_table.c linux-2.4.30-pre2/fs/file_table.c --- linux-2.4.29/fs/file_table.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/fs/file_table.c 2005-02-23 07:44:58.000000000 +0000 @@ -46,6 +46,7 @@ struct file * get_empty_filp(void) f->f_version = ++event; f->f_uid = current->fsuid; f->f_gid = current->fsgid; + f->f_maxcount = INT_MAX; list_add(&f->f_list, &anon_list); file_list_unlock(); return f; @@ -91,6 +92,8 @@ int init_private_file(struct file *filp, filp->f_uid = current->fsuid; filp->f_gid = current->fsgid; filp->f_op = dentry->d_inode->i_fop; + filp->f_maxcount = INT_MAX; + if (filp->f_op->open) return filp->f_op->open(dentry->d_inode, filp); else diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/jfs/jfs_defragfs.h linux-2.4.30-pre2/fs/jfs/jfs_defragfs.h --- linux-2.4.29/fs/jfs/jfs_defragfs.h 2002-11-28 23:53:15.000000000 +0000 +++ linux-2.4.30-pre2/fs/jfs/jfs_defragfs.h 1970-01-01 00:00:00.000000000 +0000 @@ -1,51 +0,0 @@ -/* - * Copyright (c) International Business Machines Corp., 2000-2001 - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See - * the GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - */ -#ifndef _H_JFS_DEFRAGFS -#define _H_JFS_DEFRAGFS - -/* - * defragfs parameter list - */ -struct defragfs { - uint flag; /* 4: */ - u8 dev; /* 1: */ - u8 pad[3]; /* 3: */ - s32 fileset; /* 4: */ - u32 inostamp; /* 4: */ - u32 ino; /* 4: */ - u32 gen; /* 4: */ - s64 xoff; /* 8: */ - s64 old_xaddr; /* 8: */ - s64 new_xaddr; /* 8: */ - s32 xlen; /* 4: */ -}; - -/* plist flag */ -#define DEFRAGFS_SYNC 0x80000000 -#define DEFRAGFS_COMMIT 0x40000000 -#define DEFRAGFS_RELOCATE 0x10000000 - -#define INODE_TYPE 0x0000F000 /* IFREG or IFDIR */ - -#define EXTENT_TYPE 0x000000ff -#define DTPAGE 0x00000001 -#define XTPAGE 0x00000002 -#define DATAEXT 0x00000004 -#define EAEXT 0x00000008 - -#endif /* _H_JFS_DEFRAGFS */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/jfs/jfs_imap.c linux-2.4.30-pre2/fs/jfs/jfs_imap.c --- linux-2.4.29/fs/jfs/jfs_imap.c 2005-01-19 14:10:10.000000000 +0000 +++ linux-2.4.30-pre2/fs/jfs/jfs_imap.c 2005-02-23 07:45:33.000000000 +0000 @@ -486,7 +486,6 @@ struct inode *diReadSpecial(struct super /* read the page of fixed disk inode (AIT) in raw mode */ mp = read_metapage(ip, address << sbi->l2nbperpage, PSIZE, 1); if (mp == NULL) { - ip->i_sb = NULL; ip->i_nlink = 1; /* Don't want iput() deleting it */ iput(ip); return (NULL); @@ -499,7 +498,6 @@ struct inode *diReadSpecial(struct super /* copy on-disk inode to in-memory inode */ if ((copy_from_dinode(dp, ip)) != 0) { /* handle bad return by returning NULL for ip */ - ip->i_sb = NULL; ip->i_nlink = 1; /* Don't want iput() deleting it */ iput(ip); /* release the page */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/jfs/jfs_metapage.c linux-2.4.30-pre2/fs/jfs/jfs_metapage.c --- linux-2.4.29/fs/jfs/jfs_metapage.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/fs/jfs/jfs_metapage.c 2005-02-23 07:46:08.000000000 +0000 @@ -298,14 +298,14 @@ again: mp = search_hash(hash_ptr, mapping, lblock); if (mp) { page_found: - mp->count++; - lock_metapage(mp); - spin_unlock(&meta_lock); if (test_bit(META_stale, &mp->flag)) { - release_metapage(mp); - yield(); /* Let other waiters release it, too */ + spin_unlock(&meta_lock); + yield(); goto again; } + mp->count++; + lock_metapage(mp); + spin_unlock(&meta_lock); if (test_bit(META_discard, &mp->flag)) { if (!new) { jfs_error(inode->i_sb, @@ -518,7 +518,6 @@ void release_metapage(struct metapage * } if (mp->page) { - /* Releasing spinlock, we have to check mp->count later */ set_bit(META_stale, &mp->flag); spin_unlock(&meta_lock); kunmap(mp->page); @@ -555,12 +554,6 @@ void release_metapage(struct metapage * list_del(&mp->synclist); LOGSYNC_UNLOCK(log); } - if (mp->count) { - /* Someone else is trying to get this metpage */ - unlock_metapage(mp); - spin_unlock(&meta_lock); - return; - } remove_from_hash(mp, meta_hash(mp->mapping, mp->index)); spin_unlock(&meta_lock); @@ -589,12 +582,8 @@ again: mp = search_hash(hash_ptr, mapping, lblock); if (mp) { if (test_bit(META_stale, &mp->flag)) { - /* Racing with release_metapage */ - mp->count++; - lock_metapage(mp); spin_unlock(&meta_lock); - /* racing release_metapage should be done now */ - release_metapage(mp); + yield(); goto again; } diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/jfs/jfs_unicode.c linux-2.4.30-pre2/fs/jfs/jfs_unicode.c --- linux-2.4.29/fs/jfs/jfs_unicode.c 2004-04-14 13:05:40.000000000 +0000 +++ linux-2.4.30-pre2/fs/jfs/jfs_unicode.c 2005-02-23 07:46:01.000000000 +0000 @@ -1,5 +1,5 @@ /* - * Copyright (c) International Business Machines Corp., 2000-2002 + * Copyright (C) International Business Machines Corp., 2000-2005 * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -18,7 +18,7 @@ #include #include -#include "jfs_types.h" +#include "jfs_incore.h" #include "jfs_filsys.h" #include "jfs_unicode.h" #include "jfs_debug.h" @@ -34,17 +34,40 @@ int jfs_strfromUCS_le(char *to, const wc { int i; int outlen = 0; + static int warn_again = 5; /* Only warn up to 5 times total */ + int warn = !!warn_again; /* once per string */ - for (i = 0; (i < len) && from[i]; i++) { - int charlen; - charlen = - codepage->uni2char(le16_to_cpu(from[i]), &to[outlen], - NLS_MAX_CHARSET_SIZE); - if (charlen > 0) { - outlen += charlen; - } else { - to[outlen++] = '?'; + if (codepage) { + for (i = 0; (i < len) && from[i]; i++) { + int charlen; + charlen = + codepage->uni2char(le16_to_cpu(from[i]), + &to[outlen], + NLS_MAX_CHARSET_SIZE); + if (charlen > 0) + outlen += charlen; + else + to[outlen++] = '?'; } + } else { + for (i = 0; (i < len) && from[i]; i++) { + if (le16_to_cpu(from[i]) & 0xff00) { + if (warn) { + warn--; + warn_again--; + printk(KERN_ERR + "non-latin1 character 0x%x found in JFS file name\n", + le16_to_cpu(from[i])); + printk(KERN_ERR + "mount with iocharset=utf8 to access\n"); + } + to[i] = '?'; + } + else + to[i] = (char) (le16_to_cpu(from[i])); + } + outlen = i; + } to[outlen] = 0; return outlen; @@ -56,20 +79,27 @@ int jfs_strfromUCS_le(char *to, const wc * FUNCTION: Convert character string to unicode string * */ -static int jfs_strtoUCS(wchar_t * to, const char *from, int len, +static int jfs_strtoUCS(wchar_t * to, const unsigned char *from, int len, struct nls_table *codepage) { int charlen; int i; - for (i = 0; len && *from; i++, from += charlen, len -= charlen) { - charlen = codepage->char2uni(from, len, &to[i]); - if (charlen < 1) { - jfs_err("jfs_strtoUCS: char2uni returned %d.", charlen); - jfs_err("charset = %s, char = 0x%x", - codepage->charset, (unsigned char) *from); - return charlen; + if (codepage) { + for (i = 0; len && *from; i++, from += charlen, len -= charlen) + { + charlen = codepage->char2uni(from, len, &to[i]); + if (charlen < 1) { + jfs_err("jfs_strtoUCS: char2uni returned %d.", + charlen); + jfs_err("charset = %s, char = 0x%x", + codepage->charset, *from); + return charlen; + } } + } else { + for (i = 0; (i < len) && from[i]; i++) + to[i] = (wchar_t) from[i]; } to[i] = 0; @@ -82,9 +112,9 @@ static int jfs_strtoUCS(wchar_t * to, co * FUNCTION: Allocate and translate to unicode string * */ -int get_UCSname(struct component_name * uniName, struct dentry *dentry, - struct nls_table *nls_tab) +int get_UCSname(struct component_name * uniName, struct dentry *dentry) { + struct nls_table *nls_tab = JFS_SBI(dentry->d_sb)->nls_tab; int length = dentry->d_name.len; if (length > JFS_NAME_MAX) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/jfs/jfs_unicode.h linux-2.4.30-pre2/fs/jfs/jfs_unicode.h --- linux-2.4.29/fs/jfs/jfs_unicode.h 2002-11-28 23:53:15.000000000 +0000 +++ linux-2.4.30-pre2/fs/jfs/jfs_unicode.h 2005-02-23 07:46:01.000000000 +0000 @@ -1,6 +1,6 @@ /* - * Copyright (c) International Business Machines Corp., 2000-2002 - * Portions Copyright (c) Christoph Hellwig, 2001-2002 + * Copyright (C) International Business Machines Corp., 2000-2002 + * Portions Copyright (C) Christoph Hellwig, 2001-2002 * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -30,8 +30,7 @@ typedef struct { extern signed char UniUpperTable[512]; extern UNICASERANGE UniUpperRange[]; -extern int get_UCSname(struct component_name *, struct dentry *, - struct nls_table *); +extern int get_UCSname(struct component_name *, struct dentry *); extern int jfs_strfromUCS_le(char *, const wchar_t *, int, struct nls_table *); #define free_UCSname(COMP) kfree((COMP)->name) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/jfs/namei.c linux-2.4.30-pre2/fs/jfs/namei.c --- linux-2.4.29/fs/jfs/namei.c 2004-08-07 23:26:06.000000000 +0000 +++ linux-2.4.30-pre2/fs/jfs/namei.c 2005-02-23 07:44:59.000000000 +0000 @@ -74,7 +74,7 @@ static int jfs_create(struct inode *dip, * search parent directory for entry/freespace * (dtSearch() returns parent directory page pinned) */ - if ((rc = get_UCSname(&dname, dentry, JFS_SBI(dip->i_sb)->nls_tab))) + if ((rc = get_UCSname(&dname, dentry))) goto out1; /* @@ -195,7 +195,7 @@ static int jfs_mkdir(struct inode *dip, * search parent directory for entry/freespace * (dtSearch() returns parent directory page pinned) */ - if ((rc = get_UCSname(&dname, dentry, JFS_SBI(dip->i_sb)->nls_tab))) + if ((rc = get_UCSname(&dname, dentry))) goto out1; /* @@ -318,9 +318,8 @@ static int jfs_rmdir(struct inode *dip, goto out; } - if ((rc = get_UCSname(&dname, dentry, JFS_SBI(dip->i_sb)->nls_tab))) { + if ((rc = get_UCSname(&dname, dentry))) goto out; - } tid = txBegin(dip->i_sb, 0); @@ -437,7 +436,7 @@ static int jfs_unlink(struct inode *dip, jfs_info("jfs_unlink: dip:0x%p name:%s", dip, dentry->d_name.name); - if ((rc = get_UCSname(&dname, dentry, JFS_SBI(dip->i_sb)->nls_tab))) + if ((rc = get_UCSname(&dname, dentry))) goto out; IWRITE_LOCK(ip); @@ -780,7 +779,7 @@ static int jfs_link(struct dentry *old_d /* * scan parent directory for entry/freespace */ - if ((rc = get_UCSname(&dname, dentry, JFS_SBI(ip->i_sb)->nls_tab))) + if ((rc = get_UCSname(&dname, dentry))) goto out; if ((rc = dtSearch(dir, &dname, &ino, &btstack, JFS_CREATE))) @@ -865,7 +864,7 @@ static int jfs_symlink(struct inode *dip * (dtSearch() returns parent directory page pinned) */ - if ((rc = get_UCSname(&dname, dentry, JFS_SBI(dip->i_sb)->nls_tab))) + if ((rc = get_UCSname(&dname, dentry))) goto out1; /* @@ -1044,12 +1043,10 @@ static int jfs_rename(struct inode *old_ old_ip = old_dentry->d_inode; new_ip = new_dentry->d_inode; - if ((rc = get_UCSname(&old_dname, old_dentry, - JFS_SBI(old_dir->i_sb)->nls_tab))) + if ((rc = get_UCSname(&old_dname, old_dentry))) goto out1; - if ((rc = get_UCSname(&new_dname, new_dentry, - JFS_SBI(old_dir->i_sb)->nls_tab))) + if ((rc = get_UCSname(&new_dname, new_dentry))) goto out2; /* @@ -1301,7 +1298,7 @@ static int jfs_mknod(struct inode *dir, jfs_info("jfs_mknod: %s", dentry->d_name.name); - if ((rc = get_UCSname(&dname, dentry, JFS_SBI(dir->i_sb)->nls_tab))) + if ((rc = get_UCSname(&dname, dentry))) goto out; ip = ialloc(dir, mode); @@ -1376,8 +1373,7 @@ static struct dentry *jfs_lookup(struct else if (strcmp(name, "..") == 0) inum = PARENT(dip); else { - if ((rc = - get_UCSname(&key, dentry, JFS_SBI(dip->i_sb)->nls_tab))) + if ((rc = get_UCSname(&key, dentry))) return ERR_PTR(rc); rc = dtSearch(dip, &key, &inum, &btstack, JFS_LOOKUP); free_UCSname(&key); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/jfs/super.c linux-2.4.30-pre2/fs/jfs/super.c --- linux-2.4.29/fs/jfs/super.c 2004-08-07 23:26:06.000000000 +0000 +++ linux-2.4.30-pre2/fs/jfs/super.c 2005-02-23 07:46:49.000000000 +0000 @@ -1,5 +1,5 @@ /* - * Copyright (C) International Business Machines Corp., 2000-2003 + * Copyright (C) International Business Machines Corp., 2000-2005 * Portions Copyright (C) Christoph Hellwig, 2001-2002 * * This program is free software; you can redistribute it and/or modify @@ -155,8 +155,10 @@ static void jfs_put_super(struct super_b rc = jfs_umount(sb); if (rc) jfs_err("jfs_umount failed with return code %d", rc); - unload_nls(sbi->nls_tab); - sbi->nls_tab = NULL; + if (sbi->nls_tab) { + unload_nls(sbi->nls_tab); + sbi->nls_tab = NULL; + } kfree(sbi); } @@ -182,7 +184,7 @@ s64 jfs_get_volume_size(struct super_blo static int parse_options(char *options, struct super_block *sb, s64 *newLVSize, int *flag) { - void *nls_map = NULL; + void *nls_map = (void *)-1; /* -1: no change; NULL: none */ char *this_char; char *value; struct jfs_sb_info *sbi = JFS_SBI(sb); @@ -222,13 +224,12 @@ static int parse_options(char *options, } else if (!strcmp(this_char, "iocharset")) { if (!value || !*value) goto needs_arg; - if (nls_map) /* specified iocharset twice! */ + if (nls_map && nls_map != (void *) -1) unload_nls(nls_map); - nls_map = load_nls(value); - if (!nls_map) { - printk(KERN_ERR "JFS: charset not found\n"); - goto cleanup; - } + if (!strcmp(value, "none")) + nls_map = NULL; + else + nls_map = load_nls(value); } else if (!strcmp(this_char, "resize")) { if (!value || !*value) { *newLVSize = jfs_get_volume_size(sb); @@ -250,9 +251,9 @@ static int parse_options(char *options, goto cleanup; } } - if (nls_map) { + if (nls_map != (void *) -1) { /* Discard old (if remount) */ - if (sbi->nls_tab) + if (sbi->nls_tab && sbi->nls_tab != (void *) -1) unload_nls(sbi->nls_tab); sbi->nls_tab = nls_map; } @@ -260,7 +261,7 @@ static int parse_options(char *options, needs_arg: printk(KERN_ERR "JFS: %s needs an argument\n", this_char); cleanup: - if (nls_map) + if (nls_map && nls_map != (void *) -1) unload_nls(nls_map); return 0; } @@ -328,6 +329,8 @@ static struct super_block *jfs_read_supe /* initialize the mount flag and determine the default error handler */ flag = JFS_ERR_REMOUNT_RO; + /* nls_tab will be set to NULL if no character mapping is requested */ + sbi->nls_tab = (void *) -1; if (!parse_options((char *) data, sb, &newLVSize, &flag)) { kfree(sbi); return NULL; @@ -378,7 +381,7 @@ static struct super_block *jfs_read_supe if (!sb->s_root) goto out_no_root; - if (!sbi->nls_tab) + if (sbi->nls_tab == (void *) -1) sbi->nls_tab = load_nls_default(); /* logical blocks are represented by 40 bits in pxd_t, etc. */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/nfsd/vfs.c linux-2.4.30-pre2/fs/nfsd/vfs.c --- linux-2.4.29/fs/nfsd/vfs.c 2004-11-17 11:54:21.000000000 +0000 +++ linux-2.4.30-pre2/fs/nfsd/vfs.c 2005-02-23 07:45:21.000000000 +0000 @@ -466,6 +466,8 @@ nfsd_open(struct svc_rqst *rqstp, struct atomic_set(&filp->f_count, 1); filp->f_dentry = dentry; filp->f_vfsmnt = fhp->fh_export->ex_mnt; + filp->f_maxcount = INT_MAX; + if (access & MAY_WRITE) { filp->f_flags = O_WRONLY|O_LARGEFILE; filp->f_mode = FMODE_WRITE; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/proc/kcore.c linux-2.4.30-pre2/fs/proc/kcore.c --- linux-2.4.29/fs/proc/kcore.c 2004-08-07 23:26:06.000000000 +0000 +++ linux-2.4.30-pre2/fs/proc/kcore.c 2005-02-23 07:45:47.000000000 +0000 @@ -136,7 +136,10 @@ static unsigned long get_kcore_size(int } *elf_buflen = sizeof(struct elfhdr) + (*num_vma + 2)*sizeof(struct elf_phdr) + - 3 * sizeof(struct memelfnote); + 3 * (sizeof(struct elf_note) + 4) + + sizeof(struct elf_prstatus) + + sizeof(struct elf_prpsinfo) + + sizeof(struct task_struct); *elf_buflen = PAGE_ALIGN(*elf_buflen); return (size - PAGE_OFFSET + *elf_buflen); } @@ -279,7 +282,7 @@ static void elf_kcore_store_hdr(char *bu memset(&prstatus, 0, sizeof(struct elf_prstatus)); - nhdr->p_filesz = notesize(¬es[0]); + nhdr->p_filesz += notesize(¬es[0]); bufp = storenote(¬es[0], bufp); /* set up the process info */ @@ -296,7 +299,7 @@ static void elf_kcore_store_hdr(char *bu strcpy(prpsinfo.pr_fname, "vmlinux"); strncpy(prpsinfo.pr_psargs, saved_command_line, ELF_PRARGSZ); - nhdr->p_filesz = notesize(¬es[1]); + nhdr->p_filesz += notesize(¬es[1]); bufp = storenote(¬es[1], bufp); /* set up the task structure */ @@ -305,7 +308,7 @@ static void elf_kcore_store_hdr(char *bu notes[2].datasz = sizeof(struct task_struct); notes[2].data = current; - nhdr->p_filesz = notesize(¬es[2]); + nhdr->p_filesz += notesize(¬es[2]); bufp = storenote(¬es[2], bufp); } /* end elf_kcore_store_hdr() */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/fs/read_write.c linux-2.4.30-pre2/fs/read_write.c --- linux-2.4.29/fs/read_write.c 2003-08-25 11:44:43.000000000 +0000 +++ linux-2.4.30-pre2/fs/read_write.c 2005-02-23 07:45:57.000000000 +0000 @@ -40,6 +40,28 @@ ssize_t generic_read_dir(struct file *fi return -EISDIR; } +int rw_verify_area(int read_write, struct file *file, loff_t *ppos, size_t count) +{ + struct inode *inode; + loff_t pos; + + if (unlikely(count > file->f_maxcount)) + goto Einval; + + pos = *ppos; + + if (unlikely((pos < 0) || (loff_t) (pos + count) < 0)) + goto Einval; + + inode = file->f_dentry->d_inode; + if (inode->i_flock && MANDATORY_LOCK(inode)) + return locks_mandatory_area(read_write == READ ? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE, inode, file, *ppos, count); + return 0; + +Einval: + return -EINVAL; +} + loff_t generic_file_llseek(struct file *file, loff_t offset, int origin) { long long retval; @@ -168,8 +190,8 @@ asmlinkage ssize_t sys_read(unsigned int file = fget(fd); if (file) { if (file->f_mode & FMODE_READ) { - ret = locks_verify_area(FLOCK_VERIFY_READ, file->f_dentry->d_inode, - file, file->f_pos, count); + ret = rw_verify_area(READ, file, &file->f_pos, count); + if (!ret) { ssize_t (*read)(struct file *, char *, size_t, loff_t *); ret = -EINVAL; @@ -193,9 +215,7 @@ asmlinkage ssize_t sys_write(unsigned in file = fget(fd); if (file) { if (file->f_mode & FMODE_WRITE) { - struct inode *inode = file->f_dentry->d_inode; - ret = locks_verify_area(FLOCK_VERIFY_WRITE, inode, file, - file->f_pos, count); + ret = rw_verify_area(WRITE, file, &file->f_pos, count); if (!ret) { ssize_t (*write)(struct file *, const char *, size_t, loff_t *); ret = -EINVAL; @@ -224,7 +244,6 @@ static ssize_t do_readv_writev(int type, ssize_t ret, i; io_fn_t fn; iov_fn_t fnv; - struct inode *inode; /* * First get the "struct iovec" from user memory and @@ -275,12 +294,11 @@ static ssize_t do_readv_writev(int type, goto out; } - inode = file->f_dentry->d_inode; /* VERIFY_WRITE actually means a read, as we write to user space */ - ret = locks_verify_area((type == VERIFY_WRITE - ? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE), - inode, file, file->f_pos, tot_len); - if (ret) goto out; + ret = rw_verify_area((type == VERIFY_WRITE ? READ : WRITE), + file, &file->f_pos, tot_len); + if (ret) + goto out; fnv = (type == VERIFY_WRITE ? file->f_op->readv : file->f_op->writev); if (fnv) { @@ -383,8 +401,8 @@ asmlinkage ssize_t sys_pread(unsigned in goto bad_file; if (!(file->f_mode & FMODE_READ)) goto out; - ret = locks_verify_area(FLOCK_VERIFY_READ, file->f_dentry->d_inode, - file, pos, count); + ret = rw_verify_area(READ, file, &pos, count); + if (ret) goto out; ret = -EINVAL; @@ -414,8 +432,8 @@ asmlinkage ssize_t sys_pwrite(unsigned i goto bad_file; if (!(file->f_mode & FMODE_WRITE)) goto out; - ret = locks_verify_area(FLOCK_VERIFY_WRITE, file->f_dentry->d_inode, - file, pos, count); + ret = rw_verify_area(WRITE, file, &pos, count); + if (ret) goto out; ret = -EINVAL; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/asm-ppc/processor.h linux-2.4.30-pre2/include/asm-ppc/processor.h --- linux-2.4.29/include/asm-ppc/processor.h 2004-04-14 13:05:40.000000000 +0000 +++ linux-2.4.30-pre2/include/asm-ppc/processor.h 2005-02-23 07:44:57.000000000 +0000 @@ -678,7 +678,7 @@ #define PVR_440GP_RC2 0x40200481 #define PVR_440GX_RA 0x51b21850 #define PVR_440GX_RB 0x51b21851 -#define PVR_440GX_RB1 0x51b21852 +#define PVR_440GX_RC 0x51b21892 #define PVR_601 0x00010000 #define PVR_602 0x00050000 #define PVR_603 0x00030000 diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/asm-sparc/system.h linux-2.4.30-pre2/include/asm-sparc/system.h --- linux-2.4.29/include/asm-sparc/system.h 2004-02-18 13:36:32.000000000 +0000 +++ linux-2.4.30-pre2/include/asm-sparc/system.h 2005-02-23 07:46:07.000000000 +0000 @@ -295,11 +295,11 @@ extern void __global_restore_flags(unsig #define wmb() mb() #define set_mb(__var, __value) do { __var = __value; mb(); } while(0) #define set_wmb(__var, __value) set_mb(__var, __value) -#define smp_mb() __asm__ __volatile__("":::"memory"); -#define smp_rmb() __asm__ __volatile__("":::"memory"); -#define smp_wmb() __asm__ __volatile__("":::"memory"); +#define smp_mb() __asm__ __volatile__("":::"memory") +#define smp_rmb() __asm__ __volatile__("":::"memory") +#define smp_wmb() __asm__ __volatile__("":::"memory") -#define nop() __asm__ __volatile__ ("nop"); +#define nop() __asm__ __volatile__ ("nop") /* This has special calling conventions */ #ifndef CONFIG_SMP diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/asm-sparc64/atomic.h linux-2.4.30-pre2/include/asm-sparc64/atomic.h --- linux-2.4.29/include/asm-sparc64/atomic.h 2001-07-20 01:11:13.000000000 +0000 +++ linux-2.4.30-pre2/include/asm-sparc64/atomic.h 2005-02-23 07:46:32.000000000 +0000 @@ -8,31 +8,59 @@ #ifndef __ARCH_SPARC64_ATOMIC__ #define __ARCH_SPARC64_ATOMIC__ +#include + typedef struct { volatile int counter; } atomic_t; #define ATOMIC_INIT(i) { (i) } #define atomic_read(v) ((v)->counter) #define atomic_set(v, i) (((v)->counter) = i) -extern int __atomic_add(int, atomic_t *); -extern int __atomic_sub(int, atomic_t *); +extern void atomic_add(int, atomic_t *); +extern void atomic_sub(int, atomic_t *); + +extern int atomic_add_ret(int, atomic_t *); +extern int atomic_sub_ret(int, atomic_t *); + +#define atomic_dec_return(v) atomic_sub_ret(1, v) + +#define atomic_inc_return(v) atomic_add_ret(1, v) + +#define atomic_sub_return(i, v) atomic_sub_ret(i, v) + +#define atomic_add_return(i, v) atomic_add_ret(i, v) + +/* + * atomic_inc_and_test - increment and test + * @v: pointer of type atomic_t + * + * Atomically increments @v by 1 + * and returns true if the result is zero, or false for all + * other cases. + */ +#define atomic_inc_and_test(v) (atomic_inc_return(v) == 0) + +#define atomic_sub_and_test(i, v) (atomic_sub_ret(i, v) == 0) -#define atomic_add(i, v) ((void)__atomic_add(i, v)) -#define atomic_sub(i, v) ((void)__atomic_sub(i, v)) +#define atomic_dec_and_test(v) (atomic_sub_ret(1, v) == 0) -#define atomic_dec_return(v) __atomic_sub(1, v) -#define atomic_inc_return(v) __atomic_add(1, v) +#define atomic_inc(v) atomic_add(1, v) -#define atomic_sub_and_test(i, v) (__atomic_sub(i, v) == 0) -#define atomic_dec_and_test(v) (__atomic_sub(1, v) == 0) +#define atomic_dec(v) atomic_sub(1, v) -#define atomic_inc(v) ((void)__atomic_add(1, v)) -#define atomic_dec(v) ((void)__atomic_sub(1, v)) +#define atomic_add_negative(i, v) (atomic_add_ret(i, v) < 0) /* Atomic operations are already serializing */ +#ifdef CONFIG_SMP +#define smp_mb__before_atomic_dec() membar("#StoreLoad | #LoadLoad") +#define smp_mb__after_atomic_dec() membar("#StoreLoad | #StoreStore") +#define smp_mb__before_atomic_inc() membar("#StoreLoad | #LoadLoad") +#define smp_mb__after_atomic_inc() membar("#StoreLoad | #StoreStore") +#else #define smp_mb__before_atomic_dec() barrier() #define smp_mb__after_atomic_dec() barrier() #define smp_mb__before_atomic_inc() barrier() #define smp_mb__after_atomic_inc() barrier() +#endif #endif /* !(__ARCH_SPARC64_ATOMIC__) */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/asm-sparc64/bitops.h linux-2.4.30-pre2/include/asm-sparc64/bitops.h --- linux-2.4.29/include/asm-sparc64/bitops.h 2001-12-21 17:42:03.000000000 +0000 +++ linux-2.4.30-pre2/include/asm-sparc64/bitops.h 2005-02-23 07:44:59.000000000 +0000 @@ -1,4 +1,4 @@ -/* $Id: bitops.h,v 1.38 2001/11/19 18:36:34 davem Exp $ +/* $Id: bitops.h,v 1.39 2002/01/30 01:40:00 davem Exp $ * bitops.h: Bit string operations on the V9. * * Copyright 1996, 1997 David S. Miller (davem@caip.rutgers.edu) @@ -7,114 +7,126 @@ #ifndef _SPARC64_BITOPS_H #define _SPARC64_BITOPS_H +#include +#include #include -extern long ___test_and_set_bit(unsigned long nr, volatile void *addr); -extern long ___test_and_clear_bit(unsigned long nr, volatile void *addr); -extern long ___test_and_change_bit(unsigned long nr, volatile void *addr); - -#define test_and_set_bit(nr,addr) ({___test_and_set_bit(nr,addr)!=0;}) -#define test_and_clear_bit(nr,addr) ({___test_and_clear_bit(nr,addr)!=0;}) -#define test_and_change_bit(nr,addr) ({___test_and_change_bit(nr,addr)!=0;}) -#define set_bit(nr,addr) ((void)___test_and_set_bit(nr,addr)) -#define clear_bit(nr,addr) ((void)___test_and_clear_bit(nr,addr)) -#define change_bit(nr,addr) ((void)___test_and_change_bit(nr,addr)) +extern int test_and_set_bit(unsigned long nr, volatile void *addr); +extern int test_and_clear_bit(unsigned long nr, volatile void *addr); +extern int test_and_change_bit(unsigned long nr, volatile void *addr); +extern void set_bit(unsigned long nr, volatile void *addr); +extern void clear_bit(unsigned long nr, volatile void *addr); +extern void change_bit(unsigned long nr, volatile void *addr); /* "non-atomic" versions... */ -#define __set_bit(X,Y) \ -do { unsigned long __nr = (X); \ - long *__m = ((long *) (Y)) + (__nr >> 6); \ - *__m |= (1UL << (__nr & 63)); \ -} while (0) -#define __clear_bit(X,Y) \ -do { unsigned long __nr = (X); \ - long *__m = ((long *) (Y)) + (__nr >> 6); \ - *__m &= ~(1UL << (__nr & 63)); \ -} while (0) -#define __change_bit(X,Y) \ -do { unsigned long __nr = (X); \ - long *__m = ((long *) (Y)) + (__nr >> 6); \ - *__m ^= (1UL << (__nr & 63)); \ -} while (0) -#define __test_and_set_bit(X,Y) \ -({ unsigned long __nr = (X); \ - long *__m = ((long *) (Y)) + (__nr >> 6); \ - long __old = *__m; \ - long __mask = (1UL << (__nr & 63)); \ - *__m = (__old | __mask); \ - ((__old & __mask) != 0); \ -}) -#define __test_and_clear_bit(X,Y) \ -({ unsigned long __nr = (X); \ - long *__m = ((long *) (Y)) + (__nr >> 6); \ - long __old = *__m; \ - long __mask = (1UL << (__nr & 63)); \ - *__m = (__old & ~__mask); \ - ((__old & __mask) != 0); \ -}) -#define __test_and_change_bit(X,Y) \ -({ unsigned long __nr = (X); \ - long *__m = ((long *) (Y)) + (__nr >> 6); \ - long __old = *__m; \ - long __mask = (1UL << (__nr & 63)); \ - *__m = (__old ^ __mask); \ - ((__old & __mask) != 0); \ -}) -#define smp_mb__before_clear_bit() do { } while(0) -#define smp_mb__after_clear_bit() do { } while(0) +static __inline__ void __set_bit(int nr, volatile void *addr) +{ + unsigned long *m; + + m = ((unsigned long *)addr) + (nr >> 6); + *m |= (1UL << (nr & 63)); +} + +static __inline__ void __clear_bit(int nr, volatile void *addr) +{ + unsigned long *m; + + m = ((unsigned long *)addr) + (nr >> 6); + *m &= ~(1UL << (nr & 63)); +} -extern __inline__ int test_bit(int nr, __const__ void *addr) +static __inline__ void __change_bit(int nr, volatile void *addr) { - return (1UL & (((__const__ long *) addr)[nr >> 6] >> (nr & 63))) != 0UL; + unsigned long *m; + + m = ((unsigned long *)addr) + (nr >> 6); + *m ^= (1UL << (nr & 63)); +} + +static __inline__ int __test_and_set_bit(int nr, volatile void *addr) +{ + unsigned long *m = ((unsigned long *)addr) + (nr >> 6); + unsigned long old = *m; + unsigned long mask = (1UL << (nr & 63)); + + *m = (old | mask); + return ((old & mask) != 0); +} + +static __inline__ int __test_and_clear_bit(int nr, volatile void *addr) +{ + unsigned long *m = ((unsigned long *)addr) + (nr >> 6); + unsigned long old = *m; + unsigned long mask = (1UL << (nr & 63)); + + *m = (old & ~mask); + return ((old & mask) != 0); +} + +static __inline__ int __test_and_change_bit(int nr, volatile void *addr) +{ + unsigned long *m = ((unsigned long *)addr) + (nr >> 6); + unsigned long old = *m; + unsigned long mask = (1UL << (nr & 63)); + + *m = (old ^ mask); + return ((old & mask) != 0); +} + +#ifdef CONFIG_SMP +#define smp_mb__before_clear_bit() membar("#StoreLoad | #LoadLoad") +#define smp_mb__after_clear_bit() membar("#StoreLoad | #StoreStore") +#else +#define smp_mb__before_clear_bit() barrier() +#define smp_mb__after_clear_bit() barrier() +#endif + +static __inline__ int test_bit(int nr, __const__ volatile void *_addr) +{ + __const__ unsigned long *addr; + + addr = (__const__ unsigned long *) _addr; + + return (1UL & ((addr)[nr >> 6] >> (nr & 63))) != 0UL; } /* The easy/cheese version for now. */ -extern __inline__ unsigned long ffz(unsigned long word) +static __inline__ unsigned long ffz(unsigned long word) { unsigned long result; -#ifdef ULTRA_HAS_POPULATION_COUNT /* Thanks for nothing Sun... */ - __asm__ __volatile__( -" brz,pn %0, 1f\n" -" neg %0, %%g1\n" -" xnor %0, %%g1, %%g2\n" -" popc %%g2, %0\n" -"1: " : "=&r" (result) - : "0" (word) - : "g1", "g2"); -#else -#if 1 /* def EASY_CHEESE_VERSION */ result = 0; while(word & 1) { result++; word >>= 1; } -#else - unsigned long tmp; + return result; +} - result = 0; - tmp = ~word & -~word; - if (!(unsigned)tmp) { - tmp >>= 32; - result = 32; - } - if (!(unsigned short)tmp) { - tmp >>= 16; - result += 16; - } - if (!(unsigned char)tmp) { - tmp >>= 8; - result += 8; +/** + * __ffs - find first bit in word. + * @word: The word to search + * + * Undefined if no bit exists, so code should check against 0 first. + */ +static __inline__ unsigned long __ffs(unsigned long word) +{ + unsigned long result = 0; + + while (!(word & 1UL)) { + result++; + word >>= 1; } - if (tmp & 0xf0) result += 4; - if (tmp & 0xcc) result += 2; - if (tmp & 0xaa) result ++; -#endif -#endif return result; } +/* + * fls: find last bit set. + */ + +#define fls(x) generic_fls(x) + #ifdef __KERNEL__ /* @@ -122,8 +134,12 @@ extern __inline__ unsigned long ffz(unsi * the libc and compiler builtin ffs routines, therefore * differs in spirit from the above ffz (man ffs). */ - -#define ffs(x) generic_ffs(x) +static __inline__ int ffs(int x) +{ + if (!x) + return 0; + return __ffs((unsigned long)x) + 1; +} /* * hweightN: returns the hamming weight (i.e. the number @@ -132,7 +148,15 @@ extern __inline__ unsigned long ffz(unsi #ifdef ULTRA_HAS_POPULATION_COUNT -extern __inline__ unsigned int hweight32(unsigned int w) +static __inline__ unsigned int hweight64(unsigned long w) +{ + unsigned int res; + + __asm__ ("popc %1,%0" : "=r" (res) : "r" (w)); + return res; +} + +static __inline__ unsigned int hweight32(unsigned int w) { unsigned int res; @@ -140,7 +164,7 @@ extern __inline__ unsigned int hweight32 return res; } -extern __inline__ unsigned int hweight16(unsigned int w) +static __inline__ unsigned int hweight16(unsigned int w) { unsigned int res; @@ -148,7 +172,7 @@ extern __inline__ unsigned int hweight16 return res; } -extern __inline__ unsigned int hweight8(unsigned int w) +static __inline__ unsigned int hweight8(unsigned int w) { unsigned int res; @@ -158,6 +182,7 @@ extern __inline__ unsigned int hweight8( #else +#define hweight64(x) generic_hweight64(x) #define hweight32(x) generic_hweight32(x) #define hweight16(x) generic_hweight16(x) #define hweight8(x) generic_hweight8(x) @@ -170,7 +195,7 @@ extern __inline__ unsigned int hweight8( * on Linus's ALPHA routines, which are pretty portable BTW. */ -extern __inline__ unsigned long find_next_zero_bit(void *addr, unsigned long size, unsigned long offset) +static __inline__ unsigned long find_next_zero_bit(void *addr, unsigned long size, unsigned long offset) { unsigned long *p = ((unsigned long *) addr) + (offset >> 6); unsigned long result = offset & ~63UL; @@ -211,15 +236,12 @@ found_middle: #define find_first_zero_bit(addr, size) \ find_next_zero_bit((addr), (size), 0) -extern long ___test_and_set_le_bit(int nr, volatile void *addr); -extern long ___test_and_clear_le_bit(int nr, volatile void *addr); - -#define test_and_set_le_bit(nr,addr) ({___test_and_set_le_bit(nr,addr)!=0;}) -#define test_and_clear_le_bit(nr,addr) ({___test_and_clear_le_bit(nr,addr)!=0;}) -#define set_le_bit(nr,addr) ((void)___test_and_set_le_bit(nr,addr)) -#define clear_le_bit(nr,addr) ((void)___test_and_clear_le_bit(nr,addr)) +#define test_and_set_le_bit(nr,addr) \ + test_and_set_bit((nr) ^ 0x38, (addr)) +#define test_and_clear_le_bit(nr,addr) \ + test_and_clear_bit((nr) ^ 0x38, (addr)) -extern __inline__ int test_le_bit(int nr, __const__ void * addr) +static __inline__ int test_le_bit(int nr, __const__ void *addr) { int mask; __const__ unsigned char *ADDR = (__const__ unsigned char *) addr; @@ -232,7 +254,7 @@ extern __inline__ int test_le_bit(int nr #define find_first_zero_le_bit(addr, size) \ find_next_zero_le_bit((addr), (size), 0) -extern __inline__ unsigned long find_next_zero_le_bit(void *addr, unsigned long size, unsigned long offset) +static __inline__ unsigned long find_next_zero_le_bit(void *addr, unsigned long size, unsigned long offset) { unsigned long *p = ((unsigned long *) addr) + (offset >> 6); unsigned long result = offset & ~63UL; @@ -271,18 +293,41 @@ found_middle: #ifdef __KERNEL__ -#define ext2_set_bit test_and_set_le_bit -#define ext2_clear_bit test_and_clear_le_bit -#define ext2_test_bit test_le_bit -#define ext2_find_first_zero_bit find_first_zero_le_bit -#define ext2_find_next_zero_bit find_next_zero_le_bit +#define __set_le_bit(nr, addr) \ + __set_bit((nr) ^ 0x38, (addr)) +#define __clear_le_bit(nr, addr) \ + __clear_bit((nr) ^ 0x38, (addr)) +#define __test_and_clear_le_bit(nr, addr) \ + __test_and_clear_bit((nr) ^ 0x38, (addr)) +#define __test_and_set_le_bit(nr, addr) \ + __test_and_set_bit((nr) ^ 0x38, (addr)) + +#define ext2_set_bit(nr,addr) \ + __test_and_set_le_bit((nr),(unsigned long *)(addr)) +#define ext2_set_bit_atomic(lock,nr,addr) \ + test_and_set_le_bit((nr),(unsigned long *)(addr)) +#define ext2_clear_bit(nr,addr) \ + __test_and_clear_le_bit((nr),(unsigned long *)(addr)) +#define ext2_clear_bit_atomic(lock,nr,addr) \ + test_and_clear_le_bit((nr),(unsigned long *)(addr)) +#define ext2_test_bit(nr,addr) \ + test_le_bit((nr),(unsigned long *)(addr)) +#define ext2_find_first_zero_bit(addr, size) \ + find_first_zero_le_bit((unsigned long *)(addr), (size)) +#define ext2_find_next_zero_bit(addr, size, off) \ + find_next_zero_le_bit((unsigned long *)(addr), (size), (off)) /* Bitmap functions for the minix filesystem. */ -#define minix_test_and_set_bit(nr,addr) test_and_set_bit(nr,addr) -#define minix_set_bit(nr,addr) set_bit(nr,addr) -#define minix_test_and_clear_bit(nr,addr) test_and_clear_bit(nr,addr) -#define minix_test_bit(nr,addr) test_bit(nr,addr) -#define minix_find_first_zero_bit(addr,size) find_first_zero_bit(addr,size) +#define minix_test_and_set_bit(nr,addr) \ + test_and_set_bit((nr),(unsigned long *)(addr)) +#define minix_set_bit(nr,addr) \ + set_bit((nr),(unsigned long *)(addr)) +#define minix_test_and_clear_bit(nr,addr) \ + test_and_clear_bit((nr),(unsigned long *)(addr)) +#define minix_test_bit(nr,addr) \ + test_bit((nr),(unsigned long *)(addr)) +#define minix_find_first_zero_bit(addr,size) \ + find_first_zero_bit((unsigned long *)(addr),(size)) #endif /* __KERNEL__ */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/asm-sparc64/system.h linux-2.4.30-pre2/include/asm-sparc64/system.h --- linux-2.4.29/include/asm-sparc64/system.h 2003-06-13 14:51:38.000000000 +0000 +++ linux-2.4.30-pre2/include/asm-sparc64/system.h 2005-02-23 07:44:57.000000000 +0000 @@ -106,9 +106,9 @@ extern void __global_restore_flags(unsig #define nop() __asm__ __volatile__ ("nop") -#define membar(type) __asm__ __volatile__ ("membar " type : : : "memory"); +#define membar(type) __asm__ __volatile__ ("membar " type : : : "memory") #define mb() \ - membar("#LoadLoad | #LoadStore | #StoreStore | #StoreLoad"); + membar("#LoadLoad | #LoadStore | #StoreStore | #StoreLoad") #define rmb() membar("#LoadLoad") #define wmb() membar("#StoreStore") #define set_mb(__var, __value) \ @@ -121,9 +121,9 @@ extern void __global_restore_flags(unsig #define smp_rmb() rmb() #define smp_wmb() wmb() #else -#define smp_mb() __asm__ __volatile__("":::"memory"); -#define smp_rmb() __asm__ __volatile__("":::"memory"); -#define smp_wmb() __asm__ __volatile__("":::"memory"); +#define smp_mb() __asm__ __volatile__("":::"memory") +#define smp_rmb() __asm__ __volatile__("":::"memory") +#define smp_wmb() __asm__ __volatile__("":::"memory") #endif #define flushi(addr) __asm__ __volatile__ ("flush %0" : : "r" (addr) : "memory") @@ -246,6 +246,7 @@ do { CHECK_LOCKS(prev); \ extern __inline__ unsigned long xchg32(__volatile__ unsigned int *m, unsigned int val) { __asm__ __volatile__( +" membar #StoreLoad | #LoadLoad\n" " mov %0, %%g5\n" "1: lduw [%2], %%g7\n" " cas [%2], %%g7, %0\n" @@ -262,6 +263,7 @@ extern __inline__ unsigned long xchg32(_ extern __inline__ unsigned long xchg64(__volatile__ unsigned long *m, unsigned long val) { __asm__ __volatile__( +" membar #StoreLoad | #LoadLoad\n" " mov %0, %%g5\n" "1: ldx [%2], %%g7\n" " casx [%2], %%g7, %0\n" @@ -306,7 +308,8 @@ extern void die_if_kernel(char *str, str extern __inline__ unsigned long __cmpxchg_u32(volatile int *m, int old, int new) { - __asm__ __volatile__("cas [%2], %3, %0\n\t" + __asm__ __volatile__("membar #StoreLoad | #LoadLoad\n" + "cas [%2], %3, %0\n\t" "membar #StoreLoad | #StoreStore" : "=&r" (new) : "0" (new), "r" (m), "r" (old) @@ -318,7 +321,8 @@ __cmpxchg_u32(volatile int *m, int old, extern __inline__ unsigned long __cmpxchg_u64(volatile long *m, unsigned long old, unsigned long new) { - __asm__ __volatile__("casx [%2], %3, %0\n\t" + __asm__ __volatile__("membar #StoreLoad | #LoadLoad\n" + "casx [%2], %3, %0\n\t" "membar #StoreLoad | #StoreStore" : "=&r" (new) : "0" (new), "r" (m), "r" (old) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/linux/ata.h linux-2.4.30-pre2/include/linux/ata.h --- linux-2.4.29/include/linux/ata.h 2005-01-19 14:10:12.000000000 +0000 +++ linux-2.4.30-pre2/include/linux/ata.h 2005-02-23 07:44:59.000000000 +0000 @@ -123,6 +123,8 @@ enum { ATA_CMD_PIO_WRITE_EXT = 0x34, ATA_CMD_SET_FEATURES = 0xEF, ATA_CMD_PACKET = 0xA0, + ATA_CMD_VERIFY = 0x40, + ATA_CMD_VERIFY_EXT = 0x42, /* SETFEATURES stuff */ SETFEATURES_XFER = 0x03, diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/linux/brlock.h linux-2.4.30-pre2/include/linux/brlock.h --- linux-2.4.29/include/linux/brlock.h 2002-11-28 23:53:15.000000000 +0000 +++ linux-2.4.30-pre2/include/linux/brlock.h 2005-02-23 07:45:19.000000000 +0000 @@ -18,16 +18,6 @@ * Registry idea and naming [ crutial! :-) ] by: * * David S. Miller - * - * David has an implementation that doesn't use atomic operations in - * the read branch via memory ordering tricks - i guess we need to - * split this up into a per-arch thing? The atomicity issue is a - * secondary item in profiles, at least on x86 platforms. - * - * The atomic op version overhead is indeed a big deal on - * load-locked/store-conditional cpus (ALPHA/MIPS/PPC) and - * compare-and-swap cpus (Sparc64). So we control which - * implementation to use with a __BRLOCK_USE_ATOMICS define. -DaveM */ /* Register bigreader lock indices here. */ @@ -45,17 +35,7 @@ enum brlock_indices { #include #include -#if defined(__i386__) || defined(__ia64__) || defined(__x86_64__) -#define __BRLOCK_USE_ATOMICS -#else -#undef __BRLOCK_USE_ATOMICS -#endif - -#ifdef __BRLOCK_USE_ATOMICS -typedef rwlock_t brlock_read_lock_t; -#else typedef unsigned int brlock_read_lock_t; -#endif /* * align last allocated index to the next cacheline: @@ -65,39 +45,14 @@ typedef unsigned int brlock_read_lock_t; extern brlock_read_lock_t __brlock_array[NR_CPUS][__BR_IDX_MAX]; -#ifndef __BRLOCK_USE_ATOMICS struct br_wrlock { spinlock_t lock; } __attribute__ ((__aligned__(SMP_CACHE_BYTES))); extern struct br_wrlock __br_write_locks[__BR_IDX_MAX]; -#endif extern void __br_lock_usage_bug (void); -#ifdef __BRLOCK_USE_ATOMICS - -static inline void br_read_lock (enum brlock_indices idx) -{ - /* - * This causes a link-time bug message if an - * invalid index is used: - */ - if (idx >= __BR_END) - __br_lock_usage_bug(); - - read_lock(&__brlock_array[smp_processor_id()][idx]); -} - -static inline void br_read_unlock (enum brlock_indices idx) -{ - if (idx >= __BR_END) - __br_lock_usage_bug(); - - read_unlock(&__brlock_array[smp_processor_id()][idx]); -} - -#else /* ! __BRLOCK_USE_ATOMICS */ static inline void br_read_lock (enum brlock_indices idx) { unsigned int *ctr; @@ -149,7 +104,6 @@ static inline void br_read_unlock (enum wmb(); (*ctr)--; } -#endif /* __BRLOCK_USE_ATOMICS */ /* write path not inlined - it's rare and larger */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/linux/fs.h linux-2.4.30-pre2/include/linux/fs.h --- linux-2.4.29/include/linux/fs.h 2004-11-17 11:54:22.000000000 +0000 +++ linux-2.4.30-pre2/include/linux/fs.h 2005-02-23 07:45:01.000000000 +0000 @@ -576,6 +576,7 @@ struct file { unsigned int f_uid, f_gid; int f_error; + size_t f_maxcount; unsigned long f_version; /* needed for tty driver, and maybe others */ @@ -1056,14 +1057,7 @@ static inline int locks_verify_locked(st return 0; } -static inline int locks_verify_area(int read_write, struct inode *inode, - struct file *filp, loff_t offset, - size_t count) -{ - if (inode->i_flock && MANDATORY_LOCK(inode)) - return locks_mandatory_area(read_write, inode, filp, offset, count); - return 0; -} +extern int rw_verify_area(int, struct file *, loff_t *, size_t); static inline int locks_verify_truncate(struct inode *inode, struct file *filp, diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/linux/libata.h linux-2.4.30-pre2/include/linux/libata.h --- linux-2.4.29/include/linux/libata.h 2005-01-19 14:10:12.000000000 +0000 +++ linux-2.4.30-pre2/include/linux/libata.h 2005-02-23 07:46:15.000000000 +0000 @@ -435,8 +435,6 @@ struct pci_bits { extern struct ata_probe_ent * ata_pci_init_native_mode(struct pci_dev *pdev, struct ata_port_info **port); -extern struct ata_probe_ent * -ata_pci_init_legacy_mode(struct pci_dev *pdev, struct ata_port_info **port); extern int pci_test_config_bits(struct pci_dev *pdev, struct pci_bits *bits); #endif /* CONFIG_PCI */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/linux/netfilter_ipv4/ip_conntrack.h linux-2.4.30-pre2/include/linux/netfilter_ipv4/ip_conntrack.h --- linux-2.4.29/include/linux/netfilter_ipv4/ip_conntrack.h 2004-11-17 11:54:22.000000000 +0000 +++ linux-2.4.30-pre2/include/linux/netfilter_ipv4/ip_conntrack.h 2005-02-23 07:46:32.000000000 +0000 @@ -249,10 +249,9 @@ extern void ip_ct_refresh(struct ip_conn /* Call me when a conntrack is destroyed. */ extern void (*ip_conntrack_destroyed)(struct ip_conntrack *conntrack); -extern int ip_ct_no_defrag; /* Returns new sk_buff, or NULL */ struct sk_buff * -ip_ct_gather_frags(struct sk_buff *skb); +ip_ct_gather_frags(struct sk_buff *skb, u_int32_t user); /* Delete all conntracks which match. */ extern void diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/linux/netlink.h linux-2.4.30-pre2/include/linux/netlink.h --- linux-2.4.29/include/linux/netlink.h 2005-01-19 14:10:12.000000000 +0000 +++ linux-2.4.30-pre2/include/linux/netlink.h 2005-02-23 07:46:24.000000000 +0000 @@ -117,10 +117,9 @@ extern int netlink_proto_init(void); /* * skb should fit one page. This choice is good for headerless malloc. - * - * FIXME: What is the best size for SLAB???? --ANK */ -#define NLMSG_GOODSIZE (PAGE_SIZE - ((sizeof(struct sk_buff)+0xF)&~0xF)) +#define NLMSG_GOODORDER 0 +#define NLMSG_GOODSIZE (SKB_MAX_ORDER(0, NLMSG_GOODORDER)) struct netlink_callback diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/linux/pci_ids.h linux-2.4.30-pre2/include/linux/pci_ids.h --- linux-2.4.29/include/linux/pci_ids.h 2005-01-19 14:10:12.000000000 +0000 +++ linux-2.4.30-pre2/include/linux/pci_ids.h 2005-02-23 07:45:24.000000000 +0000 @@ -1937,7 +1937,6 @@ #define PCI_DEVICE_ID_INTEL_82801EB_5 0x24d5 #define PCI_DEVICE_ID_INTEL_82801EB_6 0x24d6 #define PCI_DEVICE_ID_INTEL_82801EB_7 0x24d7 -#define PCI_DEVICE_ID_INTEL_82801DB_10 0x24ca #define PCI_DEVICE_ID_INTEL_82801EB_11 0x24db #define PCI_DEVICE_ID_INTEL_82801EB_13 0x24dd #define PCI_DEVICE_ID_INTEL_ESB_0 0x25a0 diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/linux/skbuff.h linux-2.4.30-pre2/include/linux/skbuff.h --- linux-2.4.29/include/linux/skbuff.h 2004-08-07 23:26:06.000000000 +0000 +++ linux-2.4.30-pre2/include/linux/skbuff.h 2005-02-23 07:44:58.000000000 +0000 @@ -290,15 +290,11 @@ static inline struct sk_buff *skb_get(st static inline void kfree_skb(struct sk_buff *skb) { - if (atomic_read(&skb->users) == 1 || atomic_dec_and_test(&skb->users)) - __kfree_skb(skb); -} - -/* Use this if you didn't touch the skb state [for fast switching] */ -static inline void kfree_skb_fast(struct sk_buff *skb) -{ - if (atomic_read(&skb->users) == 1 || atomic_dec_and_test(&skb->users)) - kfree_skbmem(skb); + if (likely(atomic_read(&skb->users) == 1)) + smp_rmb(); + else if (likely(!atomic_dec_and_test(&skb->users))) + return; + __kfree_skb(skb); } /** diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/linux/sysctl.h linux-2.4.30-pre2/include/linux/sysctl.h --- linux-2.4.29/include/linux/sysctl.h 2005-01-19 14:10:13.000000000 +0000 +++ linux-2.4.30-pre2/include/linux/sysctl.h 2005-02-23 07:44:57.000000000 +0000 @@ -326,6 +326,7 @@ enum NET_TCP_BIC_LOW_WINDOW=104, NET_TCP_DEFAULT_WIN_SCALE=105, NET_TCP_MODERATE_RCVBUF=106, + NET_TCP_BIC_BETA=108, }; enum { diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/net/dst.h linux-2.4.30-pre2/include/net/dst.h --- linux-2.4.29/include/net/dst.h 2003-08-25 11:44:44.000000000 +0000 +++ linux-2.4.30-pre2/include/net/dst.h 2005-02-23 07:46:32.000000000 +0000 @@ -104,8 +104,10 @@ struct dst_entry * dst_clone(struct dst_ static inline void dst_release(struct dst_entry * dst) { - if (dst) + if (dst) { + smp_mb__before_atomic_dec(); atomic_dec(&dst->__refcnt); + } } extern void * dst_alloc(struct dst_ops * ops); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/net/ip.h linux-2.4.30-pre2/include/net/ip.h --- linux-2.4.29/include/net/ip.h 2005-01-19 14:10:13.000000000 +0000 +++ linux-2.4.30-pre2/include/net/ip.h 2005-02-23 07:46:05.000000000 +0000 @@ -227,9 +227,19 @@ extern int ip_call_ra_chain(struct sk_bu /* * Functions provided by ip_fragment.o */ - -struct sk_buff *ip_defrag(struct sk_buff *skb); -extern void ipfrag_flush(void); + +enum ip_defrag_users +{ + IP_DEFRAG_LOCAL_DELIVER, + IP_DEFRAG_CALL_RA_CHAIN, + IP_DEFRAG_CONNTRACK_IN, + IP_DEFRAG_CONNTRACK_OUT, + IP_DEFRAG_NAT_OUT, + IP_DEFRAG_VS_OUT, + IP_DEFRAG_VS_FWD +}; + +struct sk_buff *ip_defrag(struct sk_buff *skb, u32 user); extern int ip_frag_nqueues; extern atomic_t ip_frag_mem; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/include/net/tcp.h linux-2.4.30-pre2/include/net/tcp.h --- linux-2.4.29/include/net/tcp.h 2004-11-17 11:54:22.000000000 +0000 +++ linux-2.4.30-pre2/include/net/tcp.h 2005-02-23 07:44:59.000000000 +0000 @@ -395,9 +395,8 @@ static __inline__ int tcp_sk_listen_hash # define TCP_TW_RECYCLE_TICK (12+2-TCP_TW_RECYCLE_SLOTS_LOG) #endif -#define BICTCP_1_OVER_BETA 8 /* - * Fast recovery - * multiplicative decrease factor +#define BICTCP_BETA_SCALE 1024 /* Scale factor beta calculation + * max_cwnd = snd_cwnd * beta */ #define BICTCP_MAX_INCREMENT 32 /* * Limit on the amount of @@ -491,6 +490,7 @@ extern int sysctl_tcp_nometrics_save; extern int sysctl_tcp_bic; extern int sysctl_tcp_bic_fast_convergence; extern int sysctl_tcp_bic_low_window; +extern int sysctl_tcp_bic_beta; extern int sysctl_tcp_default_win_scale; extern int sysctl_tcp_moderate_rcvbuf; @@ -1132,15 +1132,16 @@ static inline __u32 tcp_recalc_ssthresh( if (tcp_is_bic(tp)) { if (sysctl_tcp_bic_fast_convergence && tp->snd_cwnd < tp->bictcp.last_max_cwnd) - tp->bictcp.last_max_cwnd - = (tp->snd_cwnd * (2*BICTCP_1_OVER_BETA-1)) - / (BICTCP_1_OVER_BETA/2); + tp->bictcp.last_max_cwnd = (tp->snd_cwnd * + (BICTCP_BETA_SCALE + + sysctl_tcp_bic_beta)) + / (2 * BICTCP_BETA_SCALE); else tp->bictcp.last_max_cwnd = tp->snd_cwnd; if (tp->snd_cwnd > sysctl_tcp_bic_low_window) - return max(tp->snd_cwnd - (tp->snd_cwnd/BICTCP_1_OVER_BETA), - 2U); + return max((tp->snd_cwnd * sysctl_tcp_bic_beta) + / BICTCP_BETA_SCALE, 2U); } return max(tp->snd_cwnd >> 1U, 2U); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/lib/brlock.c linux-2.4.30-pre2/lib/brlock.c --- linux-2.4.29/lib/brlock.c 2004-11-17 11:54:22.000000000 +0000 +++ linux-2.4.30-pre2/lib/brlock.c 2005-02-23 07:46:06.000000000 +0000 @@ -15,29 +15,6 @@ #include #include -#ifdef __BRLOCK_USE_ATOMICS - -brlock_read_lock_t __brlock_array[NR_CPUS][__BR_IDX_MAX] = - { [0 ... NR_CPUS-1] = { [0 ... __BR_IDX_MAX-1] = RW_LOCK_UNLOCKED } }; - -void fastcall __br_write_lock (enum brlock_indices idx) -{ - int i; - - for (i = 0; i < smp_num_cpus; i++) - write_lock(&__brlock_array[cpu_logical_map(i)][idx]); -} - -void fastcall __br_write_unlock (enum brlock_indices idx) -{ - int i; - - for (i = 0; i < smp_num_cpus; i++) - write_unlock(&__brlock_array[cpu_logical_map(i)][idx]); -} - -#else /* ! __BRLOCK_USE_ATOMICS */ - brlock_read_lock_t __brlock_array[NR_CPUS][__BR_IDX_MAX] = { [0 ... NR_CPUS-1] = { [0 ... __BR_IDX_MAX-1] = 0 } }; @@ -64,6 +41,4 @@ void fastcall __br_write_unlock (enum br spin_unlock(&__br_write_locks[idx].lock); } -#endif /* __BRLOCK_USE_ATOMICS */ - #endif /* CONFIG_SMP */ diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/mm/filemap.c linux-2.4.30-pre2/mm/filemap.c --- linux-2.4.29/mm/filemap.c 2004-11-17 11:54:22.000000000 +0000 +++ linux-2.4.30-pre2/mm/filemap.c 2005-02-23 07:45:15.000000000 +0000 @@ -1870,7 +1870,7 @@ static ssize_t common_sendfile(int out_f goto fput_in; if (!in_inode->i_mapping->a_ops->readpage) goto fput_in; - retval = locks_verify_area(FLOCK_VERIFY_READ, in_inode, in_file, in_file->f_pos, count); + retval = rw_verify_area(READ, in_file, &in_file->f_pos, count); if (retval) goto fput_in; @@ -1887,7 +1887,7 @@ static ssize_t common_sendfile(int out_f if (!out_file->f_op || !out_file->f_op->write) goto fput_out; out_inode = out_file->f_dentry->d_inode; - retval = locks_verify_area(FLOCK_VERIFY_WRITE, out_inode, out_file, out_file->f_pos, count); + retval = rw_verify_area(WRITE, out_file, &out_file->f_pos, count); if (retval) goto fput_out; @@ -2589,7 +2589,7 @@ static long madvise_willneed(struct vm_a long error = -EBADF; struct file * file; struct inode * inode; - unsigned long size, rlim_rss; + unsigned long size; /* Doesn't work if there's no mapped file. */ if (!vma->vm_file) @@ -2605,13 +2605,6 @@ static long madvise_willneed(struct vm_a end = vma->vm_end; end = ((end - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff; - /* Make sure this doesn't exceed the process's max rss. */ - error = -EIO; - rlim_rss = current->rlim ? current->rlim[RLIMIT_RSS].rlim_cur : - LONG_MAX; /* default: see resource.h */ - if ((vma->vm_mm->rss + (end - start)) > rlim_rss) - return error; - /* round to cluster boundaries if this isn't a "random" area. */ if (!VM_RandomReadHint(vma)) { start = CLUSTER_OFFSET(start); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/core/dev.c linux-2.4.30-pre2/net/core/dev.c --- linux-2.4.29/net/core/dev.c 2004-04-14 13:05:41.000000000 +0000 +++ linux-2.4.30-pre2/net/core/dev.c 2005-02-23 07:45:40.000000000 +0000 @@ -2180,10 +2180,26 @@ static int dev_ifsioc(struct ifreq *ifr, case SIOCSIFNAME: if (dev->flags&IFF_UP) return -EBUSY; - if (__dev_get_by_name(ifr->ifr_newname)) - return -EEXIST; - memcpy(dev->name, ifr->ifr_newname, IFNAMSIZ); - dev->name[IFNAMSIZ-1] = 0; + /* Check if name contains a wildcard */ + if (strchr(ifr->ifr_newname, '%')) { + char format[IFNAMSIZ + 1]; + int ret; + memcpy(format, ifr->ifr_newname, IFNAMSIZ); + format[IFNAMSIZ-1] = 0; + /* Find a free name based on format. + * dev_alloc_name() replaces "%d" with at max + * 2 digits, so no name overflow. - Jean II */ + ret = dev_alloc_name(dev, format); + if (ret < 0) + return ret; + /* Copy the new name back to caller. */ + strncpy(ifr->ifr_newname, dev->name, IFNAMSIZ); + } else { + if (__dev_get_by_name(ifr->ifr_newname)) + return -EEXIST; + memcpy(dev->name, ifr->ifr_newname, IFNAMSIZ); + dev->name[IFNAMSIZ-1] = 0; + } notifier_call_chain(&netdev_chain, NETDEV_CHANGENAME, dev); return 0; @@ -2316,6 +2332,7 @@ int dev_ioctl(unsigned int cmd, void *ar * - return a value */ + case SIOCSIFNAME: case SIOCGMIIPHY: case SIOCGMIIREG: if (!capable(CAP_NET_ADMIN)) @@ -2351,7 +2368,6 @@ int dev_ioctl(unsigned int cmd, void *ar case SIOCDELMULTI: case SIOCSIFHWBROADCAST: case SIOCSIFTXQLEN: - case SIOCSIFNAME: case SIOCSMIIREG: case SIOCBONDENSLAVE: case SIOCBONDRELEASE: diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/core/dst.c linux-2.4.30-pre2/net/core/dst.c --- linux-2.4.29/net/core/dst.c 2003-08-25 11:44:44.000000000 +0000 +++ linux-2.4.30-pre2/net/core/dst.c 2005-02-23 07:45:54.000000000 +0000 @@ -142,8 +142,13 @@ void __dst_free(struct dst_entry * dst) void dst_destroy(struct dst_entry * dst) { - struct neighbour *neigh = dst->neighbour; - struct hh_cache *hh = dst->hh; + struct neighbour *neigh; + struct hh_cache *hh; + + smp_rmb(); + + neigh = dst->neighbour; + hh = dst->hh; dst->hh = NULL; if (hh && atomic_dec_and_test(&hh->hh_refcnt)) diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/core/neighbour.c linux-2.4.30-pre2/net/core/neighbour.c --- linux-2.4.29/net/core/neighbour.c 2005-01-19 14:10:13.000000000 +0000 +++ linux-2.4.30-pre2/net/core/neighbour.c 2005-02-23 07:44:58.000000000 +0000 @@ -111,7 +111,7 @@ static int neigh_blackhole(struct sk_buf unsigned long neigh_rand_reach_time(unsigned long base) { - return (net_random() % base) + (base>>1); + return (base ? (net_random() % base) + (base >> 1) : 0); } @@ -1469,6 +1469,7 @@ static int neigh_fill_info(struct sk_buf nlh = NLMSG_PUT(skb, pid, seq, event, sizeof(*ndm)); ndm = NLMSG_DATA(nlh); + nlh->nlmsg_flags = pid ? NLM_F_MULTI : 0; ndm->ndm_family = n->ops->family; ndm->ndm_flags = n->flags; ndm->ndm_type = n->type; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/ip_fragment.c linux-2.4.30-pre2/net/ipv4/ip_fragment.c --- linux-2.4.29/net/ipv4/ip_fragment.c 2004-11-17 11:54:22.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/ip_fragment.c 2005-02-23 07:45:07.000000000 +0000 @@ -72,6 +72,7 @@ struct ipfrag_skb_cb struct ipq { struct ipq *next; /* linked list pointers */ struct list_head lru_list; /* lru list member */ + u32 user; u32 saddr; u32 daddr; u16 id; @@ -242,13 +243,13 @@ static __inline__ void ipq_kill(struct i /* Memory limiting on fragments. Evictor trashes the oldest * fragment queue until we are back under the threshold. */ -static void __ip_evictor(int threshold) +static void ip_evictor(void) { struct ipq *qp; struct list_head *tmp; int work; - work = atomic_read(&ip_frag_mem) - threshold; + work = atomic_read(&ip_frag_mem) - sysctl_ipfrag_low_thresh; if (work <= 0) return; @@ -273,11 +274,6 @@ static void __ip_evictor(int threshold) } } -static inline void ip_evictor(void) -{ - __ip_evictor(sysctl_ipfrag_low_thresh); -} - /* * Oops, a fragment queue timed out. Kill it and send an ICMP reply. */ @@ -324,7 +320,8 @@ static struct ipq *ip_frag_intern(unsign if(qp->id == qp_in->id && qp->saddr == qp_in->saddr && qp->daddr == qp_in->daddr && - qp->protocol == qp_in->protocol) { + qp->protocol == qp_in->protocol && + qp->user == qp_in->user) { atomic_inc(&qp->refcnt); write_unlock(&ipfrag_lock); qp_in->last_in |= COMPLETE; @@ -351,7 +348,7 @@ static struct ipq *ip_frag_intern(unsign } /* Add an entry to the 'ipq' queue for a newly received IP datagram. */ -static struct ipq *ip_frag_create(unsigned hash, struct iphdr *iph) +static struct ipq *ip_frag_create(unsigned hash, struct iphdr *iph, u32 user) { struct ipq *qp; @@ -363,6 +360,7 @@ static struct ipq *ip_frag_create(unsign qp->id = iph->id; qp->saddr = iph->saddr; qp->daddr = iph->daddr; + qp->user = user; qp->len = 0; qp->meat = 0; qp->fragments = NULL; @@ -385,7 +383,7 @@ out_nomem: /* Find the correct entry in the "incomplete datagrams" queue for * this IP datagram, and create new one, if nothing is found. */ -static inline struct ipq *ip_find(struct iphdr *iph) +static inline struct ipq *ip_find(struct iphdr *iph, u32 user) { __u16 id = iph->id; __u32 saddr = iph->saddr; @@ -399,7 +397,8 @@ static inline struct ipq *ip_find(struct if(qp->id == id && qp->saddr == saddr && qp->daddr == daddr && - qp->protocol == protocol) { + qp->protocol == protocol && + qp->user == user) { atomic_inc(&qp->refcnt); read_unlock(&ipfrag_lock); return qp; @@ -407,7 +406,7 @@ static inline struct ipq *ip_find(struct } read_unlock(&ipfrag_lock); - return ip_frag_create(hash, iph); + return ip_frag_create(hash, iph, user); } /* Add new segment to existing queue. */ @@ -641,7 +640,7 @@ out_fail: } /* Process an incoming IP datagram fragment. */ -struct sk_buff *ip_defrag(struct sk_buff *skb) +struct sk_buff *ip_defrag(struct sk_buff *skb, u32 user) { struct iphdr *iph = skb->nh.iph; struct ipq *qp; @@ -656,7 +655,7 @@ struct sk_buff *ip_defrag(struct sk_buff dev = skb->dev; /* Lookup (or create) queue header */ - if ((qp = ip_find(iph)) != NULL) { + if ((qp = ip_find(iph, user)) != NULL) { struct sk_buff *ret = NULL; spin_lock(&qp->lock); @@ -687,8 +686,3 @@ void ipfrag_init(void) ipfrag_secret_timer.expires = jiffies + sysctl_ipfrag_secret_interval; add_timer(&ipfrag_secret_timer); } - -void ipfrag_flush(void) -{ - __ip_evictor(0); -} diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/ip_input.c linux-2.4.30-pre2/net/ipv4/ip_input.c --- linux-2.4.29/net/ipv4/ip_input.c 2004-08-07 23:26:06.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/ip_input.c 2005-02-23 07:44:59.000000000 +0000 @@ -170,7 +170,7 @@ int ip_call_ra_chain(struct sk_buff *skb && ((sk->bound_dev_if == 0) || (sk->bound_dev_if == skb->dev->ifindex))) { if (skb->nh.iph->frag_off & htons(IP_MF|IP_OFFSET)) { - skb = ip_defrag(skb); + skb = ip_defrag(skb, IP_DEFRAG_CALL_RA_CHAIN); if (skb == NULL) { read_unlock(&ip_ra_lock); return 1; @@ -291,7 +291,7 @@ int ip_local_deliver(struct sk_buff *skb */ if (skb->nh.iph->frag_off & htons(IP_MF|IP_OFFSET)) { - skb = ip_defrag(skb); + skb = ip_defrag(skb, IP_DEFRAG_LOCAL_DELIVER); if (!skb) return 0; } diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/ipconfig.c linux-2.4.30-pre2/net/ipv4/ipconfig.c --- linux-2.4.29/net/ipv4/ipconfig.c 2004-11-17 11:54:22.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/ipconfig.c 2005-02-23 07:44:58.000000000 +0000 @@ -1162,7 +1162,7 @@ u32 __init root_nfs_parse_addr(char *nam if (*cp == ':') *cp++ = '\0'; addr = in_aton(name); - strcpy(name, cp); + memmove(name, cp, strlen(cp) + 1); } else addr = INADDR_NONE; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/ipvs/ip_vs_core.c linux-2.4.30-pre2/net/ipv4/ipvs/ip_vs_core.c --- linux-2.4.29/net/ipv4/ipvs/ip_vs_core.c 2005-01-19 14:10:13.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/ipvs/ip_vs_core.c 2005-02-23 07:44:59.000000000 +0000 @@ -506,7 +506,7 @@ static int ip_vs_out_icmp(struct sk_buff /* reassemble IP fragments, but will it happen in ICMP packets?? */ if (skb->nh.iph->frag_off & __constant_htons(IP_MF|IP_OFFSET)) { - skb = ip_defrag(skb); + skb = ip_defrag(skb, IP_DEFRAG_VS_OUT); if (!skb) return NF_STOLEN; *skb_p = skb; @@ -658,7 +658,7 @@ static unsigned int ip_vs_out(unsigned i /* reassemble IP fragments */ if (iph->frag_off & __constant_htons(IP_MF|IP_OFFSET)) { - skb = ip_defrag(skb); + skb = ip_defrag(skb, IP_DEFRAG_VS_OUT); if (!skb) return NF_STOLEN; iph = skb->nh.iph; @@ -1164,7 +1164,7 @@ static unsigned int ip_vs_forward_icmp(u return NF_ACCEPT; if (iph->frag_off & __constant_htons(IP_MF|IP_OFFSET)) { - skb = ip_defrag(skb); + skb = ip_defrag(skb, IP_DEFRAG_VS_FWD); if (!skb) return NF_STOLEN; *skb_p = skb; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/netfilter/ip_conntrack_core.c linux-2.4.30-pre2/net/ipv4/netfilter/ip_conntrack_core.c --- linux-2.4.29/net/ipv4/netfilter/ip_conntrack_core.c 2005-01-19 14:10:13.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/netfilter/ip_conntrack_core.c 2005-02-23 07:44:57.000000000 +0000 @@ -834,7 +834,10 @@ unsigned int ip_conntrack_in(unsigned in /* Gather fragments. */ if ((*pskb)->nh.iph->frag_off & htons(IP_MF|IP_OFFSET)) { - *pskb = ip_ct_gather_frags(*pskb); + *pskb = ip_ct_gather_frags(*pskb, + hooknum == NF_IP_PRE_ROUTING ? + IP_DEFRAG_CONNTRACK_IN : + IP_DEFRAG_CONNTRACK_OUT); if (!*pskb) return NF_STOLEN; } @@ -1183,29 +1186,22 @@ void ip_ct_refresh(struct ip_conntrack * WRITE_UNLOCK(&ip_conntrack_lock); } -int ip_ct_no_defrag; - /* Returns new sk_buff, or NULL */ struct sk_buff * -ip_ct_gather_frags(struct sk_buff *skb) +ip_ct_gather_frags(struct sk_buff *skb, u_int32_t user) { struct sock *sk = skb->sk; #ifdef CONFIG_NETFILTER_DEBUG unsigned int olddebug = skb->nf_debug; #endif - if (unlikely(ip_ct_no_defrag)) { - kfree_skb(skb); - return NULL; - } - if (sk) { sock_hold(sk); skb_orphan(skb); } local_bh_disable(); - skb = ip_defrag(skb); + skb = ip_defrag(skb, user); local_bh_enable(); if (!skb) { diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/netfilter/ip_conntrack_standalone.c linux-2.4.30-pre2/net/ipv4/netfilter/ip_conntrack_standalone.c --- linux-2.4.29/net/ipv4/netfilter/ip_conntrack_standalone.c 2005-01-19 14:10:13.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/netfilter/ip_conntrack_standalone.c 2005-02-23 07:45:30.000000000 +0000 @@ -393,13 +393,6 @@ static int init_or_cleanup(int init) cleanup_inandlocalops: nf_unregister_hook(&ip_conntrack_local_out_ops); cleanup_inops: - /* Frag queues may hold fragments with skb->dst == NULL */ - ip_ct_no_defrag = 1; - local_bh_disable(); - br_write_lock(BR_NETPROTO_LOCK); - br_write_unlock(BR_NETPROTO_LOCK); - ipfrag_flush(); - local_bh_enable(); nf_unregister_hook(&ip_conntrack_in_ops); cleanup_proc: proc_net_remove("ip_conntrack"); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/netfilter/ip_fw_compat.c linux-2.4.30-pre2/net/ipv4/netfilter/ip_fw_compat.c --- linux-2.4.29/net/ipv4/netfilter/ip_fw_compat.c 2003-11-28 18:26:21.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/netfilter/ip_fw_compat.c 2005-02-23 07:45:21.000000000 +0000 @@ -108,7 +108,7 @@ fw_in(unsigned int hooknum, (*pskb)->nh.raw, &redirpt, pskb); if ((*pskb)->nh.iph->frag_off & htons(IP_MF|IP_OFFSET)) { - *pskb = ip_ct_gather_frags(*pskb); + *pskb = ip_ct_gather_frags(*pskb, IP_DEFRAG_CONNTRACK_IN); if (!*pskb) return NF_STOLEN; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/netfilter/ip_nat_standalone.c linux-2.4.30-pre2/net/ipv4/netfilter/ip_nat_standalone.c --- linux-2.4.29/net/ipv4/netfilter/ip_nat_standalone.c 2005-01-19 14:10:13.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/netfilter/ip_nat_standalone.c 2005-02-23 07:46:16.000000000 +0000 @@ -201,7 +201,7 @@ ip_nat_out(unsigned int hooknum, I'm starting to have nightmares about fragments. */ if ((*pskb)->nh.iph->frag_off & htons(IP_MF|IP_OFFSET)) { - *pskb = ip_ct_gather_frags(*pskb); + *pskb = ip_ct_gather_frags(*pskb, IP_DEFRAG_NAT_OUT); if (!*pskb) return NF_STOLEN; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/sysctl_net_ipv4.c linux-2.4.30-pre2/net/ipv4/sysctl_net_ipv4.c --- linux-2.4.29/net/ipv4/sysctl_net_ipv4.c 2004-08-07 23:26:06.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/sysctl_net_ipv4.c 2005-02-23 07:46:10.000000000 +0000 @@ -268,6 +268,9 @@ ctl_table ipv4_table[] = { {NET_TCP_MODERATE_RCVBUF, "tcp_moderate_rcvbuf", &sysctl_tcp_moderate_rcvbuf, sizeof(int), 0644, NULL, &proc_dointvec}, + {NET_TCP_BIC_BETA, "tcp_bic_beta", + &sysctl_tcp_bic_beta, sizeof(int), 0644, NULL, + &proc_dointvec}, {0} }; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/ipv4/tcp_input.c linux-2.4.30-pre2/net/ipv4/tcp_input.c --- linux-2.4.29/net/ipv4/tcp_input.c 2005-01-19 14:10:13.000000000 +0000 +++ linux-2.4.30-pre2/net/ipv4/tcp_input.c 2005-02-23 07:45:00.000000000 +0000 @@ -107,6 +107,7 @@ int sysctl_tcp_vegas_gamma = 1<protocol]; struct nl_pid_hash *hash = &table->hash; + u32 pid = nlk_sk(sk)->pid; netlink_table_grab(); hash->entries--; - for (skp = hash->table; *skp; skp = &((*skp)->next)) { + for (skp = nl_pid_hashfn(hash, pid); *skp; skp = &((*skp)->next)) { if (*skp == sk) { *skp = sk->next; __sock_put(sk); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/netsyms.c linux-2.4.30-pre2/net/netsyms.c --- linux-2.4.29/net/netsyms.c 2005-01-19 14:10:14.000000000 +0000 +++ linux-2.4.30-pre2/net/netsyms.c 2005-02-23 07:45:24.000000000 +0000 @@ -287,7 +287,6 @@ EXPORT_SYMBOL(ip_dev_find); EXPORT_SYMBOL(inetdev_by_index); EXPORT_SYMBOL(in_dev_finish_destroy); EXPORT_SYMBOL(ip_defrag); -EXPORT_SYMBOL(ipfrag_flush); /* Route manipulation */ EXPORT_SYMBOL(ip_rt_ioctl); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/sched/cls_u32.c linux-2.4.30-pre2/net/sched/cls_u32.c --- linux-2.4.29/net/sched/cls_u32.c 2004-11-17 11:54:22.000000000 +0000 +++ linux-2.4.30-pre2/net/sched/cls_u32.c 2005-02-23 07:45:07.000000000 +0000 @@ -70,6 +70,7 @@ struct tc_u_hnode { struct tc_u_hnode *next; u32 handle; + u32 prio; struct tc_u_common *tp_c; int refcnt; unsigned divisor; @@ -271,6 +272,7 @@ static int u32_init(struct tcf_proto *tp root_ht->divisor = 0; root_ht->refcnt++; root_ht->handle = tp_c ? gen_new_htid(tp_c) : 0x80000000; + root_ht->prio = tp->prio; if (tp_c == NULL) { tp_c = kmalloc(sizeof(*tp_c), GFP_KERNEL); @@ -534,6 +536,7 @@ static int u32_change(struct tcf_proto * ht->refcnt = 0; ht->divisor = divisor; ht->handle = handle; + ht->prio = tp->prio; ht->next = tp_c->hlist; tp_c->hlist = ht; *arg = (unsigned long)ht; @@ -606,6 +609,8 @@ static void u32_walk(struct tcf_proto *t return; for (ht = tp_c->hlist; ht; ht = ht->next) { + if (ht->prio != tp->prio) + continue; if (arg->count >= arg->skip) { if (arg->fn(tp, (unsigned long)ht, arg) < 0) { arg->stop = 1; diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/sched/sch_ingress.c linux-2.4.30-pre2/net/sched/sch_ingress.c --- linux-2.4.29/net/sched/sch_ingress.c 2004-11-17 11:54:22.000000000 +0000 +++ linux-2.4.30-pre2/net/sched/sch_ingress.c 2005-02-23 07:46:15.000000000 +0000 @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -241,6 +242,15 @@ static struct nf_hook_ops ing_ops = NF_IP_PRI_FILTER + 1 }; +static struct nf_hook_ops ing6_ops = +{ + { NULL, NULL}, + ing_hook, + PF_INET6, + NF_IP6_PRE_ROUTING, + NF_IP6_PRI_FILTER + 1 +}; + int ingress_init(struct Qdisc *sch,struct rtattr *opt) { struct ingress_qdisc_data *p = PRIV(sch); @@ -249,8 +259,13 @@ int ingress_init(struct Qdisc *sch,struc if (nf_register_hook(&ing_ops) < 0) { printk("ingress qdisc registration error \n"); goto error; - } + } nf_registered++; + if (nf_register_hook(&ing6_ops) < 0) { + printk("IPv6 ingress qdisc registration error, " \ + "disabling IPv6 support.\n"); + } else + nf_registered++; } DPRINTK("ingress_init(sch %p,[qdisc %p],opt %p)\n",sch,p,opt); @@ -374,8 +389,11 @@ int init_module(void) void cleanup_module(void) { unregister_qdisc(&ingress_qdisc_ops); - if (nf_registered) + if (nf_registered) { nf_unregister_hook(&ing_ops); + if (nf_registered > 1) + nf_unregister_hook(&ing6_ops); + } } #endif MODULE_LICENSE("GPL"); diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/net/sched/sch_netem.c linux-2.4.30-pre2/net/sched/sch_netem.c --- linux-2.4.29/net/sched/sch_netem.c 2005-01-19 14:10:14.000000000 +0000 +++ linux-2.4.30-pre2/net/sched/sch_netem.c 2005-02-23 07:45:36.000000000 +0000 @@ -180,6 +180,7 @@ static int netem_enqueue(struct sk_buff if (q->loss && q->loss >= get_crandom(&q->loss_cor)) { pr_debug("netem_enqueue: random loss\n"); sch->stats.drops++; + kfree_skb(skb); return 0; /* lie about loss so TCP doesn't know */ } diff -Naur -p -X /home/marcelo/lib/dontdiff linux-2.4.29/scripts/Configure linux-2.4.30-pre2/scripts/Configure --- linux-2.4.29/scripts/Configure 2003-06-13 14:51:39.000000000 +0000 +++ linux-2.4.30-pre2/scripts/Configure 2005-02-23 07:45:00.000000000 +0000 @@ -378,15 +378,18 @@ function define_hex () { function hex () { old=$(eval echo "\${$2}") def=${old:-$3} - def=${def#*[x,X]} while :; do readln "$1 ($2) [$def] " "$def" "$old" - ans=${ans#*[x,X]} - if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then + if expr "$ans" : '0x[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then define_hex "$2" "$ans" break else - help "$2" + if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then + define_hex "$2" "0x$ans" + break + else + help "$2" + fi fi done }