From linux-kernel-owner+willy=40w.ods.org@vger.kernel.org Sun Mar 9 21:49:48 2003 Return-Path: Received: from vax.home.local (vax [10.2.1.2]) by alpha.home.local (8.12.4/8.12.1) with ESMTP id h29KnmN1004575 for ; Sun, 9 Mar 2003 21:49:48 +0100 Received: from vger.kernel.org (vger.kernel.org [209.116.70.75]) by vax.home.local (8.12.2/8.12.1) with ESMTP id h29Kng1Q031674 for ; Sun, 9 Mar 2003 21:49:46 +0100 (CET) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 9 Mar 2003 15:31:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 9 Mar 2003 15:31:38 -0500 Received: from home.linuxhacker.ru ([194.67.236.68]:45207 "EHLO linuxhacker.ru") by vger.kernel.org with ESMTP id ; Sun, 9 Mar 2003 15:31:36 -0500 Received: from car.linuxhacker.ru (localhost.localdomain [127.0.0.1]) by linuxhacker.ru (8.12.7/8.12.5) with ESMTP id h29KfPaZ031548; Sun, 9 Mar 2003 23:41:25 +0300 Received: (from green@localhost) by car.linuxhacker.ru (8.12.7/8.12.7/Submit) id h29KfPIo031546; Sun, 9 Mar 2003 23:41:25 +0300 Date: Sun, 9 Mar 2003 23:41:25 +0300 From: Oleg Drokin To: alan@redhat.com, linux-kernel@vger.kernel.org Cc: torvalds@transmeta.com Subject: Memleak in Windows Logical Disk Manager partition handler Message-ID: <20030309204125.GA31534@linuxhacker.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 833 Lines: 30 Status: RO Hello! Not freeing allocated memory on error exit path. See the patch. Should apply to both 2.4 and 2.5. Found with help of smatch + enhanced unfree script. Bye, Oleg ===== fs/partitions/ldm.c 1.6 vs edited ===== --- 1.6/fs/partitions/ldm.c Mon Aug 12 00:08:42 2002 +++ edited/fs/partitions/ldm.c Sun Mar 9 23:38:15 2003 @@ -1223,8 +1223,10 @@ return FALSE; } - if (!ldm_parse_vblk (data, len, vb)) + if (!ldm_parse_vblk (data, len, vb)) { + kfree(vb); return FALSE; /* Already logged */ + } /* Put vblk into the correct list. */ switch (vb->type) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/